From: Daniel Mack <daniel@zonque.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hvilleneuve@dimonoff.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: set driver name
Date: Fri, 31 May 2024 17:12:55 +0200 [thread overview]
Message-ID: <bc4d9470-340c-4559-b56f-7cce89c45d0b@zonque.org> (raw)
In-Reply-To: <2024053127-custody-bankable-817d@gregkh>
On 5/31/24 12:27, Greg KH wrote:
> On Fri, May 31, 2024 at 12:19:59PM +0200, Daniel Mack wrote:
>> Set the drv_name field of the driver struct so that the tty core
>> registers a procfs entry for it. This is useful for debugging.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> ---
>> drivers/tty/serial/sc16is7xx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
>> index bf0065d1c8e9..308edbacda7b 100644
>> --- a/drivers/tty/serial/sc16is7xx.c
>> +++ b/drivers/tty/serial/sc16is7xx.c
>> @@ -351,6 +351,7 @@ static struct uart_driver sc16is7xx_uart = {
>> .owner = THIS_MODULE,
>> .driver_name = SC16IS7XX_NAME,
>> .dev_name = "ttySC",
>> + .driver_name = SC16IS7XX_NAME,
>
> Are you sure this patch is correct? Look 2 lines up :)
>
Oh, Hugo did that already. Sorry for the noise.
Daniel
next prev parent reply other threads:[~2024-05-31 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 10:19 Daniel Mack
2024-05-31 10:27 ` Greg KH
2024-05-31 15:12 ` Daniel Mack [this message]
2024-06-01 9:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc4d9470-340c-4559-b56f-7cce89c45d0b@zonque.org \
--to=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®