From: Hans de Goede <hdegoede@redhat.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: add missing MODULE_DESCRIPTION() macros
Date: Tue, 2 Jul 2024 12:47:33 +0200 [thread overview]
Message-ID: <bc52402d-8ebe-4096-9a8e-94fac8747bd7@redhat.com> (raw)
In-Reply-To: <be4544a3-ac67-4d4c-b00b-0e2e47a7522a@quicinc.com>
Hi Jeff,
On 6/26/24 6:37 PM, Jeff Johnson wrote:
> On 6/10/2024 5:34 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/media/atomisp/i2c/atomisp-mt9m114.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c | 1 +
>> drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
>> index 7a20d918a9d5..3499353f8ea5 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
>> @@ -207,4 +207,5 @@ module_init(init_msrlisthelper);
>> module_exit(exit_msrlisthelper);
>>
>> MODULE_AUTHOR("Jukka Kaartinen <jukka.o.kaartinen@intel.com>");
>> +MODULE_DESCRIPTION("Helper library to load, parse and apply large register lists");
>> MODULE_LICENSE("GPL");
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> index 23b1001c2a55..918ea4fa9f6b 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> @@ -1614,4 +1614,5 @@ static struct i2c_driver mt9m114_driver = {
>> module_i2c_driver(mt9m114_driver);
>>
>> MODULE_AUTHOR("Shuguang Gong <Shuguang.gong@intel.com>");
>> +MODULE_DESCRIPTION("Aptina mt9m114 sensor support module");
>> MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240610-md-drivers-staging-media-atomisp-i2c-18a7a4f883eb
>>
>
> Following up to see if anything else is needed from me. Hoping to see this in
> linux-next so I can remove it from my tracking spreadsheet :)
This has already been merged in media-staging (the media's tree for-next)
by Hans Verkuil:
https://git.linuxtv.org/media_stage.git/log/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
Regards,
Hans
prev parent reply other threads:[~2024-07-02 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 0:34 Jeff Johnson
2024-06-26 16:37 ` Jeff Johnson
2024-07-02 10:47 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc52402d-8ebe-4096-9a8e-94fac8747bd7@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®