From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28AE035F8C1 for ; Wed, 14 Jan 2026 07:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375530; cv=none; b=htCIlzhDJP3kCant9kFPVgR7o0lEYrxJ0+EGBkYosUXPTRcI/IoNJMkKRqHajoTtBJtrdIOyx9tVsGpoi2zDP8ZJzjujdgrGhWPxI5TcWKCUGDyQJmuT/pVuyEziSLekc2h75DIdf4Jg+wOBEMrRkneHBz4ukNvGMtsKrwoA4RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375530; c=relaxed/simple; bh=jaK92eoy/8AAGH5vt4scZ0Q4tGzYmBAfKteMC+eKBnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H65mlrCD9hUn+g5i2TCVhUkDXSXZbZElv0InvHE7eTQnKQaUMovW+JSPf9x7PgqQ9YI8I/rzzIqK/rcpo2FZ6yub+OEMWmxDZIe9mOeyBaq314XAyi6dmHU/pr6o2HvCMmfaQqxhElbv6zODps5VaBv4yRCRdxUK3NgL+4XQLSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JPOUIh8J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vit2peHp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JPOUIh8J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vit2peHp" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E669LA1845685 for ; Wed, 14 Jan 2026 07:25:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EIKvwWZ09qPpnnCXZJpVZUB+Qv3PCgdJBJ893R52Bxs=; b=JPOUIh8JL8AIh38F T6ly9WdUMZhwcvqIYAb9kr4uOa00UrRr5rCUHqI1syDsVZ83hrMB8+8/5IMMmBHL AnzjE6Ydpi9a2XHXn3zIJFtUpWTmAkWbFa8uvL7dd1wWJlPkuMtwDNUNiEgftKG5 9PXGO4FnXwmUShAbB5lT98RD3vy0GmtBXtebUTDLxbrOxCqjwykMLkU28nrzKY9H InrAWgCv+Qzh87QAUMHpxJLNQ69xKm0i4RBrxIkrehE7lMFT2+VxwMv0kf2Yjnmq xQF5Iq4V8T8LV5mS9BCnWtFCQIyzUrZs26XwrA3FkvrLpmdjkPNZiDK2mh+Vo/j9 QcZtMw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnr3eb3j8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:25:22 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81c43a20b32so5438624b3a.0 for ; Tue, 13 Jan 2026 23:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375522; x=1768980322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EIKvwWZ09qPpnnCXZJpVZUB+Qv3PCgdJBJ893R52Bxs=; b=Vit2peHp1eQCUBzn5V0vwiavioiV7ZfX0uNJBwh8loGLDMzVYIuh2NgwB5kRmpJTFR SkGLDpyQ2xHhd1WXLt5idOQZPwRbuXj4sIw642Sf9i6RarfIAnHMpmLDd+chCCzSBWne +PSWX/8JuaN0pryfEFKFkgfguAJ0L/uQUrAKxwWRwzPoEWlTohxQTP7ksnWZ8oOdMBUu gd1KVD+SMfh0l981TK9QECuEonfj42mETRDJJFcG79HrTPG30yZcGfvLb8C5oiJei9km 7NG4W+tdYfC+id0G+Xs4HQBg78A9jx6vu3q2pNdUhR2yoMVanKE9Zl6TMbvxRnEz6UfR E8iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375522; x=1768980322; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EIKvwWZ09qPpnnCXZJpVZUB+Qv3PCgdJBJ893R52Bxs=; b=i0l9o37QSqN/bktSi2671b1oyp/RLY9OJiv5wcuFnDjaRr6sj89PtmsSqAs2o+tHwo oBzMHepNm4bygio9yCl6e7/KW297x6FGcEnmigUbvAot6Uaagr0xawZyA+gmeL1ONqg1 HsK25vnEJQhMOhourUKUu9pEzoB9eEXXQUILppHBtcy/763oI623O3v5ImAQdkoDcdHB HAQ6tiTIXxJm4sH/1BN7n6Poctn757pGW50tU2JkKIoCmtuF+3RPg3dTnaljQn7jKhO1 RASXXzoJbGG7fjZlbZC0MwOdBnGv/C7yQNCUTBM8HsJTh208GrdPHMGbfyiHPfma/1pX dlCA== X-Forwarded-Encrypted: i=1; AJvYcCWbNlB/LUMYP4a1xbQah040+dG/wWibE9DyrLwCM8by+kU+4LjhjNo7/2PAcRfdT6n0Sp4CmI7YMQdhXnk=@vger.kernel.org X-Gm-Message-State: AOJu0YyRyTLMt60Z6kWmqSpCRu+BtNRrbBQaUnvgD0Dl1NOWoTSs7VmV vz3Il6B4XTfRCZQ4K4vNoM3WzOAEya/Gdu4baG6uBiksjQ5yyMGlncJ0HnBpnMDvuUxCp/XbeUD sxP09ohqdT5mO/KHt7EZRP9p1NmzzxxoXAdtY1xFQ0ug2BCUL8vZODdaahkLpps0DRo4= X-Gm-Gg: AY/fxX40T4xIL1FSCUvUpMD0wLX33lO6GyB3+RI33gyW5LGyYC7DpIYuUc3JuHsOFAM QpkE5HJTFUUT7VDN8gwAbqiQulnRp6HnpOpjzEc6s9WtU2RPYNFesBP3yiHLG92iezvKDtUTDxk mxxIZyJo7lQyD25lF3VI9yF7PJfoQdlqW/8riE+mRtRVh8vz6PeZjn+XYWi21c9euqSHTBrvk5a c2QAo51DCgXdUXkmxrBvg/Ii6JNvr1IzhpQDEl4NYQk/CI04mpzWAD2H+Btip2eUeKWNH2brxxG bhXuGgjqOv+aI3Zm8nQKoj8ZieCWC7oEMg2UqGDMmOrn7or9kOvRoRKZx2nX62urlHRuZERJNrU g9AGFV/xArOq0jAr0OejQrKZe2X7Np0B8vk1AnaE6fgmN X-Received: by 2002:a05:6a00:368c:b0:81e:f623:ba04 with SMTP id d2e1a72fcca58-81f81cc85ecmr1637014b3a.13.1768375521488; Tue, 13 Jan 2026 23:25:21 -0800 (PST) X-Received: by 2002:a05:6a00:368c:b0:81e:f623:ba04 with SMTP id d2e1a72fcca58-81f81cc85ecmr1636982b3a.13.1768375521017; Tue, 13 Jan 2026 23:25:21 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f87aa4f97sm245432b3a.69.2026.01.13.23.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:25:20 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 12:55:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 04/11] media: iris: don't specify min_acc_length in the source code Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-4-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-4-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TPFIilla c=1 sm=1 tr=0 ts=696744e2 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=52UxMbdsJFNFq4lwM_0A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NyBTYWx0ZWRfXyZQ6LcspRAUo uFcRe1gpM9wvBxFYDv/a7xwLZCAlBd9pF37JNCpZ9tp398wGAhDXvH+bkG9GZm9Lm6IjRui8WjH LO2A2PvKp4+HLhhfun3m0olvOORai5HFsKI3HLzbOXfyEYmD5R2kLwTnoErsSOam3Zuj9vAWMMz I+BBj/dkmMZRN0mtMRz8QVFzM5QmDSZk2o60p2e8iHEkOBLuUU+0hHYE8Si94D0Hxf4DZN6kREr gDhY0ym6u7yTbep7mnIKkTGK8/CT8HkbYpu7ASDoCFXQidGjlPJoi+5iDQ/02f1KylkAUHvUumH f1sFnc5HiDpcixwu+BJZHYuBnfUv1xDFcvXJJZ1EGajx5NFnACzuJELVbs5WxhCRbWnWabp5eNc sY77p6QhbTHt+To0N8Mfh4NUrwxYneGsu2EEVYSEdsrEr7ylf8GSALhj7ujCY0EQjEMMacKrdBR 8w0cBxdJOsdmM1JU7dA== X-Proofpoint-GUID: Vmrm3iy46e7mcmvBmOCsOWYbsZpnH2Wv X-Proofpoint-ORIG-GUID: Vmrm3iy46e7mcmvBmOCsOWYbsZpnH2Wv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140057 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > The min_acc length can be calculated from the platform UBWC > configuration. Use the freshly introduced helper and calculate min_acc > length based on the platform UBWC configuration instead of specifying it > directly in the source. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 5 ++++- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > index d77fa29f44fc..878e61aa77c3 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > @@ -3,6 +3,8 @@ > * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > +#include > + > #include "iris_hfi_common.h" > #include "iris_hfi_gen2.h" > #include "iris_hfi_gen2_packet.h" > @@ -120,6 +122,7 @@ static void iris_hfi_gen2_create_packet(struct iris_hfi_header *hdr, u32 pkt_typ > > void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_header *hdr) > { > + const struct qcom_ubwc_cfg_data *ubwc = core->ubwc_cfg; > u32 payload = 0; > > iris_hfi_gen2_create_header(hdr, 0, core->header_id++); > @@ -146,7 +149,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->mal_length; > + payload = qcom_ubwc_min_acc_length_64b(ubwc) ? 64 : 32; > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_MAL_LENGTH, > HFI_HOST_FLAGS_NONE, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 8d8cdb56a3c7..3c5f3f68b722 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -73,7 +73,6 @@ struct tz_cp_config { > > struct ubwc_config_data { > u32 max_channels; > - u32 mal_length; > u32 highest_bank_bit; > u32 bank_swzl_level; > u32 bank_swz2_level; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index c1989240c248..c70cfc2fc553 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -633,7 +633,6 @@ static const struct platform_clk_data sm8550_clk_table[] = { > > static struct ubwc_config_data ubwc_config_sm8550 = { > .max_channels = 8, > - .mal_length = 32, > .highest_bank_bit = 16, > .bank_swzl_level = 0, > .bank_swz2_level = 1, > Reviewed-by: Dikshita Agarwal Thanks, Dikshita