From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83EF423CB; Mon, 10 Feb 2025 00:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739147284; cv=none; b=G3/Fw0s+B/RVqQA00kqAgI6YWp82u0vK28DPPYQY9EFnzadAWp9FB3bbLLmxoiy8FE2DDUIODnLj3GMgXdgfcgQox62lCXOKKgeA8cZF8F+SyHZtfPFS/vHl4E4/3oKeqzq4iwzMIGvsQpGhSRyUSiZ9jjnBf1vA9WBhkjzf2h8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739147284; c=relaxed/simple; bh=fvqZn3dds/2vc743MN+NhZL253B6zh0m/oJAf86dSQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UKU4iZfm5CgCUiPzlRzx7ztDj0nFtBxuQHWS2jZubO35aujnptKsv8X7zgCeQdx9a0kKgAZ2nqIY3qYbFdl7Sw3TLVEOTH3INuk0dnZ5tivR/h9FJTeJzLezo2EHn5HrVS4Rfc2xBVHaEP/Al27MOuSPxuU3fC3d2RmutrpZK0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=tJ+Ysb81; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tJ+Ysb81" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9+OuQB8vrs+CeMFvejhrtScCH5/Bhssr04jN9BqY/Ig=; b=tJ+Ysb81mPEctH9wES4dKgtK5b ix/tJ/3uqz7VeeEMP7zC9Q9lSy/eyasx8tlX2rH+ci5buSImWKcmcJESC4RMWeCRQAzxLhSeqYTGW CnzJ4otjw6eLvSEnyOzwds+qINFWKWjJzqH/f+fJorCDWmUVIn727rDo+fRZ8WSxzULI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1thHeP-00CYAE-Nu; Mon, 10 Feb 2025 01:27:49 +0100 Date: Mon, 10 Feb 2025 01:27:49 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Stefan Eichenberger , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Niklas =?iso-8859-1?Q?S=F6derlund?= , Gregor Herburger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: phy: marvell-88q2xxx: Add support for PHY LEDs on 88q2xxx Message-ID: References: <20250207-marvell-88q2xxx-leds-v2-1-d0034e79e19d@gmail.com> <20250209084135.GA3453@debian> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250209084135.GA3453@debian> On Sun, Feb 09, 2025 at 09:41:35AM +0100, Dimitri Fedrau wrote: > Hi Stefan, > > Am Sat, Feb 08, 2025 at 05:44:26PM +0100 schrieb Stefan Eichenberger: > > On Fri, Feb 07, 2025 at 05:24:20PM +0100, Dimitri Fedrau wrote: > > > Marvell 88Q2XXX devices support up to two configurable Light Emitting > > > Diode (LED). Add minimal LED controller driver supporting the most common > > > uses with the 'netdev' trigger. > > > > > > Signed-off-by: Dimitri Fedrau > > > > Reviewed-by: Stefan Eichenberger > > > > thanks for reviewing. I just noticed that led0 is enabled in > mv88q222x_config_init, but I think it should be enabled in > mv88q2xxx_config_init because LED configuration is same for all > mv88q2xxx devices. What do you think ? The code looks O.K. to me, so please add my Reviewed-by: Andrew Lunn if you decide to change to the generic 2xxx. Andrew