From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753080AbcIFBiE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Sep 2016 21:38:04 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:36678 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751018AbcIFBiC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Sep 2016 21:38:02 -0400
Subject: Re: [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
References: <1472701196-14795-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <1472701196-14795-4-git-send-email-hpeter+linux_kernel@gmail.com>
 <CAPybu_1-N_+QJwUtfxHRs84Mnd=D72xnprSSjX1jqLK2AN_eyA@mail.gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        Peter Hurley <peter@hurleysoftware.com>, linux-serial@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?UEEyMCBUT00gVFNBSSDolKHlrpfkvZE=?= 
        <tom_tsai@fintek.com.tw>,
        Peter H <peter_hong@fintek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Message-ID: <bc53ebae-1f0a-b7ff-90b3-4dfb6278da5f@gmail.com>
Date: Tue, 6 Sep 2016 09:37:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAPybu_1-N_+QJwUtfxHRs84Mnd=D72xnprSSjX1jqLK2AN_eyA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ricardo,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:16 寫道:
>> +static void fintek_8250_set_max_fifo(struct fintek_8250 *pdata)
>> +{
>> +       switch (pdata->pid) {
>> +       default: /* Default 16Bytes FIFO */
>> +               return;
>> +
>> +       case CHIP_ID_F81216H: /* 128Bytes FIFO */
>> +               sio_write_mask_reg(pdata, FIFO_CTRL,
>> +                                  FIFO_MODE_MASK | RXFTHR_MODE_MASK,
>> +                                  FIFO_MODE_128 | RXFTHR_MODE_4X);
>> +               break;
>> +       }
>
> I think it is more clear to have the default case as the ast one;

OK, I'll modify all default label to the last one.

>> +}
>> +
>>  static int find_base_port(struct fintek_8250 *pdata, u16 io_address,
>>                           unsigned int irq)
>
> I think that we should rename find_base_port to something else like
> probe_setup_port(),  we are not only finding the port but also setting
> it up.
>

OK, I'll modify it with next version.

-- 
With Best Regards,
Peter Hong