mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mauro Carvalho Chehab <maurochehab@gmail.com>,
	Baole Ni <baolex.ni@intel.com>
Cc: devel@driverdev.osuosl.org, k.kozlowski@samsung.com,
	mchehab@redhat.com, arnd@arndb.de, gregkh@linuxfoundation.org,
	linux-media@vger.kernel.org, mchehab@infradead.org,
	hverkuil@xs4all.nl, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, chuansheng.liu@intel.com,
	mchehab@kernel.org, linux-kernel@vger.kernel.org,
	m.chehab@samsung.com
Subject: Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 08:00:54 -0700	[thread overview]
Message-ID: <bc61742b-1a7d-ae1f-da8b-dc7888773677@infradead.org> (raw)
In-Reply-To: <20160802095118.47dcc5a6@recife.lan>

On 08/02/16 05:51, Mauro Carvalho Chehab wrote:
> Em Tue,  2 Aug 2016 20:01:34 +0800
> Baole Ni <baolex.ni@intel.com> escreveu:
> 
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
> 
> Gah!
> 
> A patch series with 1285 patches with identical subject!
> 
> Please don't ever do something like that. My inbox is not trash!
> 
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.
> 
> also, you need to send the patches to the subsystem mainatiner, and
> not adding a random list of people like this:
> 
> To: gregkh@linuxfoundation.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com
> 
> Btw, use *just* the more recent email of the maintainer, instead of
> spamming trash to all our emails (even to the ones that we don't use
> anymore!
> 
> I'll just send all those things to /dev/null until you fix your
> email sending process.
>
+1285

There are people at Intel who know about things like this.

-- 
~Randy

  reply	other threads:[~2016-08-02 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 12:01 Baole Ni
2016-08-02 12:51 ` Mauro Carvalho Chehab
2016-08-02 15:00   ` Randy Dunlap [this message]
2016-08-02 19:56   ` Steve Cotton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc61742b-1a7d-ae1f-da8b-dc7888773677@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@arndb.de \
    --cc=baolex.ni@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=k.kozlowski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=m.szyprowski@samsung.com \
    --cc=maurochehab@gmail.com \
    --cc=mchehab@infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®