From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759051AbYDHT6U (ORCPT ); Tue, 8 Apr 2008 15:58:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752255AbYDHT6N (ORCPT ); Tue, 8 Apr 2008 15:58:13 -0400 Received: from py-out-1112.google.com ([64.233.166.179]:33342 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbYDHT6M (ORCPT ); Tue, 8 Apr 2008 15:58:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=EVxAOr8nO0c3x14WAMq63eYWpUtZ8V+baogw5NzknrKzd7gF34tZ9n2qujT6FvyAUv3CHVsclwBeaE8+uahFyMkM3uzXbkyCpfs5eQZUeufILay+0164r4PIC9N6/AiF3jaS/3u1iHn3HJg4gZ7zDzULlpnbeoBadBCvi1knI1A= Message-ID: Date: Tue, 8 Apr 2008 23:58:11 +0400 From: Dmitry To: "Russell King" Subject: Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, haavard.skinnemoen@atmel.com, lethal@linux-sh.org, philipp.zabel@gmail.com, pavel@ucw.cz, tony@atomide.com, paul@pwsan.com In-Reply-To: <20080408193502.GB18053@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080403132142.GA26882@doriath.ww600.siemens.net> <20080403132411.GA27017@doriath.ww600.siemens.net> <20080407160155.5e6d77f0.akpm@linux-foundation.org> <20080408193502.GB18053@flint.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 2008/4/8, Russell King : > On Tue, Apr 08, 2008 at 01:52:41PM +0400, Dmitry wrote: > > 2008/4/8, Andrew Morton : > > > On Thu, 3 Apr 2008 17:24:11 +0400 > > > Dmitry Baryshkov wrote: > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > arch/arm/common/sa1111.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c > > > > index eb06d0b..282a4d9 100644 > > > > --- a/arch/arm/common/sa1111.c > > > > +++ b/arch/arm/common/sa1111.c > > > > @@ -627,7 +627,7 @@ __sa1111_probe(struct device *me, struct resource *mem, int irq) > > > > if (!sachip) > > > > return -ENOMEM; > > > > > > > > - sachip->clk = clk_get(me, "GPIO27_CLK"); > > > > + sachip->clk = clk_get(me, "3_6MHz_CLK"); > > > > if (!sachip->clk) { > > > > ret = PTR_ERR(sachip->clk); > > > > goto err_free; > > > > > > > > > Again, there's just not enough information for us (well: me) to be able to > > > evaluate this patch. > > > > > > For example, if the current name is "incorrect" then why shouldn't we fix > > > it in 2.6.25? 2.6.24? etc. > > > > > > > > > > The name GPIO27_CLK came from sa1100 arm sub-arch. There the 3.6 MHz > > clock was provided via GPIO 27. The PXA clocks code have copied the > > name for the clock (as it's used by sa1111 companion chip that can be > > used with both sa1100 and pxa). However on pxa the 3.6MHz clock is > > provided by different PIN. So the name GPIO27_CLK is misleading and > > incorrect for PXA. > > > So... what is the correct name. Bear in mind what I said in the previous > reply this evening - which says that it should be the name used by the > SA1111. Look in the data sheet - the pin itself to which the 3.6MHz > clock is supplised will have a name. That's the name which should be > used. I use the same pin/clock for the tc6393xb driver. And I'm pretty sure the datasheets won't agree on the name of the pin. Which name should I use? -- With best wishes Dmitry