From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752480AbdJ3No5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 09:44:57 -0400
Received: from mout.web.de ([212.227.17.11]:50142 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752362AbdJ3Noz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 09:44:55 -0400
Subject: Re: [PATCH 4/5] wlcore: Use common error handling code in
 wlcore_set_beacon_template()
To: Julian Calaby <julian.calaby@gmail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Eyal Reizer <eyalr@ti.com>, Iain Hunter <drhunter95@gmail.com>,
        James Minor <james.minor@ni.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Maxim Altshul <maxim.altshul@ti.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>
References: <dc2b8a7c-b4a9-2f92-12b4-a1d0d6911d7c@users.sourceforge.net>
 <f50c8edf-834d-9003-5a3c-dc83ec4016ce@users.sourceforge.net>
 <CAGRGNgUEFpva3ct-idAzip97eVgoDDTeEArAPcjvf90VSORA2g@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <bc692c11-63f8-a914-8767-1fc4248faae8@users.sourceforge.net>
Date: Mon, 30 Oct 2017 14:44:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAGRGNgUEFpva3ct-idAzip97eVgoDDTeEArAPcjvf90VSORA2g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:3OJHFkHKAttyWHjQV84Sy0/Ko7XDK9MWZkw73f+INCoyMVJZLMi
 TQVzLDlJ2tFiXt2MDUCeruUqCE9odAI9feaErcJ6NZpF6rQe4IHw3hn0w6lowzbcEoxnk9+
 NZnQ9RlAQn9lDXTWRKxNBsG8h6d1bKHbzSvq4j/L0KUujhXUvNnigmvGUhRJ/e/GffF9UhC
 ZJH4XDTsVGmynosqSgNVQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wVSwZFdax88=:HMGwn+dhFpein/ndkKdrz2
 YyaHb5UTDuSrzGlpwwkL5n3rxigXAKzkNGLNHlzM0LmxfB5WQ8QjjBGfjHMqdnaHVzxOdvYTL
 iQ5xjfFhuYWbvezDKjpWB1SzfWloBLr5lt/j6q8BFZxO8aSlb0saFVB43Dhs1+tPc7yNypsIJ
 Iw41D3c9CYEr8aa2h4lW7Ef66UsHfuR3B60xcO2oblz1y3MMTt/YcejgtbyXAnSZQm6eXyPmF
 xbyn7YfdYY4f1dyDZSWUddbnM1dAPkwcvT+UJgYC+MStwu21oIoYem9CAf6W34sVqhASZN4N6
 mVJI+dDs8P5Osn+rYYgSek6KH9yp4pV+czk3jB78zca8N/ZGiaEnRFYlOjH0rktYphN1lvvpM
 PtSDNE0z23zkZOC3uIEVTlFu64SYe2pC1Wc/Rxe9MLNlmrqFLP3UlV/8hzk0ekKVewhCMVK1f
 sArkn0vrO4ZtXSf9gjORSCw/WABXWMuHd+HNbLObSNdzItIqTraBjZUfCyU8IObRH1xLINQsD
 xBMGEZ/Z+ojCsQUbSvq9LjPdDH2GI8mSnUtgwOJUZknAVGzIN0nUpZu+aLHecEsLOIBW2b+sx
 q/uJUkxmwCw5DxlPF9HyVlPHzAOlbFEC7lISrxKghH0ri6cPnr7GrtqjsP1sVY11FFVKUUwmG
 GZjU+uipGHaOd8DpIJ5LpWoRjq9lhoOXZMJ6Ag66Vwf2sLRqchz9euWeWcGHfo9aH8sDdgTuM
 yZZ9YJQZm/rsLnwKQlmz4Cik01OUVx22NH1eh3GvW1s48DzUJZGn7GEashKmzn+dJecha94B+
 zMZVCKRe4u4SW1exfUkL4jJgKqr8IXifaigWyW5T6o3kIm4Z1c=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -4081,9 +4078,8 @@ static int wlcore_set_beacon_template(struct wl1271 *wl,
>>                                               beacon->data,
>>                                               beacon->len, 0,
>>                                               min_rate);
>> -end_bcn:
>> +free_skb:
> 
> Why rename the label?

I find it clearer according to the Linux coding style.

Regards,
Markus