From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Trevor Gamblin" <tgamblin@baylibre.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: pwm: Correct indentation and style in DTS example
Date: Tue, 07 Jan 2025 14:05:37 +0000 [thread overview]
Message-ID: <bc6a76d6e59c0271bf907cd2cf6dd3c03cc59c2e.camel@gmail.com> (raw)
In-Reply-To: <20250107125831.225068-1-krzysztof.kozlowski@linaro.org>
On Tue, 2025-01-07 at 13:58 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Acked-by: Nuno Sa <nuno.sa@analog.com>
> Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 8 ++++----
> .../devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml | 8 ++++----
> Documentation/devicetree/bindings/pwm/brcm,kona-pwm.yaml | 8 ++++----
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> index aa35209f74cf..45e112d0efb4 100644
> --- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -41,8 +41,8 @@ unevaluatedProperties: false
> examples:
> - |
> pwm@44b00000 {
> - compatible = "adi,axi-pwmgen-2.00.a";
> - reg = <0x44b00000 0x1000>;
> - clocks = <&spi_clk>;
> - #pwm-cells = <3>;
> + compatible = "adi,axi-pwmgen-2.00.a";
> + reg = <0x44b00000 0x1000>;
> + clocks = <&spi_clk>;
> + #pwm-cells = <3>;
> };
> diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
> b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
> index 119de3d7f9dd..44548a9da158 100644
> --- a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
> @@ -35,8 +35,8 @@ additionalProperties: false
> examples:
> - |
> pwm: pwm@f0408000 {
> - compatible = "brcm,bcm7038-pwm";
> - reg = <0xf0408000 0x28>;
> - #pwm-cells = <2>;
> - clocks = <&upg_fixed>;
> + compatible = "brcm,bcm7038-pwm";
> + reg = <0xf0408000 0x28>;
> + #pwm-cells = <2>;
> + clocks = <&upg_fixed>;
> };
> diff --git a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.yaml
> b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.yaml
> index e86c8053b366..fd785da5d3d7 100644
> --- a/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/brcm,kona-pwm.yaml
> @@ -43,9 +43,9 @@ examples:
> #include <dt-bindings/clock/bcm281xx.h>
>
> pwm@3e01a000 {
> - compatible = "brcm,bcm11351-pwm", "brcm,kona-pwm";
> - reg = <0x3e01a000 0xcc>;
> - clocks = <&slave_ccu BCM281XX_SLAVE_CCU_PWM>;
> - #pwm-cells = <3>;
> + compatible = "brcm,bcm11351-pwm", "brcm,kona-pwm";
> + reg = <0x3e01a000 0xcc>;
> + clocks = <&slave_ccu BCM281XX_SLAVE_CCU_PWM>;
> + #pwm-cells = <3>;
> };
> ...
next prev parent reply other threads:[~2025-01-07 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 12:58 Krzysztof Kozlowski
2025-01-07 14:05 ` Nuno Sá [this message]
2025-01-07 15:52 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6a76d6e59c0271bf907cd2cf6dd3c03cc59c2e.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tgamblin@baylibre.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome