From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A9B33A6F9 for ; Fri, 27 Mar 2026 02:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774578242; cv=none; b=kV5TNDXgRaeK1U3Fh06luBrHAuqmxx/q88QiAf1y4caxdih9Q5HPESNC/HA9xBQgxKPyJRkFMxbhhhFJYS35sbxk4BveLV9sefteIi9+yy4GPjINNgLS4x+cLnPEU+A6CmANbbB8tsEO6KRyg57yihz5HAhsU5/p5N4qNXuPKSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774578242; c=relaxed/simple; bh=i4N0HAMPUm3zO7DR4evOSl6UDCHXGFgITARXSeiej4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e2qC8IdvpgKxbYayI0Kgj6N4pyw2MHlASzfj0pbd1iHhioHnp8Gooi4IAoqkTZZUtdXElxTlaVq6778tFA3gCXkTsShjQtG/0ODFYERLRQ6mkFx+QIxLcQHa6mWuacN8mCqfxNbgmBwT+k9doh+1N+yFFFulkqETomYDYc9DkpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pz5okk/d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ro3mAG6R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pz5okk/d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ro3mAG6R" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R1Q2P81658558 for ; Fri, 27 Mar 2026 02:24:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ma8Dtb5mLRnOlanyBjOcRR4ysLdtbJQy/XPGvVqSw0s=; b=Pz5okk/dAmH6Xe1C t32tYr63p8GljDR73ywqS6Lbr94+QY0CQiBDiYkQdmOfAQzykOURiSoCOXMnFVOW rf6xmxkF5cRAwxh2cMpuTD+708LW2OXwk77no7XYJtptPG2g6XPG5TeBULvRc6U3 TLVJn2Gqd+D+9vbG7E/I48sgVFEl/ddvoUJQcfCmqxlO/kdlGUtwxCrDccWF8D24 II/Znf7nBHIocqkHMnhK9W2kTsI8+uzjNWA6sbJS3udJxHCAnEnsKaWR82cWryjx L2OfenT+zMMYgybkk6CifCl2ydNB63BerD3hHBAwT3z6EXyPl5RD8QMhg9vmmKvx HJKmSg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4w1qcbfa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 02:24:00 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c741b950511so1039311a12.0 for ; Thu, 26 Mar 2026 19:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774578240; x=1775183040; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ma8Dtb5mLRnOlanyBjOcRR4ysLdtbJQy/XPGvVqSw0s=; b=Ro3mAG6RU9l0Rc5+i6eoJ4SBIEZnDuhHo8pcUgVQTbRhvA4l8BAfw2PIwII5tBfxGX KSKIOliwBZZc5FXQWj2p+8Win/6sdiRsaHit9HYtoeusNP2B1soKdPcDE8Nga+/PU571 2n9oUCxK3H6Bwz4O8IGDLlR5r6V3hE+UYALqN2c1KE7I+lN+X9ixLQMtu2uhWHDmlTsb CTaqC13dfhtaVBPEXWTjaNgWBUK7prAXTCuTpbhMo+N0PwKIsQCDVR/BCGurfES7wyf0 DEmiF3ZYuqttLZ5O4ULLFb3c9aFZpSPAJQGpWt22VJrlqTDZxEVP+iqU9gWyXrvqbYoH GIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774578240; x=1775183040; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ma8Dtb5mLRnOlanyBjOcRR4ysLdtbJQy/XPGvVqSw0s=; b=c546PVDJtOWzJGK7nD41Z7phiKAm4yCT8O7JWSnZzrWPxMBFKRzSafa3CjbE4rmULr bt7BvW2xwOI6Mujmsk+tMSPOV6cAI0KuQEvRhNJc96BQYoordPXK8aU8Vrif5kLs57tx 4kUBOXfvbKQw5GOBtf738NmYq7B7Q9JKsOBvv6/f0/HCFetvVjNy4lPaIiKvnrN6JKgI wvG8o7VyWRVEJB+8Cqig3hDjKG9MKb8VwjWvNoBlS6ybQEK5EOwTyoo4rlVQ4Q9JMuDX bZeK4F3RZImwA1pgmDwytPewVdQ6dUBHpcGLkc9VA2V8p4xO15JA3Fo+Rn5JG1XAQEzF iURQ== X-Forwarded-Encrypted: i=1; AJvYcCXEV/ZIynSynOW+ZWeTuNaPJhD77gLy7gkSXWWFU8N5NadYkTTaeFNPmMs0WJsQV4hVlNbsKpz+xgsWTR0=@vger.kernel.org X-Gm-Message-State: AOJu0YzG0bey7gSCVn6/O3anH3LVx8Ahy32aLpJviy9RWPk0vD0abdLi 5GqCOGqe0kQiN2iBIUpffp4TevCtiI48G8NKm6ykoZe5eB0xdkqbe9ZPGcJcI7pTqEEJGpul1GQ WD58CTSFbXGB2eKWjtN4ViQxJFlzRfTGfPMVg5IbVKjurLkyA9XDhBtVe+Vz6FAZnzVM= X-Gm-Gg: ATEYQzxcYGE3OLh4FaLfAx+uvzxnCYCP/ccj852hvMC3R56NTca6wSM37e1fREZThhG MhO47Yr4xmKbHfTUrYoMFVSj/R2zFQ+ebaytHjYjKlf5iJp3STsKceZbCl2WemxSjj9Xx7HG07U p4GS3o2CYbzX/mEy5q6X1ZSzIb57iL7h/Z6l3ejBd/laD4elG75WmS9g89ztaP0+vZedcRI2VkC QypR/xQSzhOEhc0XZJ3srHvnzBSjwAH261n4GnHteHouV110NVgVk5WE/rGT741ITlSN0/JJ3rN nm+dH7qyMIZZ+XR+V/NukLN1itliYMkTdVYzp+i9YuaSXMNc5Ov0EaplbuDoHlr0hX8YWKyO2dT m8MIoL7WLlPSIXLc3TJrY0Qs8dSOd8T2G+hiY+zUJipCp5H+bq51560cQgPHplcY+/x3Um9VSdc l/0iLzdbPvkDIGrOaTmA== X-Received: by 2002:a05:6a00:1803:b0:829:8c08:d1f4 with SMTP id d2e1a72fcca58-82c9605c95bmr685471b3a.39.1774578239899; Thu, 26 Mar 2026 19:23:59 -0700 (PDT) X-Received: by 2002:a05:6a00:1803:b0:829:8c08:d1f4 with SMTP id d2e1a72fcca58-82c9605c95bmr685441b3a.39.1774578239395; Thu, 26 Mar 2026 19:23:59 -0700 (PDT) Received: from [10.133.33.251] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d3c2714sm3848975b3a.48.2026.03.26.19.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 19:23:59 -0700 (PDT) Message-ID: Date: Fri, 27 Mar 2026 10:23:54 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver To: Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Bryan O'Donoghue , Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260326-x1e-csi2-phy-v5-0-0c0fc7f5c01b@linaro.org> <20260326-x1e-csi2-phy-v5-2-0c0fc7f5c01b@linaro.org> Content-Language: en-US From: Hangxiang Ma In-Reply-To: <20260326-x1e-csi2-phy-v5-2-0c0fc7f5c01b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: nu5eDEEKEIcUtpW8Ugw93YpiLwk8vYiH X-Authority-Analysis: v=2.4 cv=HvV72kTS c=1 sm=1 tr=0 ts=69c5ea40 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=irf8UKbSWqAIktAtPRAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAxNiBTYWx0ZWRfXzqJlmTgFMrFn hK7CFmbMmuH29tFOb+XEdzbXfHD17ICXo11IZitr6HFjNuPx6bC9CMVzj5Bk9xOoqDLASvPfFvG wtL5A3kZNM2XEtqiGFB3GjCqzdfHUJABuwa8LZ68fqIDUukboyF9tqUSd+uKloNO5jEYmkoT1yK TY2umCvyv9mboo864DqQssBbkvccsGC1m/T6wXeo+Qgodonc8NNCXZTLNQaPiRXf+FXAfpavt9x Pq7nfMxHRulNZlGh3cozhgrXz8c6uOpQnAmJ6W2D3NkdJLhpKcci7fX5NT/JkV7kaVk3wJdIXZm Og6tmOFvlSB0/0YORW0A6a3gieuRU/TK3y3bcpvcdnk95Xc3/SG1qSZa3AQ0w/uPrVfNFS5t7dX PUO2kTHtxo5ihAq60hTX/mzxIiL/tdAEOvIY4H3O8FyfEYaU7fHKTQ6LPi3/OiHYkSvQbiWcp3w uZ0fxvodQUz2yz4CKXA== X-Proofpoint-GUID: nu5eDEEKEIcUtpW8Ugw93YpiLwk8vYiH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270016 On 3/26/2026 9:04 AM, Bryan O'Donoghue wrote: > +#include > +#include > +#include > +#include > + > +#include "phy-qcom-mipi-csi2.h" > + > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(offset, n) ((offset) + 0x4 * (n)) > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRL0_PHY_SW_RESET BIT(0) > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE BIT(7) > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRL6_COMMON_PWRDN_B BIT(0) > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRL6_SHOW_REV_ID BIT(1) > +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRL10_IRQ_CLEAR_CMD BIT(0) > +#define CSIPHY_3PH_CMN_CSI_COMMON_STATUSn(offset, n) ((offset) + 0xb0 + 0x4 * (n)) > Hi Bryan, one minor observation on the following macro: CSIPHY_3PH_CMN_CSI_COMMON_STATUSn The 0xb0 offset implicitly assumes a fixed distance between the common_ctrl and common_status register blocks. This holds for the PHYs covered by this series, but on some other platforms (e.g. Kaanapali, Pakala) the offset differs. That said, I think keeping this fixed value is reasonable for the scope of the current PHY series, and it does help keep the macro set simple. It might just be worth documenting this assumption (e.g. via a comment or in the commit message). Alternatively, if future PHY variants need to support different layouts, this could be made more extensible by moving the status base offset into the per-PHY data (similar to other register layout parameters). But I don’t think that needs to block the current series. Related patch before: Best Regards, Hangxiang