From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19321D6BB for ; Sat, 14 Mar 2026 19:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773517550; cv=none; b=GuyOQuhd3T/DagMB7pC6JtYNeD1YcVBRoYFqUFt3or7r3/0i2HFh7YGlQC8rYKHM+xsJL3SGyUs8/9XS75CvW6S0rGIc4fPySpulfMDg8E0QpgonczsAA6oK7DFCHvOncP6PaIQ5wGNVz7Fz7C8+nSlRtoBVXTpaA6BYbEjh8xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773517550; c=relaxed/simple; bh=gxR5I/Cw7ri4X7gacYfnt6UdXddao9DjKdfjPmi9+Qk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ou8gpQQvXgGpueF6GERFobHBcCFSgb3OtqyVwTV4O4DXb7vq0R2DjFPfMtk46Bpr8aMvqBQFu04pbfkCMA9S2skph3BiWqDEIUTkHNFen4EpYWojMP42xHnXze9/g7fWs0cPa9eH8GfABvCmka0B5+bSpgf0H0u5NgE+0tluoR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HIYgHjo4; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HIYgHjo4" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-466f935a82fso2206124b6e.0 for ; Sat, 14 Mar 2026 12:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773517546; x=1774122346; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u0MLNTB4XLLA60/5fVGsQSATrXUs6qS3+xDBwwtavMs=; b=HIYgHjo4z2LlZGpFjKxCRqT9Pyz8lgbed/nx3QOEQNonIK9SWQ5FOPCuO6bGH3jQ7r fSgpvb8Qqy8fqPyaGYTOf2folON6OcBtPScqlaLooKzHYti/aQxMbNCyCd/HC/r8PTFM 78CzzMn+vnssZjPFXILitQL5V5KkPrtglDqQck8Yy5b+x93OW1/EYlouHyQq761kWP9f uoj4wh965ctvYkOjXdFQWhVdn7rIloZTPaWi6mTVUf2c3/qqrtrCqtitFQMp2LnnJjSC kNMdDGAfumQGeEXw9F5WKhD3+Ji/ZWkJbTEYeP4FEl5hL/LgZbHoVPUIwYfkhM4amlY4 SKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773517546; x=1774122346; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u0MLNTB4XLLA60/5fVGsQSATrXUs6qS3+xDBwwtavMs=; b=NT49qGYK54PF2menymPOIzhd20lwxwKB8QYPgE5NfDyRt7i8MytZG0OfhMs/0qzV8M EnBV2orgkzEZSw5vdTFMC+YYo6RlZr0qyZXOmp7A6dF7VM7PQUqTejbm7oSbSSmB7lTc uI6Ew+hvJ1+X54rBZpliKJLK9AqRemTFEUDoJTf22/Fz3p30RaPvIAvP3QIDnl/xKryN Nzl0Fcf9FiBPGgtUt73BLQ6Yu/R37Z8TC+TIGZi2wnUGKCMYxaKtGhPMQd2BBVFk73K5 AdEyfNLcCxCUkKpHbTSV/3g0GApc4mYGRDmin9MdSLTyj4YXg/DYUwGXWYJdn6iT/CKz sAFQ== X-Forwarded-Encrypted: i=1; AJvYcCUbQCbWsu6H8t2lyTqJgYn8pmKAy0ukZ1Np2sgtJI21GBcpRBgD+qvFP8r6P6ZeS49H3RW6Y/752ub+TRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YycLaX7CbVLgJuJpyLZcXyxRrr/yLCBqNvHdj6UpNm6FXBYJcqg 0T69pwkLUgnINgwEvTXvIKvdSOCdUn+Zv0c7rkjTZz2jwGxg3u4uk4LtLAb+aKa8Chc= X-Gm-Gg: ATEYQzyRlaaF+2PrYBnXmIcdedAJbTm+OWx9RK+AJUHYSUw89Uctp61uFlJ6Cug1hFq tPomfO6l99VrgajaYSmKg8To41duIzNhl2xOKbrhjbdYgjkf6Fp1jEf/Un8bj502hHaGLil6d4T I8SB0LOfDsyohd1KxVrmjPlYklM+kVMWRSNp1MkNHtav3fnuuHie1xNK+26l1DdRi6wsZhdcohA 8nGjL8DxblTNDX9qlrw5uWgbhlkraz+QYnmocUU+MnSQgGxQsaBkhg7ZBbQi15BC7hdSm5SKKk5 RJ3hAVW1+WNdhO05ngYhW14MPIa2ODJRMWAHvL3xpRrMH/3AYPPKL+XGZYbyWodMkEUl4iy8CO7 tndboT3+1+cpyWpDMCvnEGtqxEL5Jsd9vvRdioLHoMyCCYAalXY6j2w1JyUO9xKcyS9BevBIl6B SUR0yied1jcBoF3PuPhhDjxc12uYphyo1uyZXHo3CycpEbOSWqRECOk3lMEEklQ0pAeye8wgIyB Q== X-Received: by 2002:a05:6808:5291:b0:467:2a6e:adb3 with SMTP id 5614622812f47-4675713d63amr3911579b6e.23.1773517546490; Sat, 14 Mar 2026 12:45:46 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:14a9:db6c:e65a:4287? ([2600:8803:e7e4:500:14a9:db6c:e65a:4287]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e6c7885sm10950936fac.17.2026.03.14.12.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 12:45:45 -0700 (PDT) Message-ID: Date: Sat, 14 Mar 2026 14:45:44 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] iio: accel: sca3000: convert to guard(mutex) To: Rajveer Chaudhari , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260314170609.26827-1-rajveer.chaudhari.linux@gmail.com> <20260314170609.26827-9-rajveer.chaudhari.linux@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260314170609.26827-9-rajveer.chaudhari.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/26 12:06 PM, Rajveer Chaudhari wrote: > Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in > sca3000_print_rev(), sca3000_ring_int_process(), > sca3000_read_event_config(), __sca3000_hw_ring_state_set(), > sca3000_hw_ring_preenable(), sca3000_hw_ring_postdisable(), > sca3000_clean_setup(), sca3000_stop_all_interrupts(). > This ensures the mutex is released on all return paths and > allows returning directly without a goto label. > > Signed-off-by: Rajveer Chaudhari > --- ... > @@ -1132,24 +1131,18 @@ static int sca3000_read_event_config(struct iio_dev *indio_dev, > */ > if ((st->rx[0] & SCA3000_REG_MODE_MODE_MASK) > != SCA3000_REG_MODE_MEAS_MODE_MOT_DET) { can drop this { now. > - ret = 0; > - } else { > - ret = sca3000_read_ctrl_reg(st, > - SCA3000_REG_CTRL_SEL_MD_CTRL); > - if (ret < 0) > - goto error_ret; > - /* only supporting logical or's for now */ > - ret = !!(ret & sca3000_addresses[chan->address][2]); > + return 0; > } > - break; > + > + ret = sca3000_read_ctrl_reg(st, > + SCA3000_REG_CTRL_SEL_MD_CTRL); > + if (ret < 0) > + return ret; > + /* only supporting logical or's for now */ > + return !!(ret & sca3000_addresses[chan->address][2]); > default: > - ret = -EINVAL; > + return -EINVAL; > } > - > -error_ret: > - mutex_unlock(&st->lock); > - > - return ret; > } >