From: Yunfeng Ye <yeyunfeng@huawei.com>
To: <fweisbec@gmail.com>, <tglx@linutronix.de>, <mingo@kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Shiyuan Hu <hushiyuan@huawei.com>, Hewenliang <hewenliang4@huawei.com>
Subject: [PATCH] tick/nohz: Make the idle_exittime update correctly
Date: Tue, 15 Dec 2020 20:06:34 +0800 [thread overview]
Message-ID: <bc6f830d-21da-b334-9dfd-54dcf2d4f7a0@huawei.com> (raw)
In-Reply-To: <2e194669-c074-069c-4fda-ad5bc313a611@huawei.com>
The idle_exittime field of tick_sched is used to record the time when
the idle state was left. but currently the idle_exittime is updated in
the function tick_nohz_restart_sched_tick(), which is not always in idle
state when nohz_full is configured.
tick_irq_exit
tick_nohz_irq_exit
tick_nohz_full_update_tick
tick_nohz_restart_sched_tick
ts->idle_exittime = now;
So move to tick_nohz_stop_idle() to make the idle_exittime update
correctly.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
kernel/time/tick-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 749ec2a583de..be2e5d772d50 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -591,6 +591,7 @@ static void tick_nohz_stop_idle(struct tick_sched *ts, ktime_t now)
{
update_ts_time_stats(smp_processor_id(), ts, now, NULL);
ts->idle_active = 0;
+ ts->idle_exittime = now;
sched_clock_idle_wakeup_event();
}
@@ -901,7 +902,6 @@ static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now)
* Cancel the scheduled timer and restore the tick
*/
ts->tick_stopped = 0;
- ts->idle_exittime = now;
tick_nohz_restart(ts, now);
}
--
2.18.4
next prev parent reply other threads:[~2020-12-15 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 9:41 Yunfeng Ye
2020-12-15 12:06 ` Yunfeng Ye [this message]
2020-12-15 14:47 ` Frederic Weisbecker
2020-12-17 6:51 ` Yunfeng Ye
2020-12-17 13:59 ` Frederic Weisbecker
2020-12-18 0:54 ` Yunfeng Ye
2021-02-19 12:33 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6f830d-21da-b334-9dfd-54dcf2d4f7a0@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=fweisbec@gmail.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome