mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Olivier Moysan <olivier.moysan@foss.st.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: kernel@dh-electronics.com, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on avenger96
Date: Thu, 12 Jan 2023 15:28:20 +0100	[thread overview]
Message-ID: <bc75d243-b2dc-6192-1b93-0a15d3fe5639@denx.de> (raw)
In-Reply-To: <20230112104446.1140551-7-olivier.moysan@foss.st.com>

On 1/12/23 11:44, Olivier Moysan wrote:
> Use STM32 ADC generic bindings instead of legacy bindings on
> Avenger96 board.
> 
> The STM32 ADC specific binding to declare channels has been deprecated,
> hence adopt the generic IIO channels bindings, instead.
> The STM32MP151 device tree now exposes internal channels using the
> generic binding. This makes the change mandatory here to avoid a mixed
> use of legacy and generic binding, which is not supported by the driver.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>   .../boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 28 ++++++++++++++++---
>   1 file changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index 50af4a27d6be..62efb550ae64 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -113,15 +113,35 @@ &adc {
>   	status = "okay";
>   
>   	adc1: adc@0 {
> -		st,adc-channels = <0 1 6>;
> -		st,min-sample-time-nsecs = <5000>;

U-Boot drivers/adc/stm32-adc.c depends on these properties , so if you 
drop them here and U-Boot DTs gets synced with Linux, the ADC driver 
there will start failing. Can you update the U-Boot ADC driver too ?

Maybe the easiest way would be to retain the old properties for now with 
a comment, and add the new properties ?

  reply	other threads:[~2023-01-12 16:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 10:44 [PATCH 00/10] ARM: dts: stm32: add adc internal channels on stm32mp15 Olivier Moysan
2023-01-12 10:44 ` [PATCH 01/10] ARM: dts: stm32: add adc internal channels to stm32mp15 Olivier Moysan
2023-01-12 10:44 ` [PATCH 02/10] ARM: dts: stm32: add vrefint calibration on stm32mp15 Olivier Moysan
2023-01-12 11:46   ` Krzysztof Kozlowski
2023-01-12 10:44 ` [PATCH 03/10] ARM: dts: stm32: add vrefint support to adc2 " Olivier Moysan
2023-01-12 10:44 ` [PATCH 04/10] ARM: dts: stm32: enable adc on stm32mp15xx-dkx boards Olivier Moysan
2023-01-12 10:44 ` [PATCH 05/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on stm32mp157c-ed1 Olivier Moysan
2023-01-12 10:44 ` [PATCH 06/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on avenger96 Olivier Moysan
2023-01-12 14:28   ` Marek Vasut [this message]
2023-01-12 10:44 ` [PATCH 07/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on emstamp-argon Olivier Moysan
2023-01-12 10:44 ` [PATCH 08/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcom Olivier Moysan
2023-01-12 10:44 ` [PATCH 09/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-drc Olivier Moysan
2023-01-12 10:44 ` [PATCH 10/10] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-testbench Olivier Moysan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc75d243-b2dc-6192-1b93-0a15d3fe5639@denx.de \
    --to=marex@denx.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@dh-electronics.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®