From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C955125C81E for ; Sat, 1 Nov 2025 03:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761968297; cv=none; b=EiNtBLgKohjMwSSBTJwF7wY5fh8Q5iSRNSc9PTsf4eCBsO8dngCIay3+mMxLmZF3t7Ue2MwuDodw45HMVYh85ElAIsWD0TTL288sewZlvdZoC10XPnOqi9JtDPunad3c6T12T325ceYpHcv4PtYUmIddj/WnoPQTVgbtyca8kVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761968297; c=relaxed/simple; bh=QOV4s441pUMcnd5W23H/g9SGPLto9keaiax99h+lJMk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q2T3Xctkk0aaWSTsD45vRL7Uug+PRvQ8oa2zJzlHRvurfAEZTCq3GlMlJdwBormLaMOd80JxC3tXNIvJJDw+CUQ9dK3jyZMReKpwjzVNH/8mwYFuZgQk/mK/NGEFpD17oN19K+1239UwnyyjRkwBQOfGSi5IH/9l4flNdwG9xSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=boKYvFta; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C9J11lE0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="boKYvFta"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C9J11lE0" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A129lOx313986 for ; Sat, 1 Nov 2025 03:38:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j+MSSJNAnzhdO1DSldaGMP+f7736jkHHfxLd+CmKemI=; b=boKYvFta7QfNPlSX a8XeodXvIm/ciqgQ6avwi0jcO6Y12EQAPWIG105GUhI6dXv5tlXeWeOopsmVYb36 aUcdL49VKGbMMCD3YuiYixcNws712f0CNJpB8fz44w2khLY0XzUakC5RbeU0FUQW 6jPI9PCRzZQ05q4JtOD7RMxUBJ2W2EaH8Y+APaEWUcpL1sxQFU+csg5rGjS4Bg86 rP3g/5d9X88J+v56NtOhWx0JyJA8Wyj48Avw2Yodxkjcz9AaT9FWqczj/NtO8tWX LFqAf2UOl7Ad8AsYpLNy/A7FDJt0pOvg+L5lKNk7bu437bH1wig3PoJPH8DKkVSi s69Wuw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a595rr3hj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 01 Nov 2025 03:38:14 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-286a252bfbfso67521225ad.3 for ; Fri, 31 Oct 2025 20:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761968294; x=1762573094; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j+MSSJNAnzhdO1DSldaGMP+f7736jkHHfxLd+CmKemI=; b=C9J11lE0jNeHoxoHsbyzm7xrJOqBJqIewKy9y/VpkeF6BR+9xpPLD/YfXeifnURADH b7j9cICvXLH71w077xHn+wEMBBJ1XgzGdg6gWrIUlZs+ydAyL++Fm8DwJSZvzF/CZPJl umcbOtvLKYefBqBQKOaKFhUwGGCbMg25zmbCPDEKTk2Qrr6ab9GFSF1GF19qsLXc1c1m Do4+UrP3xMorA101P2GDWc0fMZ43BlKlnMdquohv21typ9GO+mVxnwnB0gm4qwsUvDLI EW+g91xwroj8Zp7IUoK5gFZ9bCF2vD9uvC887ZwZ4kARoXd9oHbFM1GMyN0akYaS6MRi BR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761968294; x=1762573094; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j+MSSJNAnzhdO1DSldaGMP+f7736jkHHfxLd+CmKemI=; b=R2nVxGZiwei5VUWY/bikW/pTNawIMoG0FRZENs6cVfY0DpzbcQ3nGzLtgxdiMkOvgt zMhA4v7lnzYrTMyiILavrpEzuzmbIwy2IzLrsEz6dxMKM9rL49VmWaB/OTad8d+82G8R 3WbRYCcpeHgUW/6+Mll2mHV90b09qtSDEkVbAOYObuF91yCCyTmaOOim1bW9/H+GkGaX uqeM8w0EuwKivNPJ2kR/BaFXlnTblfoq4J5E4hrP57PrIJUNZdb5oFFjy9Tl0x4vT55G LD+2C6tivFjWmhvOZVlwiWLQdwkVx7a0oTL39/GQL8IJJoBsXMPcrEU+JNqsldTzsZo4 ahDA== X-Forwarded-Encrypted: i=1; AJvYcCVbTF7QEvS+WiJDUJih8J5uqev6E2Mpia/Aiw5xCVtnsjR25skKjTyZsbydcmAK4AgKcxpnGrfBgiRtyh0=@vger.kernel.org X-Gm-Message-State: AOJu0YwCLyexD7zLRVESru4vv0npLZw76LpGVSf9Mr/1id+vZHshROcZ AV2ZwMYFnlWn3GPcsJ78ZL14fK9Q7AqTn76anj5JwIzEcQdJGZjhv+vn7uRhWYpESHHaFZHHuag VA0aqqPo+vPK5EYqIJkWAAbHSpsfSyiT7NlENlV68BI+IbBjfpo2SDCDLeVorGtaOm7+NswUM4O g= X-Gm-Gg: ASbGncv+N2IeiGGRqjxUGinL1gLT9ejuFKxGI7oJead969YS2gi0+KwJPwa7GLn2DFQ hbya7xOvjlRvptENMGrsYsHaNFySoppzMfFBKe0/p1Mbp5or1loFx4wNyIzPW1FYiSg0nje+Aov 9Sfnjf+enHWiScAOTzYSSxQ7VmhKhRk2TcZbdvvBp5b+zLfiwX15T+zsJUcXF2ojUh6r78gUzmD YRaYRYWDAfKEMBvd6vBePERXlfoD9KZizopxViUxg99+/RFvUGfMPNl6bqt48YNWLsk3SwKzTJ2 3+3QV/H1XQcI49H74zBLTNOCWj6IKuHiwKhgYTAF/3PwSLyCuBAg7VuCUpBEVz2/0yNzlFpJgrk +nt/NuMhK8M0PFuHJUdqccC4LUSuB0cQREQ== X-Received: by 2002:a17:902:e803:b0:295:5da6:600c with SMTP id d9443c01a7336-2955da66315mr875265ad.2.1761968293822; Fri, 31 Oct 2025 20:38:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhZKxQBBnG78bpCeGKL4Lw7oZMFbVF3Qy60/ZWNH7pX/qvw+SoCu2WjYCu2EsGiLa3sETv3Q== X-Received: by 2002:a17:902:e803:b0:295:5da6:600c with SMTP id d9443c01a7336-2955da66315mr874975ad.2.1761968293290; Fri, 31 Oct 2025 20:38:13 -0700 (PDT) Received: from [192.168.29.63] ([49.43.227.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2955615d720sm8247975ad.65.2025.10.31.20.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Oct 2025 20:38:12 -0700 (PDT) Message-ID: Date: Sat, 1 Nov 2025 09:08:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/7] dt-bindings: PCI: Add binding for Toshiba TC9563 PCIe switch To: Bjorn Helgaas Cc: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jingoo Han , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20251031221238.GA1711866@bhelgaas> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20251031221238.GA1711866@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hkoxciSLhGPwiYh9DVjFYjj3vog9qKzg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTAxMDAyNyBTYWx0ZWRfX/o1cKn7xtDCp BB84B5bCovVH2qyRqqatE3sDAiar3ShB3MhZQczVNaw/uwxWKxc8ANf4oYgn+djcy1ZsZyFxvxq g8xhLJQxs9qmKCZAsd7od1M8LxQ3DguwKxKoYXivZfV/w1Yw+3GndEZ3pooX83KOVM1llOSIUsx sLvp0b1gbM/ApsJQsVy/e5Pr+HoMfnaouTxJqa5izZzEct1LVr+uFKn0MeNzbtxyPhG638JHS9U mJIX3e5TFTZsRfPaTIeS7O1m3U61X1DNDNJ69Ib1Hue7espZvBwk35+Iu5gzn0JK5NSYr73c6rY aBQ+eHrQjoysZg7T/RMX+RXcsxOk+jeFQ1rKvgH/TpKiIzGsvuQKKJZuM3orBBRgGsNQ2TZPPwp kFEqjwwAJJDIKdfY9kvlwd/7LW/K2g== X-Proofpoint-ORIG-GUID: hkoxciSLhGPwiYh9DVjFYjj3vog9qKzg X-Authority-Analysis: v=2.4 cv=XYeEDY55 c=1 sm=1 tr=0 ts=690580a6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ISmZZG41GQzdpg15mxjwIw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=BNVTMueYxggUNz7gLWUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-10-31_08,2025-10-29_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511010027 On 11/1/2025 3:42 AM, Bjorn Helgaas wrote: > On Fri, Oct 31, 2025 at 05:00:13PM -0500, Bjorn Helgaas wrote: >> On Fri, Oct 31, 2025 at 04:41:58PM +0530, Krishna Chaitanya Chundru wrote: >>> Add a device tree binding for the Toshiba TC9563 PCIe switch, which >>> provides an Ethernet MAC integrated to the 3rd downstream port and >>> two downstream PCIe ports. >>> + pcie@1,0 { >>> + compatible = "pciclass,0604"; >>> + reg = <0x20800 0x0 0x0 0x0 0x0>; >>> + #address-cells = <3>; >>> + #size-cells = <2>; >>> + device_type = "pci"; >>> + ranges; >>> + bus-range = <0x03 0xff>; >>> + >>> + toshiba,no-dfe-support; >> IIUC, there are two downstream ports available for external devices, >> and pcie@1,0 is one of them. >> >> 1) Putting "toshiba,no-dfe-support" in the pcie@1,0 stanza suggests >> that it only applies to that port. >> >> But from tc9563_pwrctrl_disable_dfe() in "[PATCH v8 6/7] PCI: >> pwrctrl: Add power control driver for tc9563", it looks like it's >> applied to the upstream port and both downstream ports. So I guess >> my question is putting "toshiba,no-dfe-support" in just one >> downstream port is the right place for it. > Oh, I see, never mind. You keep track of ->disable_dfe on a per-port > basis, so each port has the *possibility* of using it, and you skip > programming it if the port doesn't have it. > > I would assume the two downstream ports for external devices would be > identical, so I do still wonder why you would specify this for only > one of them. Hi Bjorn, As this is just an example, we just added here. In actually use case we are free to add it for any port. For remaining comments, you are right I didn't notice I am still using older one's I will fix in next series. - Krishna Chaitanya. >> 2) I see a lookup of "qcom,no-dfe-support" in [PATCH v8 6/7] PCI: >> pwrctrl: Add power control driver for tc9563; is that supposed to >> match this "toshiba,no-dfe-support"? >> >>> + }; >>> + >>> + pcie@2,0 { >>> + compatible = "pciclass,0604"; >>> + reg = <0x21000 0x0 0x0 0x0 0x0>; >>> + #address-cells = <3>; >>> + #size-cells = <2>; >>> + device_type = "pci"; >>> + ranges; >>> + bus-range = <0x04 0xff>; >>> + }; >>> + >>> + pcie@3,0 { >>> + compatible = "pciclass,0604"; >>> + reg = <0x21800 0x0 0x0 0x0 0x0>; >>> + #address-cells = <3>; >>> + #size-cells = <2>; >>> + device_type = "pci"; >>> + ranges; >>> + bus-range = <0x05 0xff>; >>> + >>> + toshiba,tx-amplitude-microvolt = <10>; > Same question here about whether "toshiba,tx-amplitude-microvolt" is > supposed to match the "qcom,tx-amplitude-microvolt" in the driver. > >>> + ethernet@0,0 { >>> + reg = <0x50000 0x0 0x0 0x0 0x0>; >>> + }; >>> + >>> + ethernet@0,1 { >>> + reg = <0x50100 0x0 0x0 0x0 0x0>; >>> + }; >>> + }; >>> + }; >>> + }; >>> + }; >>> >>> -- >>> 2.34.1 >>>