From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Daniel Golle <daniel@makrotopia.org>,
Detlev Casanova <detlev.casanova@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Shawn Lin <shawn.lin@rock-chips.com>,
Michael Riesch <michael.riesch@collabora.com>,
David Heidelberg <david@ixit.cz>,
Christian Hewitt <christianshewitt@gmail.com>,
Marc Zyngier <maz@kernel.org>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Hans Verkuil <hverkuil+cisco@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Diederik de Haas <diederik@cknow-tech.com>,
Dang Huynh <dang.huynh@mainlining.org>,
Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Subject: Re: [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches
Date: Fri, 20 Nov 2026 16:20:31 -0500 [thread overview]
Message-ID: <bc777a9772d1dd841d1928421a7881fb57f9d70a.camel@collabora.com> (raw)
In-Reply-To: <57258f1199fdbf24ac57081c6f3df219464e870a.1795191822.git.daniel@makrotopia.org>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Le vendredi 20 novembre 2026 à 17:41 +0000, Daniel Golle a écrit :
> The VDPU381 and VDPU346 have three read caches, configured through the
> "cache" register block. The driver leaves them in their reset state,
> and on the RK3568 some streams then decode with wrong output.
>
> Configure and clear the caches before each H.264 and HEVC run, the way
> the vendor kernel driver does. The "cache" block, which the binding
> requires, is now mapped at probe for every variant with named register
> blocks; the VDPU383 does not use it.
>
> On the RK3568 this fixes the HEVC conformance vectors RAP_B_Bossen_2,
> WPP_D_ericsson_MAIN_2, WPP_D_ericsson_MAIN10_2 and
> WPP_E_ericsson_MAIN_2 and the H.264 vectors CAPM3_Sony_D, MR8_BT_B,
> MR9_BT_B and NRF_MW_E.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-20 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:36 [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Daniel Golle
2026-11-20 17:40 ` [PATCH v5 1/5] media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings Daniel Golle
2026-11-20 20:19 ` Diederik de Haas
2026-11-20 20:24 ` Daniel Golle
2026-11-21 13:12 ` Krzysztof Kozlowski
2026-11-20 17:40 ` [PATCH v5 2/5] media: rkvdec: Add support for the VDPU346 variant Daniel Golle
2026-11-20 17:41 ` [PATCH v5 3/5] media: rkvdec: vdpu381: Program the read caches Daniel Golle
2026-11-20 21:20 ` Nicolas Dufresne [this message]
2026-11-20 17:41 ` [PATCH v5 4/5] arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X Daniel Golle
2026-11-20 17:42 ` [PATCH v5 5/5] arm64: dts: rockchip: rk356x: Clock the vdec at 400 MHz Daniel Golle
2026-11-20 20:16 ` [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc777a9772d1dd841d1928421a7881fb57f9d70a.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=christianshewitt@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dang.huynh@mainlining.org \
--cc=daniel@makrotopia.org \
--cc=david@ixit.cz \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=diederik@cknow-tech.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil+cisco@kernel.org \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=piotr.oniszczuk@gmail.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®