From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC043E47B for ; Thu, 4 Dec 2025 13:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855281; cv=none; b=f8Uet2uy0GD2M9W/AppRisl3zdP9o7Y9QNh6lDetX4og43IIa9UYuU1KUZ1SGxy/xFdTNGogwuN+C1k+JhRxsqmt1GIouIkxD55JLhmlGq34bhqGzWhWNRRC2rlrW14a1GrCkJOTOktWgUpBMoKt1rcZInuuDYcUkyVbV8oURdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855281; c=relaxed/simple; bh=Q2jvwnjGApk/ez8BkscDTm8TnqH3uXBkQS0E7jDf1M4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iRUz/rjzm6Svua8VBOqeX3VfBMLhF004XhP06LWFowP+gtMyr9KAaSOc3HlioJPgNbMzw3umppuo08XxB5f4IDApbR4KUtbNDKoqCszEGx0cv2xaTpgDSVgXGqOVlHmi/ub/gT7FwAcXRZyQa9W579JOr9bniflQ6mGGmXH4JCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=daWQPVHG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UeJ0peyG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="daWQPVHG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UeJ0peyG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B4AF1YU1043789 for ; Thu, 4 Dec 2025 13:34:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xCCJoAcemcOQIYIqAm5SIGE/QGpHdFGfYCUD4a1Bnug=; b=daWQPVHGlda3mdX4 iJ3dbT3v4eiAjQprBJCyOzHNQTNxOKFqaeHxj03O0OwqWmTruXQ07GFako8NyqZ5 5omjtjwWgXKfAnlpf2ks+3EGXCE+Tk2Q7r1JzI0NMo/xiXbT9RzkQoRTa7Bdapk/ gQPbhuWeuTu+QCvrLkeehGTqYf7LmcsRUA/rlDByKsWijov9X5FCfjMS9ZD2gPMB enWqcHK7bUaijDr1cwNUCPWMuBj1STJNLRm5adwsDVPkMcwaVNuRQ7UaOXa+/S50 7gllFjbxutBtooU3NWjZM+KxNPE3rxvrTJkoL2RLW2csxsNlVZT3hNVKbsvtLqxy 6e7gQw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4au6xp0waf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 13:34:35 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b196719e0fso32462085a.2 for ; Thu, 04 Dec 2025 05:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764855275; x=1765460075; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xCCJoAcemcOQIYIqAm5SIGE/QGpHdFGfYCUD4a1Bnug=; b=UeJ0peyG+W5eMnnyeQgguMlai7EPnNmqXwjfNjGD6kYB4MJDoXnoWUyZ3L0AAoEo3b YLuCsKL8zyBG1rcIUT2fcThv9XXoHupT2CD1Zf9FN5TS7+FJGGQyb889HpLYk4dW+dQN tXEbxwuYRNJPfgNPHUZlP3IyHj4Q798J1xLV6WTn1oVno/gA8pYVeZpqXhyLyG0Rafg5 mmTMKaiJP08tfxMVv5DLJtKc0APIXTr+XODeF/JIIaWUDDV5NjHhKhRqKpcFrRC+wIf+ 7SkoaV5+LhnFlzVbhRjdffTte6k/2KXuwoMgy+EMX7z1gjrTNgHeQz0hKWiyNuBoJej7 AiWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764855275; x=1765460075; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xCCJoAcemcOQIYIqAm5SIGE/QGpHdFGfYCUD4a1Bnug=; b=LzRK9Q4WqiTSRL726K0svazbLUxU1QsGGwfvjMY5Kx2ja7AeE0yBUDkcTDkiL+DKeX Mv+6eCsWGyGmCnNXzcciHEAucUSNf3vPHS8XS7xQeJFrRvQcduItSx8uzdtQ39u0z5cJ TKkcY/W2qtz4NvYBwvV81i9JHAjkstVe6jOccnGzQw09V5DcQKdVUNhdFIFTwLBpnlhS oiJfDnMeWsO+4eySDyfoH7SBPeboVXJrst43FTRQMElNNM1bahmuauILI0kkL2CywtUj rNCNP6hC72oHbCc72J/9eCFAfn1bmxDAZ/93kXsmnYbXv50o1CJCow5d4gR5G8UlDNXN N6NA== X-Forwarded-Encrypted: i=1; AJvYcCV2tRHlUdNNYVuuTpY7F2bjfT24Fl6Kin6LQJzQg5FZkGZfoxIClz5aRpI3nXHt4MAsGcoTRQqwyxjtI2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxZw+aT24gAKlW0hPe0+yUVtYjKozIartvRFuQYMquM/xw1WAi2 DG874OtjbncdAWWjosrpI9qZPTDa4qNKqBmJq1/1E+9LtjsAOSiKh47YS1Xz2qlrk3ykM7l+jAV JdqJvFgaqpBi1itJzZjF4QRNSPU0L9R4IQFNmZCfyIhJcgdsR5zX3NRLelO41ue8/HcA= X-Gm-Gg: ASbGncuuzmR8RYIo+9BHg3rsUn6YZwoepPoenRxEMyXG4gFDEkM4JqEpNgjNQHY7Ipa w9NCvTX/tqe/P6imXrjkmwYW+242+ivAeNJazO8e0NEqebBeNTfpuVhTe9zWMvmh6cCLlsv4uub qXufaDcdqe8gJPlpwIHgZ0I3Nke7t0Xw37Sq4AuWzEr/AG38mSMx1zh3w7xVFFAy5qkehPLUElg OumukMEXzfwY2QpwNeBjvHVmYWoC8qoO24vQlPedg14n1/R/MmLYp7S4jmrl9szspTQ9SsGlkVv 0BrXMMFIobAVhHMjq7hhVsI7YZtOeG6ZpbPpM08g6yRQPOal4n7LqQgcbEIo8mKFvKyo0UlKYRy kaPKZgocaZY5DxQrA7x1bHOhSRb/gJUBIaHue1ToXBWGVEtvl5d7I1Ovh2m8pIO8txw== X-Received: by 2002:a05:620a:4688:b0:8b2:dbf7:5193 with SMTP id af79cd13be357-8b5f9507b99mr567900685a.8.1764855274640; Thu, 04 Dec 2025 05:34:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWjMuRv8TnQVdBKFwGRc+UzlpNCLY6fm6IIDqIWP3X/6LSuHl/kT+6n0xNsqpZSClOaJAU0g== X-Received: by 2002:a05:620a:4688:b0:8b2:dbf7:5193 with SMTP id af79cd13be357-8b5f9507b99mr567896485a.8.1764855274118; Thu, 04 Dec 2025 05:34:34 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4975c56sm127125466b.33.2025.12.04.05.34.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 05:34:33 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 14:34:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support To: Griffin Kroah-Hartman , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20251204-aw86938-driver-v1-0-ebd71868df3a@fairphone.com> <20251204-aw86938-driver-v1-3-ebd71868df3a@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251204-aw86938-driver-v1-3-ebd71868df3a@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RKW+3oi+ c=1 sm=1 tr=0 ts=69318deb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6H0WHjuAAAAA:8 a=nkaG5teaT87xZXm8SjwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: UCkOt437aQIgSM3-ZMkQXr2fdcbWmBio X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDExMCBTYWx0ZWRfX3d2iSX6h3npz AwacTvS/4H0oyd8hJihhlNeXk5dgrxxffmMzU3TFqgYgIxDh9xiClj/OuasiIanm1ArqiPPIgWc 86SOG27jyvWMLn9J5/3SyHvfsD6BvCNWxTB5la3Dw+IGQR1pbI1ypK92qZrB6Og/x2Fp2EazTZD BjMxNQo+x2f6rK2gYEwiaBpnQPk/gxul4o6d0pl+yv1P1+D38cgoncF0Zq6EwLYL6f+ZoOZvDau Aij3FC+Ufm6cUuIpWDBBiQPT2nT1UQt2aC9Cdw2MtK9AA1qKRDcTcB7+HseyGpOJHd3sPB8AFj8 jUD4sWAUOxVfuP1hQsFr2NJu7VnqLVgDWqRvvuWTjZCiwmSEtrKlNNM1k3meGydW5Ql+zF/348+ pzUEqWYHU4MuzxkDZVE2WcyYSU+99w== X-Proofpoint-ORIG-GUID: UCkOt437aQIgSM3-ZMkQXr2fdcbWmBio X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_03,2025-12-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040110 On 12/4/25 1:29 PM, Griffin Kroah-Hartman wrote: > Add the required node for haptic playback (Awinic AW86938) > > Signed-off-by: Griffin Kroah-Hartman > --- > arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++ The DTS is unfortunately still not merged :/ Please arrange with Luca and either squash this into the resubmission (depending on how the driver changes go for the vibrator) or resend it afterwards > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > index 0a758fb7f4d413a84cdae695c38616fc6075db67..8c43bc9c1d8312f22ad0aeed84b23d52910e0ca6 100644 > --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > @@ -717,6 +717,16 @@ vreg_l7p: ldo7 { > > /* VL53L3 ToF @ 0x29 */ > /* AW86938FCR vibrator @ 0x5a */ You can remove this comment now The remainder of the patch lgtm Konrad