From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH 00/14] drm/tidss: dispc: Convert to FIELD_* API
Date: Fri, 8 Aug 2025 12:34:02 +0300 [thread overview]
Message-ID: <bc9058b8-18e6-4e68-b597-593fb72ebfd7@ideasonboard.com> (raw)
In-Reply-To: <20250730-drm-tidss-field-api-v1-0-a71ae8dd2782@kernel.org>
Hi Maxime,
On 30/07/2025 11:57, Maxime Ripard wrote:
> Hi,
>
> The tidss driver rolls its own API equivalent to the FIELD_* API already
> provided the kernel.
>
> Since it's an ad-hoc implementation, it also is less convenient and
> doesn't provide some useful features like being able to share the field
> definitions that will come handy in the future.
>
> Thus, this series converts the driver to that API and drops its own
> version.
>
> Let me know what you think,
I didn't test or go through in detail yet, but thumbs up from me for the
overall approach.
Tomi
prev parent reply other threads:[~2025-08-08 9:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 8:57 Maxime Ripard
2025-07-30 8:57 ` [PATCH 01/14] drm/tidss: dispc: Remove unused OVR_REG_GET Maxime Ripard
2025-07-30 8:57 ` [PATCH 02/14] drm/tidss: dispc: Switch to GENMASK instead of FLD_MASK Maxime Ripard
2025-07-30 8:57 ` [PATCH 03/14] drm/tidss: dispc: Switch to FIELD_PREP for FLD_VAL Maxime Ripard
2025-07-30 8:57 ` [PATCH 04/14] drm/tidss: dispc: Get rid of FLD_GET Maxime Ripard
2025-07-30 8:57 ` [PATCH 05/14] drm/tidss: dispc: Get rid of FLD_VAL Maxime Ripard
2025-07-30 8:57 ` [PATCH 06/14] drm/tidss: dispc: Switch FLD_MOD to using a mask Maxime Ripard
2025-07-30 8:57 ` [PATCH 07/14] drm/tidss: dispc: Switch REG_GET " Maxime Ripard
2025-07-30 8:57 ` [PATCH 08/14] drm/tidss: dispc: Switch REG_FLD_MOD " Maxime Ripard
2025-07-30 8:57 ` [PATCH 09/14] drm/tidss: dispc: Switch VID_REG_GET " Maxime Ripard
2025-07-30 8:57 ` [PATCH 10/14] drm/tidss: dispc: Switch VID_REG_FLD_MOD " Maxime Ripard
2025-07-30 8:57 ` [PATCH 11/14] drm/tidss: dispc: Switch VP_REG_GET " Maxime Ripard
2025-07-30 8:57 ` [PATCH 12/14] drm/tidss: dispc: Switch VP_REG_FLD_MOD " Maxime Ripard
2025-07-30 8:57 ` [PATCH 13/14] drm/tidss: dispc: Switch OVR_REG_FLD_MOD " Maxime Ripard
2025-07-30 8:57 ` [PATCH 14/14] drm/tidss: dispc: Define field masks being used Maxime Ripard
2025-07-31 13:04 ` [PATCH 00/14] drm/tidss: dispc: Convert to FIELD_* API Louis Chauvet
2025-07-31 13:26 ` Maxime Ripard
2025-07-31 13:49 ` Louis Chauvet
2025-07-31 14:05 ` Maxime Ripard
2025-08-08 9:34 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc9058b8-18e6-4e68-b597-593fb72ebfd7@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®