From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Konstantin Khorenko <khorenko@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Alistair Popple <apopple@nvidia.com>,
Dan Williams <djbw@kernel.org>
Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/huge_memory: take a reference on a folio PUD copied by fork
Date: Thu, 5 Nov 2026 16:54:41 +0100 [thread overview]
Message-ID: <bc91b6e5-ae31-4403-aee9-34b60ac83631@kernel.org> (raw)
In-Reply-To: <cfd786eb-4ae5-4dcc-a9f2-3eb4b7e7962c@virtuozzo.com>
On 11/5/26 15:19, Konstantin Khorenko wrote:
>> Introducing folio_dup_file_rmap_pud() is better. But please see how I move
>> the comment and how passing mm+vma to the helper is not really reasonable.
>
> Thanks, agreed on both. v2 will pass only the VMAs, with the mms taken
> from them as in your patch, drop src_mm from copy_pud_range() and move
> the TODO next to the rmap duplication. folio_dup_file_rmap_pud() stays.
>
> Could v2 then replace your 01/36, so you can drop it from your series?
I dropped my version already, so please resend and I'll queue that one.
--
Cheers,
David
next prev parent reply other threads:[~2026-11-05 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 18:10 [PATCH 0/2] mm/huge_memory: take a reference on a device DAX " Konstantin Khorenko
2026-10-21 18:10 ` [PATCH 1/2] mm/huge_memory: take a reference on a folio " Konstantin Khorenko
2026-10-25 12:52 ` David Hildenbrand (Arm)
2026-11-05 14:19 ` Konstantin Khorenko
2026-11-05 15:54 ` David Hildenbrand (Arm) [this message]
2026-10-21 18:10 ` [PATCH 2/2] selftests/mm: test fork of a device DAX PUD Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc91b6e5-ae31-4403-aee9-34b60ac83631@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=djbw@kernel.org \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®