From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516962530; cv=none; d=google.com; s=arc-20160816; b=T+SjIXNHpOK5iLtQBdL98rHudY3z6MWFaulLRbFi9bU55ROWkhJTI86UV4Nb2KLMmq wefjU+UTZXQcTUCG73sCd/gl26ATwpA4j7MDGaT5mk2njwbBj74JK2PzdyJWicebSuHJ VlLQz1Jjn9nrxLJiRq+RQGoIZ2cv4osysAR4uwiXkjQgGssFPCeyYWdEMKeXL4PE18H3 v2ZluMCoUVnq6/FOgJhTfkEP0OdxC5mSzSDt38BCR+q03fzrzjbhpAM7a7z/vKr6enkZ xvZWrnlfX6VqYwQjOOOkz3EfO3kqSC4vT6vfTkepuJ3v9jAh6nho6McjUaWTPdCdXOOj J5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=6ZVkcPpyf2llPN7U2QJQu64UzqrU4OdIH+K9+E8gZvA=; b=AN1wsKeYllaTutBevCY76c2S0veUOxLgm6lWyOp++ig8/rEiLBrYolSVoT4A/7b2Zs VN0FBLjBnH/7G0NClivgjPPduP+SWWQIFxz0q5d8u80gOoXLwdRFUEYzAhmXvaAtYgAi USKzd16q4zQ6Fax2m3zFUnR+63LihMfVxmAQ119MeYShrbPHtCDlwyQ3O/1mKcM8A+dK /BIaiDefMwOfv60B1qfvq7YUejfmICUBA8k13vjdwJctteiC9VrBceUtbYZ7cikSuxvS rfIxaPe6vTWSAfKb2ibXiu6XiUEtg04vjzMqp/EBRGN8RKfOjrwgYd/+0+wtuanBxIag XB1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DQqL2vu8; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DQqL2vu8; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: AH8x226a8KkoBorJkrkUAA5mcZT2vWjSO94NIEQ8TJVRYsR/6oacFyvojmH1+LKs/Tp4KwbwbFpI7g== Subject: Re: [PATCH] base: power: domain: Replace mdelay with msleep To: Pavel Machek Cc: rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, len.brown@intel.com, gregkh@linuxfoundation.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1516955899-31810-1-git-send-email-baijiaju1990@gmail.com> <20180126102604.GB13775@amd> From: Jia-Ju Bai Message-ID: Date: Fri, 26 Jan 2018 18:28:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180126102604.GB13775@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590643262439305991?= X-GMAIL-MSGID: =?utf-8?q?1590650502540053186?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018/1/26 18:26, Pavel Machek wrote: > On Fri 2018-01-26 16:38:19, Jia-Ju Bai wrote: >> After checking all possible call chains to genpd_dev_pm_detach() and >> genpd_dev_pm_attach() here, >> my tool finds that these functions are never called in atomic context, >> namely never in an interrupt handler or holding a spinlock. >> Thus mdelay can be replaced with msleep to avoid busy wait. >> >> This is found by a static analysis tool named DCNS written by > myself. > > Well, cond_resched() just after msleep certainly looks like that. > > Did the patch receive any testing? > Thanks for reply :) I only perform compilation testing but did not run it in real execution. Thanks, Jia-Ju Bai