From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D9F725B0B5 for ; Thu, 21 May 2026 08:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353412; cv=none; b=SiTvmYnsbkd9PDBXq+yICVAJK34DhjJ3ZF01y7oCdVBNly+GdwLOyOSLlr/8BGwOE40gXygilncRsy38mQEHzltkud2kcm5OY2jsmdNOYPOkAZXnRFl9X5BhShDhdKJ5ydGF6xWmFweJFe6DVSZ0OhOOg8Cb5EhBhUHoYRtmgqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353412; c=relaxed/simple; bh=MhXGOMEd2ldhJe/G+pIUhlGCzdCvGYuxSKbJNXUFwXc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fH2fr14PhBc96PTfw59TFpwzOsTgFdJOubt4N3QxizevYJWCIzbN2E8E9xxFLdw57NQuWuInAz5odOnbwzqJ4FLMkL6Eusy05mevkpbiCxHHWSIcpOE7BTXoYaMf4uty1wuM0nJ2WXo0BbsF8+5A0TmNRctLOOzu0+cq8y2wYG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=KRb/njuA; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="KRb/njuA" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30B541BF7; Thu, 21 May 2026 01:50:03 -0700 (PDT) Received: from [10.57.91.212] (unknown [10.57.91.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 646F43F7B4; Thu, 21 May 2026 01:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1779353408; bh=MhXGOMEd2ldhJe/G+pIUhlGCzdCvGYuxSKbJNXUFwXc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KRb/njuApSQvSrZXK69MxzbGVc+jTfDi1eLbtHMzb0Bzm96Zr5kSL+qO7AKIrUAqU c9mByq/mzLEvf3pqVXjeDZ8b4WmkeMNNBumUECFH2081l5PACk4vRK6GilZCgx2XzZ QZTfkmo4Y4f6HQ2vn6b62Bs3Cb6alv21CCqc1t7U= Message-ID: Date: Thu, 21 May 2026 09:50:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] arm64: mmu: use range based TLB flushing when hot unplugging memory Content-Language: en-GB To: Alistair Popple , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, catalin.marinas@arm.com, will@kernel.org, david@kernel.org, anshuman.khandual@arm.com, dev.jain@arm.com, balbirs@nvidia.com, jhubbard@nvidia.com References: <20260521042426.2128731-1-apopple@nvidia.com> From: Ryan Roberts In-Reply-To: <20260521042426.2128731-1-apopple@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/05/2026 05:24, Alistair Popple wrote: > Hot unplugging memory on ARM64 requires a TLB invalidate after unmapping > the page to be hot unplugged from the direct map. Currently that happens > one page at a time, meaning range based invalidates cannot be used. The > result of this is that removing large amounts of memory takes a long > time and in some cases can trigger an RCU stall warning. > > For example on one system hot unplugging 480GB of memory takes ~1 > minute. With this change the same operation took ~1 second, a 60x > improvement. > > Signed-off-by: Alistair Popple > > --- > > This is an RFC, because I'm not sure the change is correct as it frees > the PTE page before flushing the TLB. I'm not familiar enough with ARM64 > architecture to be sure this is safe, for example I don't know if HW > can update PTE bits such as access/dirty in the page through a stale > TLB entry. > > If so this would open a window during which the page is free but could > still be written to. Likely the safe option would be to collect all the > pages to be free on a list and free them after doing the range based TLB > flush, but wanted to get feedback on the approach before implementing it > which is the goal of this RFC. Hi Alistair, This patch doesn't apply on v7.1-rc4 because it conflicts with this patch: Commit 48478b9f79137 ("arm64/mm: Enable batched TLB flush in unmap_hotplug_range()") which has a very similar performance improvement, so hopefully it solves your problem? There are two paths which use this logic; unmapping the linear map and unmapping the corresponding vmemmap. In the latter case, the memory is also freed, so we can't safely do the range optimizaiton there since the TLB needs to be flushed before freeing the memory. But the linear map is the big, slow bit so hopefully it's sufficent for you? Thanks, Ryan > --- > arch/arm64/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 0c24fe650e95..75c773232c14 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1459,11 +1459,12 @@ static void unmap_hotplug_pte_range(pmd_t *pmdp, unsigned long addr, > > WARN_ON(!pte_present(pte)); > __pte_clear(&init_mm, addr, ptep); > - flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > if (free_mapped) > free_hotplug_page_range(pte_page(pte), > PAGE_SIZE, altmap); > } while (addr += PAGE_SIZE, addr < end); > + > + flush_tlb_kernel_range(addr, end); > } > > static void unmap_hotplug_pmd_range(pud_t *pudp, unsigned long addr,