From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00BAD3E0259 for ; Mon, 25 May 2026 08:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698305; cv=none; b=YOKEB3A7JmNbSpmyS5lAmKvPBgoWb91umnCyAzFJm9lyyLRA66qt2XLvKTHqPwDe2n8a6PIpMDuVSl9BywQdd+uNQEXNnFaykK07R9t6R5YzFjsCFVoPJwqG+4EixciyfHGgEwaHZkgZ8MVhlggzJganm8H6BJrLgO3LWrwGHH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698305; c=relaxed/simple; bh=zJQBetLlZQ18OzY2crIZnQnIs57BpmnoWtHP8L5o7nE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HZXw+keYZfW9XIo4hsbArv8Pxz+sI4gtUKaz53PX+rW03/bsHnbVFx1QNZqIZuql3p+/VT97o364dlMUrMIx6yk+NVkTt6KqVJ9PwM3j9L9nCUv464AM2EPE9+IFgvTLApFfO7YDLQ5W3cdEpLqHEEtBvYOLISlqbiqjXt6yBtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Sahq8Ryn; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Sahq8Ryn" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4891cd5927dso9048115e9.0 for ; Mon, 25 May 2026 01:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779698302; x=1780303102; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A2BfGMNpnuMvRedYniqJxkS9nB2bZeh7imXHczGNU4Q=; b=Sahq8RynBVMnrUdzCYUC9OTDiYkjJGyv4lufrHNGyp96egwK4Ztx6MDkdXWjZOfmFl 4IeplDXT/hzlr10jcakctrxBr2eLEfdPwu61/fYTm/Qo1rgpAiDgrn04Oa3mndm6C74s /kQebGEOJWVGYARquTkrXwbKOC62YmVZyKIpv4dSBHQk8rglTmINhUJlvSoP+jzNvik4 TY0rDy3J/dLZzhwSX+3t90rxNQlal2vv1TcRymTg9zgk7DxOz1lYq2xS0/A7XMcXc5eJ vBEuii2JI66gsqvjqw2aSRQ1kOttlZwYmpjaI1OGDjWF4ZgKgDwPPS+g6bDyEhmD74eS R2cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779698302; x=1780303102; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A2BfGMNpnuMvRedYniqJxkS9nB2bZeh7imXHczGNU4Q=; b=TORjFqHtt9rModXqveR3m7124rbyGQ0DpVbD0aGTtyVe73kL3VM0XAq3GnW6bMzN9M nrAp6qfmp9AgVWujtqsqU17HExS827EkvHlVcjCEAhSnRVVXI1jCtqdzpIeRC5YHZj+O S2gkE3rZsuxOBsD8jDMbQ4yJS0z9A1Tid+/4GF5/6ly7DSGs9XM1FD+kvr5TJ1R7u8Mi 98r1428uXlUkYG9vG+dNMY/u632yGQFVQQy9lgnyQr9TU8byyho/WDEuEJ8NTOgk0gMR 4CXxqtYPEbI9QW+n4s52nW+pX1GOaXYHWyKUMYW6am6m0TUghb7q+HMXeVCI3H9jOa08 QEhQ== X-Forwarded-Encrypted: i=1; AFNElJ8raCtEWLRYddnSw7vGGR3j1xNvUh5LhCZr3y6jcIXwBoOYOBsgRD5xTKL4C4zfXY9LbrgdmbWWXV64Sy8=@vger.kernel.org X-Gm-Message-State: AOJu0YykHdzpQkhzL9ODCe/4Sqe1m/bTvc+4n6lPj28a+djrd3yO1iT7 UolcvD+F3LF/2MLxIjdjiw5sAbr08BE4uZskwwQPu6RSFgtMw9Syarml71tLwO4y9wI= X-Gm-Gg: Acq92OGCJjdMkHzpdUYvTDoax1dxV/CEmhb2qo43xFfqGyGmWOBY+2XjrYJr82eeN6L F676gINuExkD2OsQr1yfD3zfiVEgDhbJljIZHe9X95piIrbOeNSsNWGFaSiTsz3XGdfipJWlDwB YZryJoMfflP1ffxpGOWt/+1mZqtqvsSq+47vF8bR+1PaxYO3Xv9pREC2WDLdeMfdTW/4M8Pl89o c2xYqHNb8fUsp0ley298b1+poqh/APkXJfVkrcVmP14yRkBLy7YOkDIq9GfGMMgVjBAGQ9o8PY2 dN1SFgK2mPR1llo1oDRHr4t9D4ty2JoZ6glsaKh+7gftFyYobdHJEoxyDnGxaXOF7x2hPB6dduC hpg97rI9ctn6kWji0N7ffaLsfHYnff6Oo2TdhC11VLbmarFQjre+lZWw5sJ2XkXTR84H0kM1PMK B/reZc5CcfzUPpVr6jVuaamuFVtluw8p1smB3Zms174NrcteUbFxmAG/HcFQ== X-Received: by 2002:a05:600c:35cf:b0:488:7e7b:dbc2 with SMTP id 5b1f17b1804b1-490426bb7f1mr124097125e9.3.1779698302250; Mon, 25 May 2026 01:38:22 -0700 (PDT) Received: from ?IPV6:2001:1a48:8:903:1ed6:4f73:ce38:f9d4? ([2001:1a48:8:903:1ed6:4f73:ce38:f9d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490454a0cd5sm290509295e9.10.2026.05.25.01.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 01:38:21 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 10:38:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Cleanup and fix tools/mm/slabinfo utility Content-Language: en-US To: Xuewen Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Harry Yoo , Hao Li References: <20260518062159.80664-1-wangxuewen@kylinos.cn> From: Vlastimil Babka In-Reply-To: <20260518062159.80664-1-wangxuewen@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/18/26 08:21, Xuewen Wang wrote: > This series fixes one bug and cleans up two code quality issues in tools/mm/slabinfo: > > 1. Fix trace disable logic inversion: when the user intends to disable > tracing (!tracing) and it is currently enabled (s->trace), > set_obj() was called with 1 instead of 0, which is opposite to > the intended behavior. All other options (sanity_checks, red_zone, > poison, store_user) in the same function use 0 for the disable > case. > > 2. Remove dead assignment in get_obj_and_str(): `x = NULL` sets the > local parameter variable instead of `*x`, which is a no-op since > `*x` was already set to NULL on the line above. > > 3. Remove redundant slab->partial assignment in read_slab_dir(): > slab->partial is assigned by get_obj("partial") and then > immediately overwritten by get_obj_and_str("partial", &t). > > Xuewen Wang (3): > tools/mm/slabinfo: Fix trace disable logic inversion > tools/mm/slabinfo: remove dead assignment in get_obj_and_str() > tools/mm/slabinfo: remove redundant slab->partial assignment > > tools/mm/slabinfo.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Thanks, applied to slab/for-next > > --- > Changes in v2: > - Fix author email mismatch > - Add Fixes tag for the bug fix (patch 1) > - Remove unnecessary braces in patch 2 per reviewer suggestion > > Patches 1/3 and 3/3 carry Reviewed-by tag from SeongJae Park. > > v1: > https://lore.kernel.org/all/20260515065325.4009527-1-18810879172@163.com/ >