From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25425C77B73 for ; Sun, 30 Apr 2023 07:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjD3HRM (ORCPT ); Sun, 30 Apr 2023 03:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjD3HRJ (ORCPT ); Sun, 30 Apr 2023 03:17:09 -0400 Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F0E110DC; Sun, 30 Apr 2023 00:17:07 -0700 (PDT) Message-ID: Date: Sun, 30 Apr 2023 09:17:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Matthias Schwarzott Subject: Re: [PATCH] media: ov5693: Simplify an error message To: Christophe JAILLET , Daniel Scally , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org References: <928f2f70de241d0fa66801b46d736ad0f881eb72.1681576102.git.christophe.jaillet@wanadoo.fr> Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 21.04.23 um 17:50 schrieb Christophe JAILLET: > Le 21/04/2023 à 09:38, Matthias Schwarzott a écrit : >> Am 15.04.23 um 18:28 schrieb Christophe JAILLET: >>> dev_err_probe() already display the error code. There is no need to >>> duplicate it explicitly in the error message. >>> >>> Signed-off-by: Christophe JAILLET >>> --- >>>   drivers/media/i2c/ov5693.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c >>> index e3c3bed69ad6..d23786afd754 100644 >>> --- a/drivers/media/i2c/ov5693.c >>> +++ b/drivers/media/i2c/ov5693.c >>> @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device >>> *ov5693, u32 addr, u32 *value) >>>       ret = i2c_transfer(client->adapter, msg, 2); >>>       if (ret < 0) >> >> i2c_transfer returns the number of transmitted messages. So I think >> the values 0 <= ret < 2 also need to be handled. > > Ok, agreed. > > If ok for you, I'll send a follow-up patch when/if this one is applied, > because what you spotted is unrelated to the dev_err_probe() behavior. > Sure, fine for me. > CJ >> >>>           return dev_err_probe(&client->dev, ret, >>> -                     "Failed to read register 0x%04x: %d\n", >>> -                     addr & OV5693_REG_ADDR_MASK, ret); >>> +                     "Failed to read register 0x%04x\n", >>> +                     addr & OV5693_REG_ADDR_MASK); >>>       *value = 0; >>>       for (i = 0; i < len; ++i) { >> >> >