From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B2A1C5F10 for ; Mon, 20 Oct 2025 05:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760939968; cv=none; b=NxO6ccnr2OtwDJJYm7vLR0P9O049DyZN+4piKS+WX287/WELfBmh4S+mCZx0xYj4n9UYByrwjEmhch55TkWxFOpYDjjbCZpwY0/ieVwuiakdwyc8B+xLhw7vtsdHnk7ikvTqN17U5p48tGKD9I8d+UT+yLJHVpBAikwSpg5MnDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760939968; c=relaxed/simple; bh=DfgQhDV2FB+r3jXdeQjlELojhkZCzkVAxCp7ukCYBp4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ae7xSSpgbWnzWT7fv8HQpJ+qoTd9p1mDFUCvEPYfDD/DGWBCIhlVrkxKgFcKJ/ExTvV0d3GJHf5MSZc/faISD+KbnLZUikE/Oy/+SVRdVMgJtHqrhzmQdpKnGp8Zyyk1VJJG998cCv50COHAtcka9Z0bUXzTtuDAlyj2k4fCnjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AwvQAiHN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AwvQAiHN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59JKsnU0009765 for ; Mon, 20 Oct 2025 05:59:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nM+18YfZG3eJcSFCMfzYrqy29nlqANkrqIV1DISydfs=; b=AwvQAiHNZfptJ/sS i5WDMuP2gRVCoBZ68zEz05L2Ju3az2ItKHRmAT6DUhiNLKy8s8ozHmuBu8Kz9ULM eWNZgonQhV+lfmHKBPfDj5xeYC+GMPa0DpRsnba3F3U2YJQS2J6HRTvOb237+m72 xQNCGieEZs+l5Bx58+CB37AkYupNbQLU0pB1yJ0kF9GTWwWs6QFjNEIdk8fxxG8s PSeBCIDMqhmWo8KbJx7ayULn/eurVcduffgVD5Rz/MeseGjoQT+7BCLsBtGMefND M7EPR0uxZd/Lh94X7BLvG8Sgw205tdyhip21CZYDrW9OrIItFDnAod1MQ5q6UpYJ 8NvWHA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v42k3n77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 20 Oct 2025 05:59:26 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7811a602576so6267797b3a.0 for ; Sun, 19 Oct 2025 22:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760939965; x=1761544765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nM+18YfZG3eJcSFCMfzYrqy29nlqANkrqIV1DISydfs=; b=vnFZmySJTvcMPuWb73wpcDwypezQd10UNoIWAgk2OypU/yYjGFhFnC5vwKP391tRNf 7/UoKGYFP+4kYePiioaHC6L6vfz2ZafFIM+jduQGst0+MGN0RAdGbR/sBDFzLbBtn1P2 bCakqN9Zpi5IM/wGSPQCZ1PurXBc/MirqXvEgvB2zMDckyXhscEQwL/ckZAKcJHxPilu Hh4EhsRYxWXfEGK5bdBiKXCu8uIjRCQvD8Tl/dOOy+p+l9W20TzRiEu8YTRXWxYtSWRF Rc3UBRmLZkF8gBk8sVPKC/8Wk2KcWquZ6uqm42CzJudy/6+Pf9qfCg/CYU6otBffaUGu wcgg== X-Forwarded-Encrypted: i=1; AJvYcCVlZIhXn04QGxr52ftriyHV+gpoPY5Q1DX8Jgf4WkYrnhfGuSEr07QmHnMHfZKya4O2sT/b/gctdKBiqwk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx01zzhsctivP15IGR0DKlzq3Usl/cXVxEyKV/esrU+7Mmq6MLz 7H++Co9SBDmhGDLW7nRJ6qMS+BAJCHF+96Ev+yMCtt/G3AsvVajKjrBVibPmpjexBxU8dWwgnJJ 5YV8ToeNdteiSwYnT7fKyAnB98o1e1DIJVRZrxGTL0F3BVmpQNVK0oS8Xmt8Q+5UBelmMq78R+N g= X-Gm-Gg: ASbGnctzrY/qak+hvrv+zZ+IoyZqIUeyXk7828nOZXMVswM6D8MBcBg5wkVrGYKA+st oGjnqh3ukX3xEI+H4FzfitVJb4AEZxBqnr1BS4V99EUMYmjPzIJznODns3ng7X+oh68z3RiOPS0 2F/3BfftVW0auHfNO6R5/HzaOShq1YFwYunlnIWrSzhs8tXPJaZVHbKv+SjGV3dY207cZI2txjW jXsDZ4EWghjnml/l43NkhUuNMYkvjQU2tH51KJ5QS3a/+keXnsKYrHz3P4BUpBVUktyQt9Hxn5z BIGaE5XsX9bmNSm07tbcbjw3a8liOkFIA2gyTvqMXIbyi2+4C6hs328JT/sUkU4sUR8Almw5uPQ MPioKaLfwxmwFniPz5REpcRIH7qiIj8LpyMxXLX+tIIuQxlrRzZXDf2qfc4qD9C1Ql60wIQ== X-Received: by 2002:a05:6a00:21c4:b0:772:45ee:9b9e with SMTP id d2e1a72fcca58-7a220aa8c36mr12648432b3a.9.1760939965329; Sun, 19 Oct 2025 22:59:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOnIQKmKM4/wBe+q3U4Vl91ebk6gizKnC7NhQP4NZOp+sNVTSvIrGb+vHkb3XE0F6V5ZNQSg== X-Received: by 2002:a05:6a00:21c4:b0:772:45ee:9b9e with SMTP id d2e1a72fcca58-7a220aa8c36mr12648411b3a.9.1760939964922; Sun, 19 Oct 2025 22:59:24 -0700 (PDT) Received: from [10.133.33.90] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a22ff34ba6sm7240595b3a.18.2025.10.19.22.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Oct 2025 22:59:24 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:59:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080 To: Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-5-f5745ba2dff9@oss.qualcomm.com> Content-Language: en-US From: Hangxiang Ma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3YnavBWPZjykZ76IHxLAuWQVs96BWM3t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAzMSBTYWx0ZWRfX8khVzUkiUO2R 5bkgh4rM7z1gc2cBprNvrYIw984dJKg2w1i6/67cse5r9LMGG0j2OFVERRR/Mus3POzu4CR02t9 3sCtUiKDgjhuYqSkfdoqipf0Nl1ceOiQQIlOOl6ARjObV7MeCptz4FF/Nrq7mDbbwGCT+zhpVNY oVwzWzeCyhb+3R0smb/0jR+q9xc3TtVoElK8l5BVovqigKKnEnzTW5RjwQ7/vVzCW9exgz31W5/ /2UOSz91xGNu6WzFW23Jk1EXc+EsHFmIH8zmGjKytCtxq1yEovf8uiImwG6j5cgylhejhpX5OAO 298i3ZIwad9ZPvCV1ibtUT2YYbwb0bIYG7rntWNf4oNWlpPmnDR6HCuLBdNikc4LBTcWFyp4LYV 2njLORL7NimSEXn+nHjbfCTAqnpCXQ== X-Authority-Analysis: v=2.4 cv=QYNrf8bv c=1 sm=1 tr=0 ts=68f5cfbe cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=AXp2hmqOj5kKvFkYXygA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 3YnavBWPZjykZ76IHxLAuWQVs96BWM3t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_02,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180031 On 10/16/2025 5:12 PM, Bryan O'Donoghue wrote: > On 15/10/2025 03:56, Hangxiang Ma wrote: >> +    for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) >> +        if (csid->phy.en_vc & BIT(i)) { >> +            val = readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i)); >> +            writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i)); >> + >> +            if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + >> i)) { >> +                /* >> +                 * buf done and RUP IRQ have been moved to CSID from >> VFE. >> +                 * Once CSID received buf done, need notify VFE of this >> +                 * event and trigger VFE to handle buf done process. >> +                 */ >> +                camss_buf_done(csid->camss, csid->id, i); >> +            } >> +        } >> + > A multi-liner like this should be > > for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) { >     /* etc */ > } > > in fact csid_reset_1080() does the right thing, please replicate. > Ack. Thanks. --- Hangxiang