mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shaohua Li <shli@fb.com>
To: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <Kernel-team@fb.com>, <viro@zeniv.linux.org.uk>
Subject: [RFC] put more pressure on proc/sysfs slab shrink
Date: Fri, 21 Oct 2016 13:35:14 -0700	[thread overview]
Message-ID: <bca13f1ae6a72f0d126cd7e9ede11baaa2b81064.1477081587.git.shli@fb.com> (raw)

In our systems, proc/sysfs inode/dentry cache use more than 1G memory
even memory pressure is high sometimes. Since proc/sysfs is in-memory
filesystem, rebuilding the cache is fast. There is no point proc/sysfs
and disk fs have equal pressure for slab shrink.

One idea is directly discarding proc/sysfs inode/dentry cache rightly
after the proc/sysfs file is closed. But the discarding will make
proc/sysfs file open slower next time, which is 20x slower in my test if
multiple applications are accessing proc files. This patch doesn't go
that far. Instead, just put more pressure to shrink proc/sysfs slabs.

Signed-off-by: Shaohua Li <shli@fb.com>
---
 fs/kernfs/mount.c | 2 ++
 fs/proc/inode.c   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index d5b149a..5b4e747 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
@@ -161,6 +161,8 @@ static int kernfs_fill_super(struct super_block *sb, unsigned long magic)
 	sb->s_xattr = kernfs_xattr_handlers;
 	sb->s_time_gran = 1;
 
+	sb->s_shrink.seeks = 1;
+	sb->s_shrink.batch = 0;
 	/* get root inode, initialize and unlock it */
 	mutex_lock(&kernfs_mutex);
 	inode = kernfs_get_inode(sb, info->root->kn);
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index e69ebe6..afef9fb 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -474,6 +474,8 @@ int proc_fill_super(struct super_block *s, void *data, int silent)
 	s->s_op = &proc_sops;
 	s->s_time_gran = 1;
 
+	s->s_shrink.seeks = 1;
+	s->s_shrink.batch = 0;
 	/*
 	 * procfs isn't actually a stacking filesystem; however, there is
 	 * too much magic going on inside it to permit stacking things on
-- 
2.9.3

             reply	other threads:[~2016-10-21 20:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 20:35 Shaohua Li [this message]
2016-10-21 23:00 ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bca13f1ae6a72f0d126cd7e9ede11baaa2b81064.1477081587.git.shli@fb.com \
    --to=shli@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®