From: Luiz Capitulino <luizcap@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
david@kernel.org, baolin.wang@linux.alibaba.com, ziy@nvidia.com,
lance.yang@linux.dev
Cc: corbet@lwn.net, tsbogend@alpha.franken.de, maddy@linux.ibm.com,
mpe@ellerman.id.au, agordeev@linux.ibm.com,
gerald.schaefer@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, x86@kernel.org, tglx@kernel.org,
mingo@redhat.com, bp@alien8.de, ira.weiny@intel.com,
hughd@google.com, dave.hansen@linux.intel.com, djbw@kernel.org,
vishal.l.verma@intel.com, dave.jiang@intel.com,
akpm@linux-foundation.org, yintirui@huawei.com, ljs@kernel.org,
dev.jain@arm.com
Subject: [PATCH v6 07/14] mm: shmem: allow THP support determination at folio allocation time
Date: Thu, 23 Jul 2026 21:34:11 -0400 [thread overview]
Message-ID: <bca5ef881f13ed8cdb65d4fff7527d757b6489fc.1784856856.git.luizcap@redhat.com> (raw)
In-Reply-To: <cover.1784856856.git.luizcap@redhat.com>
In order to enable THP support in shmem today, besides the user
configuration required, the CPU must support PMD-sized pages. This
is the case because of the following has_transparent_hugepage()
usage:
- shmem_parse_one() and shmem_parse_huge(): Check if THP is built-in and
if the CPU supports PMD-sized pages
- shmem_init(): Since the CONFIG_TRANSPARENT_HUGEPAGE guard is outside
the code block calling has_transparent_hugepage(), the
has_transparent_hugepage() call is exclusively checking if the CPU
supports PMD-sized pages
While it's necessary to check if CONFIG_TRANSPARENT_HUGEPAGE is enabled
in all cases, shmem can determine THP size support at folio allocation
time. Therefore, drop the has_transparent_hugepage() usage listed above
while keeping the CONFIG_TRANSPARENT_HUGEPAGE checks.
Additionally, we need to check if PMD size order is supported in
shmem_getattr(). Use pgtable_has_pmd_leaves() for that.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
mm/shmem.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 19534e21b61f..68ae606b5c4c 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -689,7 +689,7 @@ static int shmem_parse_huge(const char *str)
else
return -EINVAL;
- if (!has_transparent_hugepage() &&
+ if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
huge != SHMEM_HUGE_NEVER && huge != SHMEM_HUGE_DENY)
return -EINVAL;
@@ -1305,6 +1305,8 @@ static int shmem_getattr(struct mnt_idmap *idmap,
generic_fillattr(idmap, request_mask, inode, stat);
orders = shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0);
+ if (!pgtable_has_pmd_leaves())
+ orders &= ~BIT(PMD_ORDER);
if (orders)
stat->blksize = PAGE_SIZE << highest_order(orders);
@@ -4589,8 +4591,7 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param)
case Opt_huge:
ctx->huge = result.uint_32;
if (ctx->huge != SHMEM_HUGE_NEVER &&
- !(IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
- has_transparent_hugepage()))
+ !IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE))
goto unsupported_parameter;
ctx->seen |= SHMEM_SEEN_HUGE;
break;
@@ -5385,7 +5386,7 @@ void __init shmem_init(void)
#endif
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
- if (has_transparent_hugepage() && shmem_huge > SHMEM_HUGE_DENY)
+ if (shmem_huge > SHMEM_HUGE_DENY)
SHMEM_SB(shm_mnt->mnt_sb)->huge = shmem_huge;
else
shmem_huge = SHMEM_HUGE_NEVER; /* just in case it was patched */
--
2.55.0
next prev parent reply other threads:[~2026-07-24 1:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 1:34 [PATCH v6 00/14] mm: thp: always enable mTHP support Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 01/14] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 02/14] mm: shmem: shmem_getattr(): set blksize to highest supported THP order Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 03/14] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 04/14] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 05/14] drivers: nvdimm: " Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 06/14] mm: debug_vm_pgtable: " Luiz Capitulino
2026-07-24 1:34 ` Luiz Capitulino [this message]
2026-07-24 1:34 ` [PATCH v6 08/14] s390: move has_transparent_hugepage() out of THP guard Luiz Capitulino
2026-07-27 15:41 ` Alexander Gordeev
2026-07-27 17:06 ` Luiz Capitulino
2026-07-27 17:14 ` David Hildenbrand (Arm)
2026-07-27 17:25 ` Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 09/14] powerpc: " Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 10/14] mips: " Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 11/14] x86: " Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 12/14] treewide: introduce arch_has_pmd_leaves() Luiz Capitulino
2026-07-24 18:55 ` Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 13/14] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2026-07-24 1:34 ` [PATCH v6 14/14] mm: thp: always enable mTHP support Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca5ef881f13ed8cdb65d4fff7527d757b6489fc.1784856856.git.luizcap@redhat.com \
--to=luizcap@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=djbw@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hughd@google.com \
--cc=ira.weiny@intel.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=yintirui@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®