From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668A4C433EF for ; Tue, 31 May 2022 09:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245044AbiEaJBz (ORCPT ); Tue, 31 May 2022 05:01:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245041AbiEaJBu (ORCPT ); Tue, 31 May 2022 05:01:50 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B53B61D0C7 for ; Tue, 31 May 2022 02:01:47 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id x17so8665723wrg.6 for ; Tue, 31 May 2022 02:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ivvYO1sUstCciiWZkswLsyBmaMq3bC7gj08oOv0TolI=; b=0O91Vxj1nMXvo9qMNyldMMQ1Ib34fxg70N9h08o/c7hadC8XvZJvsddzYl+C67weBv VO+un8Uzc1BCHF+0uIkJ0p/vnx1PDoE35JEVAmCn/BzMq8+nVXiJD3Jbctbbbfc0Q44c zKaNoy9cOyjGWnksSd8UD4J1mXeYfOpHE/n0r0DoJynLRM5qKJ/66I1rzGZfkZezSgZT ReWtlOaMGKnwAobrfOvjBEZ7NuJ7ohgmvRCcUiy4RmEocdtNqTo2Q5Wa1C941SEn2sqk he7/AKxDo7dNKbX9JhbzfT+EPeIiVb9Sz43yoJqjYaB2Y/QRBmwxcGMJrbUbACQM+v7l sOfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ivvYO1sUstCciiWZkswLsyBmaMq3bC7gj08oOv0TolI=; b=ZxO6EiPaze+2I4JMcGz7hg9HEdY0MhS//APNi5/gpZp3kLreUIHlabBuih+Pxb0E6l VqlTDWLIijYjRMsOA+9EuIfQJfhQNULy/OFqTu3Nrx9MuFrb29LejbWwObZi7X8zoMNa 9Se7ITRBiqWhnfZL7OW+3jNkCvc51ObgtC7u+U1mypus7Iax91ZU5rRL7P/7WYTQCPw+ T1sQhN1IaM+vwQZmAemVKGStUGHLJAZ4EHM61/KaaV270CCdGKmC4pbL1qkpGaRHT3aI mel42aUPJDJo5fUZT1ZfJ8MSR+BCQMfWZoAWw63tHMwBOj88EyfqlPfwDs3IZEIaUdTp g36g== X-Gm-Message-State: AOAM532L74KuRbCIXvDnZexqvWa1GYt3XCm4p5KE1TYuDQ68wvhOCZ0v qggDD1ERTADQ/CW54VfMVqX2HQ== X-Google-Smtp-Source: ABdhPJwaqyC8uFjcpmNY+2eZkiV29AUkxDcUS4UUo7hRE0u0owQNPd+bQWfr8K7AarJMrn6kVm8l0Q== X-Received: by 2002:a5d:4344:0:b0:20c:9156:8ec with SMTP id u4-20020a5d4344000000b0020c915608ecmr50065204wrr.71.1653987706038; Tue, 31 May 2022 02:01:46 -0700 (PDT) Received: from [10.188.163.71] (cust-east-parth2-46-193-73-98.wb.wifirst.net. [46.193.73.98]) by smtp.gmail.com with ESMTPSA id o20-20020a05600c379400b0039c18d3fe27sm1533956wmr.19.2022.05.31.02.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 02:01:45 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 03:01:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [syzbot] UBSAN: array-index-out-of-bounds in io_submit_sqes Content-Language: en-US To: Hao Xu , syzbot , asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000f0b26205e04a183b@google.com> <3d3c6b5f-84cd-cb25-812e-dac77e02ddbf@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/22 3:00 AM, Hao Xu wrote: > On 5/31/22 16:45, Jens Axboe wrote: >> On 5/31/22 1:55 AM, syzbot wrote: >>> Hello, >>> >>> syzbot found the following issue on: >>> >>> HEAD commit: 3b46e4e44180 Add linux-next specific files for 20220531 >>> git tree: linux-next >>> console output: https://syzkaller.appspot.com/x/log.txt?x=16e151f5f00000 >>> kernel config: https://syzkaller.appspot.com/x/.config?x=ccb8d66fc9489ef >>> dashboard link: https://syzkaller.appspot.com/bug?extid=b6c9b65b6753d333d833 >>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >>> >>> Unfortunately, I don't have any reproducer for this issue yet. >>> >>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>> Reported-by: syzbot+b6c9b65b6753d333d833@syzkaller.appspotmail.com >>> >>> ================================================================================ >>> ================================================================================ >>> UBSAN: array-index-out-of-bounds in fs/io_uring.c:8860:19 >>> index 75 is out of range for type 'io_op_def [47]' >> >> 'def' is just set here, it's not actually used after 'opcode' has been >> verified. >> > > Maybe we can move it to be below the opcode check to comfort UBSAN. Yeah that's what I did, just rebased it to get rid of it: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.19&id=fcde59feb1affb6d56aecadc3868df4631480da5 -- Jens Axboe