From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB12C4724C for ; Mon, 4 May 2020 17:14:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32C6E2073E for ; Mon, 4 May 2020 17:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730172AbgEDROv (ORCPT ); Mon, 4 May 2020 13:14:51 -0400 Received: from foss.arm.com ([217.140.110.172]:49736 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730571AbgEDROn (ORCPT ); Mon, 4 May 2020 13:14:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34D0D1045; Mon, 4 May 2020 10:14:43 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A5753F68F; Mon, 4 May 2020 10:14:42 -0700 (PDT) Subject: Re: [PATCH] firmware: arm_sdei: Drop check for /firmware/ node and always register driver To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "will@kernel.org" , Catalin Marinas References: <20200422122823.1390-1-sudeep.holla@arm.com> From: James Morse Message-ID: Date: Mon, 4 May 2020 18:14:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200422122823.1390-1-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, (CC: +Will and +Catalin) On 22/04/2020 13:28, Sudeep Holla wrote: > As with most of the drivers, let us register this driver unconditionally > by dropping the checks for presence of firmware nodes(DT) or entries(ACPI). > > Further, as mentioned in the commit acafce48b07b ("firmware: arm_sdei: > Fix DT platform device creation"), the core takes care of creation of > platform device when the appropriate device node is found and probe > is called accordingly. > > Let us check only for the presence of ACPI firmware entry before creating > the platform device and flag warning if we fail. Reviewed-by: James Morse Will/Catalin, any chance you could pick this up for v5.8? Original message: https://lore.kernel.org/linux-arm-kernel/20200422122823.1390-1-sudeep.holla@arm.com/ Thanks! James