From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53908C00140 for ; Wed, 24 Aug 2022 17:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238730AbiHXROS (ORCPT ); Wed, 24 Aug 2022 13:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239940AbiHXROP (ORCPT ); Wed, 24 Aug 2022 13:14:15 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66AD07B799; Wed, 24 Aug 2022 10:14:14 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27OC4xEN020367; Wed, 24 Aug 2022 17:14:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=/1oeoHt41EynB8BHQokkhb1v7el98LAR1YxIKNlCPwU=; b=cTR/URJSAZXhzzVauu2vcLDUFjzeLMTvuw+KT1RZdUkREyMj+9yY26js4lm5/E2VvZnp wObjynhvHmQW5g+ClpYILwvY3WfcCuAYMdxRyCQgq3nQIKKq2K6P1UQ7cJ/TqAJIN2lA 7v1/CKZJI0XKEzpsN3ItpCiBeXoA9C6WMIc1at0ktdzFJGN4COxkbL3SaT9PaSUTVPp2 24KypCZb8FZGLsLUUFEpfDyBn/OwPGbbePKn9H5Fgi1U5iemG/oZ1q9OgsRDKliPElpq rLwuL83YGEpsJc4Q3cVlm1l1fnRbZhm3k9DdzaaC1M9P93CbSZ8gs5qNg5FNlFg3Z7VF kg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j52pj426u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 17:14:06 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27OHE5w9027749 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 17:14:05 GMT Received: from [10.111.161.24] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 24 Aug 2022 10:14:01 -0700 Message-ID: Date: Wed, 24 Aug 2022 10:13:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa() Content-Language: en-US To: Kuogee Hsieh , , , , , , , , , , CC: , , , , References: <1661360356-21948-1-git-send-email-quic_khsieh@quicinc.com> From: Abhinav Kumar In-Reply-To: <1661360356-21948-1-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Be4xJA0nqawVM2Cn8c6dTYcV5rF8rM2S X-Proofpoint-ORIG-GUID: Be4xJA0nqawVM2Cn8c6dTYcV5rF8rM2S X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-24_10,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208240064 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/2022 9:59 AM, Kuogee Hsieh wrote: > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. > > Fixes: 937f941ca06f "drm/msm/dp: Use qmp phy for DP PLL and PHY" > Signed-off-by: Kuogee Hsieh Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 7257515..676279d 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -431,7 +431,7 @@ void dp_catalog_ctrl_config_msa(struct dp_catalog *dp_catalog, > > if (rate == link_rate_hbr3) > pixel_div = 6; > - else if (rate == 1620000 || rate == 270000) > + else if (rate == 162000 || rate == 270000) > pixel_div = 2; > else if (rate == link_rate_hbr2) > pixel_div = 4;