From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754575AbdEMQfS (ORCPT ); Sat, 13 May 2017 12:35:18 -0400 Received: from mout.web.de ([212.227.15.14]:63765 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdEMQfR (ORCPT ); Sat, 13 May 2017 12:35:17 -0400 Subject: [PATCH 2/2] oprofile_perf: Delete error messages for a failed memory allocation in oprofile_perf_init() From: SF Markus Elfring To: oprofile-list@lists.sf.net, Robert Richter Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <8e408a15-7884-e9a1-0df2-a7419987c450@users.sourceforge.net> Message-ID: Date: Sat, 13 May 2017 18:35:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <8e408a15-7884-e9a1-0df2-a7419987c450@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Bp5+/QokKBc3hR+QFQrlEeXxkgejpDN0Wc34eGaAT2slR8lHYcU PXOWEcROV0DK5pzGq4Nf4i6VCSIwE50hzsbIkxoPqmnQDcuUg1TMgEeD0ko0luiAsuyCBxV OuXRiULv+hTeZuhxCEhMzJFAGhh1b27fW6RvnH6a7SKlphBt2g5hqswjQ1o4zfxGeQB+Yqi 7ACsYpVDV2WQaehhryrUg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ex/CmtYqEgY=:vZjUbVVUvejOTTPh6iFb+P OVEGoDoTGLTAeBLlIQtea6D4taoIHYmrK7/YXSyUkU6bNpafAvtCxB5vkKYaCukHL5xKJpHyi n83V4doLE6zzzl1H3fW3ljotH5cAO0VcIazxIBzx/VGpaak/GmNGnVmtlaDjschaazkmLTTRN Klg1/NB3HM4OMhvu2SW4o3jrpTgFB0sed1HMllyfzHQvMxpQ60Zl2kv7LsfTKZoWpVnc+v3wP c6u4sY/p6VPezfYmIY09LsmWA5DgSYfownMTIxdFkep8GfG51gYfOVHX/pVub0h0jWIK8GFUp FHPJ5AEkFaH6tKREvwdHqLd/pQI3swTgfevctV6Hmz1sToVq46WegO6aB3pv6bPhuFvVrtEEm L1PEv/Vc4GFlwcEoL/fY9WgZ6Ezn6myX2cqjI2XwU/lFH0fCRN1rLkeHwwuXBgR4G0KwR7jqM T76uNW71m8sRo43ZCzVIZS6nwNmOqDB3OJZDnWpF/ZljBviG3hVH68M8Alr9wVJKjE16isgLM +Q+U4YswLhMuj3ZuBE3LUyEpApDlWtsuA9oc+NZIdSdZCnOq91pbckdLm/PnNRE4QPcBFnED1 Z627SR2hPQotqKKFw6c/eV2IHRoriXG9MHH1UaqKA+6YEK9N2njYYnrtSZaluUaVjws/fYdMY /30axPbcfcQGtq2UlPdOKIUs+Vz0otxxQfeFKJaYDoqAS3YtWNt6meiQL/53qq8SThV/TjFCF xz1Rj/X/QnNIVDvk9OS1fT/ZCom5u3vZ9AeTcc3/ZYrO8BQEp9ZFu4wtrs4fr4iP22frFcxb+ Ux3jnoe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 13 May 2017 18:08:07 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/oprofile/oprofile_perf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c index 033f2c26f2ad..6de27b90b562 100644 --- a/drivers/oprofile/oprofile_perf.c +++ b/drivers/oprofile/oprofile_perf.c @@ -291,5 +291,3 @@ int __init oprofile_perf_init(struct oprofile_operations *ops) - pr_info("oprofile: failed to allocate %d " - "counters\n", num_counters); ret = -ENOMEM; num_counters = 0; goto out; @@ -299,8 +297,6 @@ int __init oprofile_perf_init(struct oprofile_operations *ops) per_cpu(perf_events, cpu) = kcalloc(num_counters, sizeof(struct perf_event *), GFP_KERNEL); if (!per_cpu(perf_events, cpu)) { - pr_info("oprofile: failed to allocate %d perf events " - "for cpu %d\n", num_counters, cpu); ret = -ENOMEM; goto out; } -- 2.12.3