From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0CD192B9D for ; Thu, 2 Jan 2025 09:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810875; cv=none; b=REFVPfm4VbTzQTV9jOUj8cgoPX9L9NI12eNlv0X3parPkxGL3XWwkeaiwXKhVhQd/wQocCSimh3QxEPX8qUd/Ugc2NaUVacKWGHn0LaWL9AXGe/Es66zt6Yxl9uUCSIzi4JIpNvWjJyb0HPYLB8LuDUft1nOnqQQSzXANSkawOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735810875; c=relaxed/simple; bh=E84mYEy002Ip6HQP1nYZMvYhBz4QYBLVEbxXn6WAToc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gkxlswUFzg3K4w4ZLHpIPHWb8MqzT3q8FYrqPg5LFfTyDxow/cDO7AoXuciw9xmVjXPJrSlIlQoD5lgOn8wbwLTldnVN+aZ722N8IoXrZQT4rJP5Ql8RDAHJ3Rid16+I1pHQwezvB8DEWBRgRBaWilhIaXNBUdkmKaLjjthN94A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=p6fFczUd; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p6fFczUd" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43626213fffso71106855e9.1 for ; Thu, 02 Jan 2025 01:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735810871; x=1736415671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/oXcMOvfrC7iN4ecLv5oPIeFCArh+m8oouCA5LcTcBU=; b=p6fFczUdrDhfFGnt4yOfbhY0EokckwDcvJ9/cgiKJsLW2gMguFgyUFzvm3SARsLMs+ FFNorDG8XKdaoVFzi/9EY4wAu8/MVwPFlEhQ9ljnOR/AL1AwS2PdVHCf+FxW3Gbk08Fx 5i+b5XdmiZoZWpssPxf/TlPlK1PnZX6ihd35ukRcbGQmqcYGBSDOzc6vd02+3I4wQApP a05hk3eSyIIkOEvHgBzmkKeGyhAGMUkNvAhBMQe3qyfTC8Pe+deectztFGTVN0GUvxY/ aTCGh6hmUoMY7CBj4cAFdabFxiOMTZC0z3mLx2ewH+6nlF0c0JnK5wQ0Tscj8iyouMgN y84w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735810871; x=1736415671; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/oXcMOvfrC7iN4ecLv5oPIeFCArh+m8oouCA5LcTcBU=; b=l04EgYflBeaJ3WAKXYxZ4QO6SW+QzwVC3PoIK7sTe8lrAfM4ZsBfYAWRWglEd9v3nu HGmJecbd6Z4XaAQVyCJvOdq8TrDn09biVOTY/LCXH8yUv6f9yAW/Ceq5r9RNz7Oq3Xa3 KPTdFv52Mnw1OABHDr073pntP0VSrVukhcUNJZQUin3RKx+9IAitqpu5Fle0CKe+LDXZ IsgaVvRqgnS8iy/VIvNhAD95aBmlhUjq8O38RXgLU0vwXfralqtby6Ppru4Ljd8KDlEj kXlekjU8us9LnERRdGplE218OuUK84L2INWdYzzrVqKL9SYOqib2jAOhjlQ6gNH/T5uk emRA== X-Forwarded-Encrypted: i=1; AJvYcCVRmVmxarcRwJQWAM2Z+hEAFmd8YsFmAI+vW7OW0R3afUtvtxIOHa6oP4/sJ8hrn9jDrpKV1gCL9Xz/6V8=@vger.kernel.org X-Gm-Message-State: AOJu0YzcoYbc3dLUeZL5z8eFB60E8JMvsA7KAui+iHnKNaf+bp/qFtK/ YZ8eDUVoD/3tFZvwWcyvLQzVLrOEuRJtJ8WGz7ypieaXq2i2Wm3oyWijyBaImgJ0pE9aXxVfpdQ I X-Gm-Gg: ASbGncvm/Oi2kgFSpEnLb5Y5a8Wgm1lt6MZw0C3Sqirj00EfCG6IuFH7FYW6JVYSPby qXnUYgOm7KEqYu3MgsP3kDnwUfqOB4aaXmPDDm8hFkWjFkoWqYTT/9mswsgSxtsMsUwLv4I0rd0 dz2AEySTs2pqNDBI30c4P45MZH/xzuHgvIgatv8ALGAXMRiv7GEUcV5nvE/dkCMjWj31G57IHEp TaT5pI/LBDwnnOKZGXnJe5CfdBcnA/rLa24GqvsIjhYly4UTB7xlF4cQQ9RmrY57kH/D7RaczyF xjC2yYh6Y5FtXf3fVrt0T3D95w9AhI71jA== X-Google-Smtp-Source: AGHT+IH2Mv5uQN7VnPzUaQDX5RIFOYe4WHF2+BXPsAV64FeA80rClpdW3DKWh12Szu1NO8Zkqlabxg== X-Received: by 2002:a05:600c:548a:b0:434:e69c:d338 with SMTP id 5b1f17b1804b1-436697f8bf8mr352226985e9.5.1735810871401; Thu, 02 Jan 2025 01:41:11 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be? ([2a01:e0a:982:cbb0:1cfa:329a:aa2e:f0be]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea42esm453596695e9.9.2025.01.02.01.41.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 01:41:10 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 10:41:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] phy: amlogic: meson8b-usb2: Use the regmap_{clear,set}_bits helpers To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org References: <20241231191718.2764065-1-martin.blumenstingl@googlemail.com> <20241231191718.2764065-3-martin.blumenstingl@googlemail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241231191718.2764065-3-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/12/2024 20:17, Martin Blumenstingl wrote: > These require less code, reduce the chance of typos and overall make the > intent clearer. No functional changes. > > Signed-off-by: Martin Blumenstingl > --- > drivers/phy/amlogic/phy-meson8b-usb2.c | 28 ++++++++++---------------- > 1 file changed, 11 insertions(+), 17 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c > index d9c761b7c15c..a553231a9f7c 100644 > --- a/drivers/phy/amlogic/phy-meson8b-usb2.c > +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c > @@ -165,8 +165,7 @@ static int phy_meson8b_usb2_power_on(struct phy *phy) > return ret; > } > > - regmap_update_bits(priv->regmap, REG_CONFIG, REG_CONFIG_CLK_32k_ALTSEL, > - REG_CONFIG_CLK_32k_ALTSEL); > + regmap_set_bits(priv->regmap, REG_CONFIG, REG_CONFIG_CLK_32k_ALTSEL); > > regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_REF_CLK_SEL_MASK, > FIELD_PREP(REG_CTRL_REF_CLK_SEL_MASK, 0x2)); > @@ -175,23 +174,20 @@ static int phy_meson8b_usb2_power_on(struct phy *phy) > FIELD_PREP(REG_CTRL_FSEL_MASK, 0x5)); > > /* reset the PHY */ > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, > - REG_CTRL_POWER_ON_RESET); > + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); > udelay(RESET_COMPLETE_TIME); > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, 0); > + regmap_clear_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); > udelay(RESET_COMPLETE_TIME); > > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_SOF_TOGGLE_OUT, > - REG_CTRL_SOF_TOGGLE_OUT); > + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_SOF_TOGGLE_OUT); > > if (priv->dr_mode == USB_DR_MODE_HOST) { > - regmap_update_bits(priv->regmap, REG_DBG_UART, > - REG_DBG_UART_SET_IDDQ, 0); > + regmap_clear_bits(priv->regmap, REG_DBG_UART, > + REG_DBG_UART_SET_IDDQ); > > if (priv->match->host_enable_aca) { > - regmap_update_bits(priv->regmap, REG_ADP_BC, > - REG_ADP_BC_ACA_ENABLE, > - REG_ADP_BC_ACA_ENABLE); > + regmap_set_bits(priv->regmap, REG_ADP_BC, > + REG_ADP_BC_ACA_ENABLE); > > udelay(ACA_ENABLE_COMPLETE_TIME); > > @@ -214,17 +210,15 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) > struct phy_meson8b_usb2_priv *priv = phy_get_drvdata(phy); > > if (priv->dr_mode == USB_DR_MODE_HOST) > - regmap_update_bits(priv->regmap, REG_DBG_UART, > - REG_DBG_UART_SET_IDDQ, > - REG_DBG_UART_SET_IDDQ); > + regmap_set_bits(priv->regmap, REG_DBG_UART, > + REG_DBG_UART_SET_IDDQ); > > clk_disable_unprepare(priv->clk_usb); > clk_disable_unprepare(priv->clk_usb_general); > reset_control_rearm(priv->reset); > > /* power off the PHY by putting it into reset mode */ > - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, > - REG_CTRL_POWER_ON_RESET); > + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); > > return 0; > } Reviewed-by: Neil Armstrong