mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Xiaofeng Cao <cxfcosmos@gmail.com>,
	mchehab@kernel.org, patrice.chotard@st.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Correct 'so'
Date: Wed, 10 Mar 2021 09:19:44 -0800	[thread overview]
Message-ID: <bcc2c2c9-5ad7-ba04-fe81-ca1728e81dc2@infradead.org> (raw)
In-Reply-To: <20210310145816.32271-1-cxfcosmos@gmail.com>

On 3/10/21 6:58 AM, Xiaofeng Cao wrote:
> In Kconfig it should be 'to'
> In c8sectpfe-core.c it should be 'do'
> 
> Signed-off-by: Xiaofeng Cao <cxfcosmos@gmail.com>

The Subject: could use some work, but the patch contents look good.
Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/media/Kconfig                                 | 2 +-
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 6222b3ae220b..b07812657cee 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
>  	  This is found on Embedded hardware (SoC), on V4L2 codecs and
>  	  on some GPU and newer CPU chipsets.
>  
> -	  Say Y when you want to be able so see such devices.
> +	  Say Y when you want to be able to see such devices.
>  
>  config MEDIA_TEST_SUPPORT
>  	bool
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index a7a6ea666740..338b205ae3a7 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
>  
>  	/*
>  	 * TODO FIXME we should detect some error conditions here
> -	 * and ideally so something about them!
> +	 * and ideally do something about them!
>  	 */
>  
>  	return IRQ_HANDLED;
> 


-- 
~Randy


      reply	other threads:[~2021-03-10 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 14:58 Xiaofeng Cao
2021-03-10 17:19 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcc2c2c9-5ad7-ba04-fe81-ca1728e81dc2@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=cxfcosmos@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=patrice.chotard@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®