From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9651D5CFB for ; Tue, 27 Jan 2026 02:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769480643; cv=none; b=avDvHSkJOOce4LXAqhGrNdaBqrdjtWBv72OKczGzlxyTmN3BUfYby8aTGOEvIOK0tmkWlLXFUvkAcAmUmDbUoURUSPL026bFNuiqCn6ibwZcNFkgqULnE9EwpclJKSJ4+SMi/98b38AKqOfbXxQh3F09QKGZMXo7y5pB2hmStGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769480643; c=relaxed/simple; bh=9f3NFht7zeSv9a6jBvvOUsB+j3Nq6SROc+zUKnDAZzk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PDHm22MGUjapRGFGEBT4VQz8uf+19JuwhCTq14J8J0HUDoaeCrIDCAnpjCwYBmRopzzOHqlyJtvDmW/BdLah4MyEnSdMECxOddY+TRlmCt1Uj/biNqfbc2IyFZ6DsJHtNS42GnzffGKKPwY8zetmnSmkfAUWBLakZSq64TBEWLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NMA3J8zb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EuNcNWnf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NMA3J8zb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EuNcNWnf" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60QKgVnT3384759 for ; Tue, 27 Jan 2026 02:24:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7Xcj+7J3rCgzN/qZYc9vEg73R8vlK8fAALq3lkw0cpQ=; b=NMA3J8zbHSUQq9rh HHGIg35QRr8DsMHoRKWv8S5XvoEntlCi4Y3iGb43si8HfY3GviwTR/a3a81zn1fA 37ux5qoOuxkSbWFpjZvosdhRsMiNkRYTqZvnrQptE//fzDLnXHJoGH4DENPhIRo7 YZwQCX3aeyiW6zXqnThlwWleQ0NG3T30Ub5RZWqeoRJqJ0/MluawtORGK7O5s0GX eBjj5KG9nBrK9oHYRRBcQgFr3+HSsZf1SN/JZraIxGzq7R/BiUuk3I9SH+PGMpKi 3kJtvRhPK0ckSt5F0JgA/dW5xfUH6L5e3Kc+utWU/s7QBuTaVlF+zO2xQruOgxgq JHJMlw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxf3a0u27-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 02:24:00 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f26fc6476so77621685ad.1 for ; Mon, 26 Jan 2026 18:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769480640; x=1770085440; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Xcj+7J3rCgzN/qZYc9vEg73R8vlK8fAALq3lkw0cpQ=; b=EuNcNWnf5g7NRGNXN7cg8WhRvBVs5O3BZnoTjxO55qA3Jbf794PeNxh5C/r5XeKpk+ XbyzfvnBTZ0djqTz4ZozNQIVP9DiI5fYwaTkhmusuc7S8DJb5q7crdVRDQVle0gQEF4K MIo/ag498CuQnwSorIQoKGzVJ0rCYgygTnBtEILdluKPkEb9HRf8Iv67fa4dYSPxLh4t s7CHFNTLU4gQwYOFyndxbhRDSE1Ps88lQqLTCzmC76QAqfzla8kLKM9ue7CysU2wPlUi eRa3XfsT4BAh2K6VQZ5QU2JS4+58weD2cTaYL/0Bm1/aoZBE9lv0U8ODN4RU/KNGb8ed Cjqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769480640; x=1770085440; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Xcj+7J3rCgzN/qZYc9vEg73R8vlK8fAALq3lkw0cpQ=; b=cWBoVlGQg8NTzoRgWBtg4ayo/BUQwT2Wiq/L4ayGa0GSzLd4PsrSrXgCnA1CYc4+8o rP8o7hcUAwioG/BE6A1XqBQI8lO62b4JcHfJPL0HhBcbWrACbHTyuMV29XZ6hDkid2tJ fh94UTE4AJd3asJy7f7yUOOGvFldLywPlTMvyAw05vqQgjMTSK2t3Pg68x1Nk7qlsHKa CUNMCnSg4QPLj05Kj2qRpphYdY09G5OMiygldnFXkGoLbO0CjpCycPK+TN0YYnyk++5T ApzjQ7LiAzE+tdxhGOe0EHPzlQSmq9tm7+fsoLjxnqoBQBT3ygMOK2jMo+SWTainwdXP xqKQ== X-Gm-Message-State: AOJu0Yx4kRx4Zf2bM/8i8+QTK9qOOXQRbSYUB51cvaOjUJzPqLNEENCq tCHO2pSP9vwa+OIAITwyY7GXjWqi/hPWa7CkwgSYBBJo/X2vDx5PawvucgWRFDkI9K+dx1OuDqa c3jaC/nt/KjuJM/d4zUduWYwUG0XVKbXVPvDk1LSrL5alaCNZNTWybofp1PrfxME9sIU= X-Gm-Gg: AZuq6aLE9zbpfboCN6FyOmG0ivYFPU9uA9oiYXs5yIwahLOe8jJbPjq4oyt0tlXjnoy n8AWIsLYOPIUIj7BpYwoeu15ni3cqwMO/NNhgvIxFr/ErL4DqF7y7AglwEND/7ZDbp5co4NFaSG 6fIlDKfuJs/9X3jSAfSnm6iQb2BTZ3357NCBbavQonyyNLhZUtT+mnA4I6RE3LShr3q4KxQuMyx 4JVaVhkW+j4PdMGCj7Kt8pKIzrozwyV7pZ7VM8keFhGMrAL281h1xOsIRE6doZwtGf1bvec15S2 wXsJyL6NjHsaaOkbV138r4DxdmWYRACd8eINcqa9IGXbcWcbAMk5RBJlkVnIE8tH3nUF0MFYfWu Inwrcgt6FzE881B6YbimThzzAQxNYCV3dG8SFPxQ= X-Received: by 2002:a17:903:2cf:b0:295:1e50:e7cb with SMTP id d9443c01a7336-2a870d7446cmr2559575ad.23.1769480639795; Mon, 26 Jan 2026 18:23:59 -0800 (PST) X-Received: by 2002:a17:903:2cf:b0:295:1e50:e7cb with SMTP id d9443c01a7336-2a870d7446cmr2559345ad.23.1769480639302; Mon, 26 Jan 2026 18:23:59 -0800 (PST) Received: from [10.239.133.242] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802dcd96bsm101009885ad.33.2026.01.26.18.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 18:23:58 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 10:23:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/7] qcom-tgu: Add signal priority support To: Konrad Dybcio , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-4-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDAxOCBTYWx0ZWRfX7c5iYURuwYtf M6WK0qWtoBCmpP8K+3tTnOvmVNu5Q12yRi6RKkRCQ547my9ThxGkBjspDEUz69S7fFfGix8GmOR lH2crS4+refJHI1U9PtKwWvDngDnVwc+ZOtanUzgYuKq2l1mwfP6pCww6Ya23T1dXD31nOEPs7n df/OVcdsvAFtx76xnuvy4Uecc0AGWpMPqWbYVMoJa5JG8IRKxF6Pb+UdUPoIxhjmF94HY5bkNH4 AyQ21XfMb8d1TVCcUmC9ZZvBdD+Qsshwxr+iDHkPHckncogVHr4Rro07pimHC2NtuKyiWmqtH1r nppEQg4mQjAXDL6d5C37uCF7gW+8NWeqg0aTzWqKZa1HbsU5Y7G2kVD7qUCYkTLtAjBynef8vu+ FwuPefibuAqLhEm9J8D+ZQwSBRVjqhWpoafb/289xq6ycGYEd4/1vLhufWUbWmysuVASJmv70Vc X9LXduU194yXs9BRKQA== X-Proofpoint-ORIG-GUID: EX7yq9xfURm8l3kEJ9d1sBqFDGd3gAKL X-Proofpoint-GUID: EX7yq9xfURm8l3kEJ9d1sBqFDGd3gAKL X-Authority-Analysis: v=2.4 cv=a6k9NESF c=1 sm=1 tr=0 ts=697821c0 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=IIc-LL1DTgqZpWAsoswA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_01,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270018 On 1/13/2026 7:09 PM, Konrad Dybcio wrote: > On 1/9/26 3:11 AM, Songwei Chai wrote: >> Like circuit of a Logic analyzer, in TGU, the requirement could be >> configured in each step and the trigger will be created once the >> requirements are met. Add priority functionality here to sort the >> signals into different priorities. The signal which is wanted could >> be configured in each step's priority node, the larger number means >> the higher priority and the signal with higher priority will be sensed >> more preferentially. >> >> Signed-off-by: Songwei Chai >> --- > > [...] > >> +static ssize_t tgu_dataset_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, size_t size) >> +{ >> + struct tgu_drvdata *tgu_drvdata = dev_get_drvdata(dev); >> + struct tgu_attribute *tgu_attr = >> + container_of(attr, struct tgu_attribute, attr); >> + unsigned long val; >> + int index; >> + >> + ret = kstrtoul(buf, 0, &val); >> + if (ret) >> + return ret; >> + >> + guard(spinlock)(&tgu_drvdata->lock); >> + index = calculate_array_location(tgu_drvdata, tgu_attr->step_index, >> + tgu_attr->operation_index, >> + tgu_attr->reg_num); >> + >> + tgu_drvdata->value_table->priority[index] = val; >> + return size; > > Style: some functions have a \n before return, some don't. The former > is preferred Sure, Konrad. I will update and pay more attention next time. > >> +static umode_t tgu_node_visible(struct kobject *kobject, >> + struct attribute *attr, >> + int n) >> +{ >> + struct device *dev = kobj_to_dev(kobject); >> + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); >> + struct device_attribute *dev_attr = >> + container_of(attr, struct device_attribute, attr); >> + struct tgu_attribute *tgu_attr = >> + container_of(dev_attr, struct tgu_attribute, attr); >> + int ret = SYSFS_GROUP_INVISIBLE; >> + >> + if (tgu_attr->step_index < drvdata->max_step) { >> + ret = (tgu_attr->reg_num < drvdata->max_reg) ? >> + attr->mode : 0; >> + } >> + return ret; > > This is very convoluted > > How about: > > if (tgu_attr->step_index >= drvdata->max_step) > return 0; > > if (tgu_attr->reg_num >= drvdata->max_reg) > return 0; > > return attr->mode; > > ? > > [...] > I agree that the expanded form is clearer step-by-step, but I intentionally kept the current version as it keeps the bounds checks localized and avoids multiple early returns in this simple case. I find the conditional expression still reasonably readable here, but I’m happy to revisit this if you feel strongly about the style. >> +static void tgu_set_reg_number(struct tgu_drvdata *drvdata) >> +{ >> + int num_sense_input; >> + int num_reg; >> + u32 devid; >> + >> + devid = readl(drvdata->base + TGU_DEVID); >> + >> + num_sense_input = TGU_DEVID_SENSE_INPUT(devid); >> + if (((num_sense_input * NUMBER_BITS_EACH_SIGNAL) % LENGTH_REGISTER) == 0) >> + num_reg = (num_sense_input * NUMBER_BITS_EACH_SIGNAL) / LENGTH_REGISTER; >> + else >> + num_reg = ((num_sense_input * NUMBER_BITS_EACH_SIGNAL) / LENGTH_REGISTER) + 1; > > num_reg = base case > > if (num_sense_input * NUMBER_BITS_EACH_SIGNAL) % LENGTH_REGISTER) > num_reg++; > > ? > Marked, will update. > [...] > >> @@ -112,6 +250,8 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) >> { >> struct device *dev = &adev->dev; >> struct tgu_drvdata *drvdata; >> + size_t priority_size; >> + unsigned int *priority; > > reverse-Christmas-tree would be nice > > Marked, will update. >> int ret; >> >> drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); >> @@ -127,12 +267,32 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) >> >> spin_lock_init(&drvdata->lock); >> >> + tgu_set_reg_number(drvdata); >> + tgu_set_steps(drvdata); >> + >> ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups); >> if (ret) { >> dev_err(dev, "failed to create sysfs groups: %d\n", ret); >> return ret; >> } >> >> + drvdata->value_table = >> + devm_kzalloc(dev, sizeof(*drvdata->value_table), GFP_KERNEL); >> + if (!drvdata->value_table) >> + return -ENOMEM; >> + >> + priority_size = MAX_PRIORITY * drvdata->max_reg * >> + drvdata->max_step * >> + sizeof(*(drvdata->value_table->priority)); >> + >> + priority = devm_kzalloc(dev, priority_size, GFP_KERNEL); >> + >> + if (!priority) > > stray \n above Marked, will update. > > [...] > >> +#define BMVAL(val, lsb, msb) ((val & GENMASK(msb, lsb)) >> lsb) >> +#define TGU_DEVID_SENSE_INPUT(devid_val) ((int) BMVAL(devid_val, 10, 17)) >> +#define TGU_DEVID_STEPS(devid_val) ((int)BMVAL(devid_val, 3, 6)) >> +#define NUMBER_BITS_EACH_SIGNAL 4 > > "TGU_BITS_PER_SIGNAL" Marked, will update. > > Konrad