From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BDF382373 for ; Thu, 12 Mar 2026 09:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773308451; cv=none; b=OIXdxK2Q2Nvc5o0uj2e//b5pYidfg23oihX+wvHLCS/ZTSPDIIxN4ZnWoIX1z3uhmfVY125lmU8dwp1kqEJj+EWUS9lBjNzpDPeisyNs535gP+6piiDGfxG67JfM0sUKz8dqmxXycJFd+SPaqVGo4GKuyVLxNsa8dIbyNWhXQVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773308451; c=relaxed/simple; bh=ddEVo4L1jDTJ75CDuotLTBCt2IwHCurzLzGzvhrGLB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RbmigLvF0dlapTrhpw2t5MW2/suGhecpilnTGWFDqvZwHuQId9fjz7XZ1A/WYhaqCZCfUSN+TqweuGlQdrc+YiCauw1wvOAMbCp2TEM2WUTtQzvlawYMI930EMAGGSeUQxxxOVURGKJ3ena7DRhmtP8tKXdwZ/PtNnL7og+Y+8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=habS9Tvi; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eIfEsEl4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="habS9Tvi"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eIfEsEl4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773308449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e6EdyD35EC+SpPH1TY5bENOyft6Ge/0pFEQiQDyadAk=; b=habS9TvitoXdA0y1Ol2EBDShvBplk6Z9I7msfNJw56LwzALTv28ogf+TP4aGY64qGBQlnc x6AUi36K9fjLu3y64VX9m1SJPFkXyKza5MpwVXfOKO/vNmdp5kYZHe909By9qeN/uCMg1b 2KwPMaHAJBtVm0/6ILBOMt2oh5zXen0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-GDYkohNgN9-hXN3lzcCZkg-1; Thu, 12 Mar 2026 05:40:47 -0400 X-MC-Unique: GDYkohNgN9-hXN3lzcCZkg-1 X-Mimecast-MFC-AGG-ID: GDYkohNgN9-hXN3lzcCZkg_1773308447 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-439bab2d095so467456f8f.3 for ; Thu, 12 Mar 2026 02:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773308447; x=1773913247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e6EdyD35EC+SpPH1TY5bENOyft6Ge/0pFEQiQDyadAk=; b=eIfEsEl4s9AAZ3jWXp+IHQRc/xX60iWLK1BBo3LsBX0iINPerVsaHlOAoFCoxvRqIT efIMsFpmroymfPY0xWCP+MfiIpwQolNJG+g0Xg31bkI0Yew+sH/BeagEfmp/nnMU7EIW JR4HJa4aP76PDj1hkhFyiacHe1KbOWxFpTRq2zx2Y8MNUMgYAwk27fO8uyOkLRSmxTj9 jsCGHcLpstxu0Y5vDNZTYStzZHqMvrInAWNz6lJEcN2n6PZE/eeNdQVfCWJofQUtkJ4D kOw5THz6NTYP18uE/OOlHu8PkZQDxGgXIU+6o1LmScEMDt7IaVNKhjN66+3yuA8g1BjN 9ATQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773308447; x=1773913247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e6EdyD35EC+SpPH1TY5bENOyft6Ge/0pFEQiQDyadAk=; b=mFTqT54VplS51D9cTaK6f4Jnk+cfkF3IYtvUEc0WphVkQ/xHNMhz6p9mVz2GjyesH0 1TyFoqNscBOUpzqobGaLC8j0xCY1j3j1Tnlzu55dsGQxXqR88GwgO5Cgy17AuSfdx6G8 UrMexMa+YSGxbFsvjkmx2gOoI/OxygUd2jJXq+7/WzlFxiMSXpnidvdj7EilmGcEomJv HcqciZCW7ng1rCz6FAMGoqy9bAezzAaHg7Q0xPuUARnOXQxPxq7YNcWCr/JI2dROe9xU KMwOp+1LDce8c5P3kAE6Dr0QD6a/C8gnkEWLSKItFgyZWRKqZrlIA+qZNS9Oj9a829tD Exjg== X-Forwarded-Encrypted: i=1; AJvYcCUJV55ZZB0vRI7hiEHqgRBqGH182AGlaewXhQbYezRATEro5wu1PhKNr/SXGjCSYn5QGyiC0PLyDOLaIPM=@vger.kernel.org X-Gm-Message-State: AOJu0YyBYU+vkFtkq1tS9eBjavSgSIngi9LjvmMIDbstEp4r0dOrL9Si D21OG3o4DWdsxMDlDKyR/NzqZDMK3dbvDkggyMUmmB+Bzn5e3fNWVbQml+yURPnsjA1XykSMF/8 ec/90CZbXycicyUAKdAIfrSDFcqWJ362gVym9OvyUDq4VF6a6ClJSKW2VWx/11jIxsg== X-Gm-Gg: ATEYQzzcIfE+PGjpWo0CV/wYQIbLIqgAo5b4M3IOGy6OUhWMOszP5TeaQiNSlbS11Km 0enNzFPEPq+jbG6Ej0ha41Qu2hPjz0Ug0XW4qF3sg7XLSmCPxyQLdCo67cpqMnrsDTEugLprYBZ ltXZtiZ6sM1wOn29qws8gMXojPHY/99Me19mLdT5ThxoZ5lEvX4wty3o8CBGEu5JfZhw6z5Ik7w xh2oDwbqTinOrVkSUWaHcrDGDQZyuu5XOndnKANr1QYJ0T47mBuPl1H0XHvLq85kNhjwW2IQVjW ZfI6ey1z/vPuQ3GXQSNrIbWjCMnmlbKX7JAgqbhx2a/aUv6X4P62AWqIHLmCVc41Wdv8sTtnsZo aPCAaSXuMEmeI/FZGw6byxFBUpQEDnOOse/IGKcPCay5MdwuenaNZpHE= X-Received: by 2002:a05:6000:228a:b0:439:ca64:967c with SMTP id ffacd0b85a97d-439f822b9d9mr9932334f8f.44.1773308446707; Thu, 12 Mar 2026 02:40:46 -0700 (PDT) X-Received: by 2002:a05:6000:228a:b0:439:ca64:967c with SMTP id ffacd0b85a97d-439f822b9d9mr9932296f8f.44.1773308446263; Thu, 12 Mar 2026 02:40:46 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe22f3a4sm7155566f8f.38.2026.03.12.02.40.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 02:40:45 -0700 (PDT) Message-ID: Date: Thu, 12 Mar 2026 10:40:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot ci] Re: net: move netdev_compute_master_upper_features to ndo_set_features To: Sabrina Dubroca , Hangbin Liu Cc: syzbot ci , andrew@lunn.ch, bridge@lists.linux.dev, davem@davemloft.net, edumazet@google.com, horms@kernel.org, idosch@nvidia.com, jiri@resnulli.us, jv@jvosburgh.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, razor@blackwall.org, sridhar.samudrala@intel.com, syzbot@lists.linux.dev, syzkaller-bugs@googlegroups.com References: <20260310-offload_compute-v1-0-3df79c09ea65@gmail.com> <69b04e91.a70a0220.51e36.0000.GAE@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/11/26 10:18 PM, Sabrina Dubroca wrote: > 2026-03-11, 00:47:41 +0000, Hangbin Liu wrote: >> On Tue, Mar 10, 2026 at 08:17:01PM +0100, Sabrina Dubroca wrote: >>> 2026-03-10, 10:02:09 -0700, syzbot ci wrote: >>>> batman_adv: batadv0: Not using interface batadv_slave_1 (retrying later): interface not active >>>> hsr_slave_0: entered promiscuous mode >>>> hsr_slave_1: entered promiscuous mode >>>> ------------[ cut here ]------------ >>>> err == -EMSGSIZE >>>> WARNING: net/core/rtnetlink.c:4421 at rtmsg_ifinfo_build_skb+0x218/0x260, CPU#0: syz-executor/6496 >>> >>> I'm not sure this one is caused by this series, but either way, >> >> >> rtnetlink_event+0x1b7/0x270 >> notifier_call_chain+0x1be/0x400 >> netdev_change_features+0x95/0xe0 >> __netdev_upper_dev_link+0xb20/0xc80 >> netdev_upper_dev_link+0xb0/0x100 >> >> >> This patch calls netdev_change_features() after __netdev_upper_dev_link(), >> Which trigger a NETDEV_FEAT_CHANGE notify and calls rtmsg_ifinfo_event() >> to fill the new link info. Maybe the event is a bit early and macsec has >> data not ready? > > But this would still mean that there's a mismatch between > if_nlmsg_size() and rtnl_fill_ifinfo(), and your patch is only > revealing it. > > I'll send fixes for the stuff I mentioned, no idea if that's what > syzbot saw since we don't have a repro. It looks like even the nipa CI is reproducing the issue, i.e.: https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-dbg/results/554921/17-rtnetlink-sh/ more failures here: https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2026-03-12--06-00&pw-n=0&pass=0 the fail in mascsec-offload looks quite deterministic, could you please have a look? /P