From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E4DC77B73 for ; Thu, 20 Apr 2023 21:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232677AbjDTVkK (ORCPT ); Thu, 20 Apr 2023 17:40:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbjDTVkI (ORCPT ); Thu, 20 Apr 2023 17:40:08 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CB0730D2 for ; Thu, 20 Apr 2023 14:40:06 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-2f8405b3dc1so635496f8f.3 for ; Thu, 20 Apr 2023 14:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682026805; x=1684618805; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OiKofJxLpzcK1POL74XTZyiqo6DoCaEtr8igEFYC4N0=; b=V2dH4vpRLVU0oUQozrZ4aUjCxexgGCk8qrGT1JSJH0oX+TF30NsX/XeVSEbTU7IV9G gUHhi5fTlDrKtuyn46BrT4Wf7XpVbtRVLzcpKEz1jvyiyjhXRIpVr7NRTunj+nyomeYc 159R2BOM9Y9Lfk+uKZzCb+4kZW5K1sAgAygsHH2lAC4aLnRxWXWV6TCkJCYIIGGPwtC2 qjF1Nh5tiT8x2zjqMcYTYXo6rLkNg0dO0QvtVD6Rxrl+pMKFcsKLOIi4tW/W+R/lTYX1 MAV9op715wtaX08kXJ/4AuacKyNZIfeZ//ntFQf/3PPJKjvlVMZ2spOyrMuqbWCtruwA y40g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682026805; x=1684618805; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OiKofJxLpzcK1POL74XTZyiqo6DoCaEtr8igEFYC4N0=; b=IoIiskVya2MI9T045OX/xPJheEX8IE8AHmHPh0qvJgVpn6LOensFo+PoaVLO3SO36H 57wHsqbueM9i3EIu6BcgWQ55PwyoOtRjau9somp4EtskPagP7ANX3QRcEwvfLgdt1nbg oUH9HWI9AxBl8RDV5MXbYjWqVrGj1JVTYnTJd4Ygvtae3oA+1r6qTus21jM9LaFK0cii E2MYqxghOcKSBEh2U0YoR/dJS8eabx4R3qQze1D6lxOzSQQpmVHk3FI9EYE8tfjSUMwV cJ/l+y3ehII4ADciZFGHHT8+2ThyImcbi0iEGZlD76MCpi77EpxH3t6l+rlTC6TWLyAY 0hgw== X-Gm-Message-State: AAQBX9fB4P09ImFE9zAYmenI6WLr9GiT9EMLrZA8Xd1pWGXpHk3Fp5sL S4HSMJvIp4ovexiRJUfjji2h6Q== X-Google-Smtp-Source: AKy350aKUvhXcbdvVhj8HlnP8pqn62/PVNayCFHM8SljUDL0UqCy2dveIPqqaObMyOoz9TxPqKtM/Q== X-Received: by 2002:a5d:6182:0:b0:303:2702:6d66 with SMTP id j2-20020a5d6182000000b0030327026d66mr676582wru.63.1682026804799; Thu, 20 Apr 2023 14:40:04 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:4599:1915:621d:5b00? ([2a05:6e02:1041:c10:4599:1915:621d:5b00]) by smtp.googlemail.com with ESMTPSA id bi26-20020a05600c3d9a00b003eddc6aa5fasm2701860wmb.39.2023.04.20.14.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 14:40:04 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 23:40:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Content-Language: en-US To: "Rafael J. Wysocki" Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Amit Kucheria , Sujith Thomas , Randy Dunlap , Srinivas Pandruvada References: <20230419083343.505780-1-daniel.lezcano@linaro.org> <20230419083343.505780-7-daniel.lezcano@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/04/2023 19:24, Rafael J. Wysocki wrote: [ ... ] > After looking at it once more, I think that this driver isn't really > functional without the additional sysfs attributes, so if > CONFIG_INTEL_MENLOW_SYSFS_ADDON is set, the driver effectively becomes > dead code. > > That's rather unfortunate and I'm not sure how to deal with it ATM. > > I can queue up the rest of the series for 6.4-rc1 (in which case it > will be pushed in the second half of the merge window), but this > particular patch requires more thought IMV. I'm fine if you drop this one from the series. Thanks for looking at it more deeply -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog