From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbcIAJsg (ORCPT ); Thu, 1 Sep 2016 05:48:36 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:28456 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbcIAJsd (ORCPT ); Thu, 1 Sep 2016 05:48:33 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-64-57c7f96d4fab Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards To: Javier Martinez Canillas References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <1472645679-5696-2-git-send-email-javier@osg.samsung.com> <20160831174657.GA19969@kozik-lap> <0e8e0b3c-0dd9-c44b-d1ad-03c840d3a725@osg.samsung.com> <184ad5f6-5528-2ad7-7c2b-46beda9b6dc9@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland From: Krzysztof Kozlowski Message-id: Date: Thu, 01 Sep 2016 11:48:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <184ad5f6-5528-2ad7-7c2b-46beda9b6dc9@osg.samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t/xK7q5P4+HG/w4IWkx/8g5Vos3b9cw Wbx+YWjR//g1s8XlXXPYLGac38dksfT6RSaL1r1H2B04PNbMW8PosWlVJ5vHlv677B59W1Yx enzeJBfAGsVlk5Kak1mWWqRvl8CVMefULdaCDyIV7W0T2RsYHwt0MXJySAiYSDza1c4IYYtJ XLi3nq2LkYtDSGApo8TvKfsYIZxnjBK3N3xhB6kSFoiSOHVwFTOILSJgKvFr7QtWiKKdzBLz W3qZQBxmgZOMEhsnbmbpYuTgYBPQlvi3pRikgVfAVuLYnXYWEJtFQFXi9P4TYINEBSIkbq36 yAhRIyjxY/I9sBpOAWeJnid/mEDGMAuoS0yZkgsSZhaQl9i85i3zBEaBWUg6ZiFUzUJStYCR eRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSLB/2cG4+JjVIUYBDkYlHl6HN8fChVgTy4or cw8xSnAwK4nwrvt+PFyINyWxsiq1KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotg skwcnFINjJvsP0kvCi894u2k+SXyZIfo2R722Aj+wjXHmXkVZz7qUY/r1e+5cvKatrLFjDXr 931ayDVL7H7Ij2jG5W4pHWW778XMqp7A4FX7N/Q5x9d2gS0yngIGS6fqCAlfyTVYcalfYg3z r89HNGUvTJG7fY2nYgPTu9V/VX5sjjn+3P+x9IfnEc71/UosxRmJhlrMRcWJACWdzv9yAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 11:36 AM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote: >> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote: >>> Hello Krzysztof, >>> >>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote: >>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote: >>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts >>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts >>>>>>> @@ -21,6 +21,11 @@ >>>>>>> bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; >>>>>>> }; >>>>>>> >>>>>>> + memory { >>>>>>> + device_type = "memory"; >>>>>>> + reg = <0 0>; >>>>>>> + }; >>>>>> >>>>>> This looks okay, but the default size and address cells won't be >>>>>> present. Won't that be a problem? >>>>>> >>>>> >>>>> They will be present since at this point exynos5440.dtsi is still including >>>>> exynos5440.dtsi, we are just overriding the memory node with the same values >>>>> than skeleton.dtsi so this can be removed later in patch 7/7. >>>> >>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node. >>>> >>> >>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set >>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are >>> set in that included dtsi). >> >> Where? Nothing in my sources... >> >> 15 / { >> 16 compatible = "samsung,exynos5440", "samsung,exynos5"; >> 17 >> 18 interrupt-parent = <&gic>; >> > > No, I meant that these are set by the fact that exynos5440.dtsi is including > the skeleton.dtsi, since the dtsi set these properties in the top node. > >>> >>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB >>> before and after $SUBJECT. >> >> Maybe these are also the default values so no differences... stating >> them explicitly would be useful. >> > > I could do it in this patch... but I don't see why that should be needed since: > > a) All the others Exynos SoC dtsi file don't explicitly set these properties > since are set by skeleton.dtsi when including it. So not adding them keeps > exynos5440.dtsi consistent with the other SoC dtsi. > > b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done > in a later patch of this series. Again, making it consistent with all the > Exynos SoC dtsi since none will include skeleton.dtsi anymore. Ah, I missed it. The 'b' is the solution I wanted so everything is fine. Best regards, Krzysztof