From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E236B223DE9 for ; Thu, 4 Dec 2025 20:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764878534; cv=none; b=VTxmJ6+u0/cqVYOe7lT4FymM7RO1FPmFpELbVk5FhbHiwb1mxsCRd9rm5Oe7E7wA91PIzRXBhOYSyj3HNhbeo0sx0SPTBY3EPrcRnLJJ3rsyhU3MoxFczPQ1fVSUGVlydALCkauor1qyma4pdTkFEfPe04TC0JBAlnWZvoQyyfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764878534; c=relaxed/simple; bh=JMH/HG8MsU0PjysijNPLfP4/6yp11SxVwfmOUeLv494=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=rqsolJYVvT1wfgNelq41mmXE1eMOcsqyZIMh+S2bn4er5VwIL5Wi8TDnX1Y7jUSJDRNKxcVTNhwvrFdEgrjn3b9SLiILZEcHPtiFWTM0njdRV04xYZJP34YLiNR3VI263mQONpMGz8r+3Cxar/5kR+D7iacS+LMCB6jcC2ehbIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=citrix.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=bXzC+kwQ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=citrix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="bXzC+kwQ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477632b0621so9555225e9.2 for ; Thu, 04 Dec 2025 12:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1764878531; x=1765483331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JMH/HG8MsU0PjysijNPLfP4/6yp11SxVwfmOUeLv494=; b=bXzC+kwQIG72mS+LR7kYcakF+CAdDdObtEV0UiVtk1mKEOM6J9EQb87S0i8v1YDQfg n6FHM+4dZTfoKSXnt9gwY/2876TfgpMEX3Yc6wcfoK2zyaim4yH6VIMhj+Xl/AK55WCj Tv3OhqiFPNW6jLg85DqumFaLXKqGaWUNCd5QQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764878531; x=1765483331; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JMH/HG8MsU0PjysijNPLfP4/6yp11SxVwfmOUeLv494=; b=mdaA6uRvSzJfOoJMI+VT3xPL9yw5j4oVpY7rrXByBWsz5Gwl6GwWsTPLKWilF0AW2T +xrCYz6zwTPVExvvjSbXfC9bzaLxYCmpyam2G6V0ZcnaUsL5zJGO+UWK7XJOzGr0UI9E QuPMrqRDNfK1q+GQrapwezQCx/9afBGTji8g5m9yz/rkBN8xjQhj5aQX6wRd7uVShioG KxZ6Hmse3kV25xHnlKSim9vnGyYDXENP6p4C0zdb8Kia1BHUGcWpQ6XIvp0F++iB/rGw LWp3AkTNIyY3mpDApt7GojftDUnRERcN8DRFfOTCogTAO26dEWqwe0v8Gj4SWpo5GQeS kTNA== X-Forwarded-Encrypted: i=1; AJvYcCUHWTF4B1SwFpecVNrlykejdrcQEQmHkXcw5ypL0dzO725IL5PZMZg5PA8EpQRxglPCaVOMa9+ajcI1Dh0=@vger.kernel.org X-Gm-Message-State: AOJu0YyrG2/bCURWUY9f/PbWw+YRJAfg6CNvUd1T6N7WBlBLZwuVUybv Ms4QlxYfKHmqWD9MBPOt/wmfczjmyANc9VPbFzD/TsYHrOyUTtDfCuKorhYJnJFXx/Q= X-Gm-Gg: ASbGncv+kvX/iS1w5BgpvDgxRyONbKPO+cX0DgqSwT9Kj4W7SkKSeNew40+PhQznegY M5TAk01qwn2/FFsurs6v100PIVcBiX4dRN2XHUPV9Eru9TPToS0Q/MO7F3dprnS7iB4rUgU8DOt kql0BiPtwcrTHj0qhlIdwwIoPJiI8H1XYauFvhzFp+0pH8D7fHOy8CZb5X0cugnnLhO4Nwg7ORC jguHgKsVgiyJbyAXWvMXNM3sf637OXg4YeZJesVtmMH0vkdoE+BgxlKe+oN1M3WvevxVPepl4x+ MCpFwhm/W3+TGuspLpUZIFbA/NVdEywSgSjQutP/M8lDaVwMPTl8U+yrBzs5Fl9fAtoTCBtWkVu 5VQcoQue5JLO3PAqfJFZjy+WXKz4XJXhDE2hSf9b/RPXwD/H85btK09dcXEytYJaFPEvWWCiInb hSMegTNVTTnGE1ZbZNq2CpkqFKXTKuka6QO08iptjWiMIzZpsMgaJt X-Google-Smtp-Source: AGHT+IGBYOcZEOwoTpmuQv9AG7T29/gyYMdZkN//DcWpM1EOnXVukTnZt6v4E+43qVNrhuaEzsAMNg== X-Received: by 2002:a5d:6403:0:b0:429:dc9a:ed35 with SMTP id ffacd0b85a97d-42f731a2ff0mr6121265f8f.43.1764878531024; Thu, 04 Dec 2025 12:02:11 -0800 (PST) Received: from [192.168.1.37] (host-92-26-102-188.as13285.net. [92.26.102.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222478sm4839210f8f.20.2025.12.04.12.02.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 12:02:10 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 20:02:09 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ak@linux.intel.com Cc: ggherdovich@suse.cz, linux-kernel@vger.kernel.org, peterz@infradead.org, rafael.j.wysocki@intel.com, x86@kernel.org, Andrew Cooper References: <20251204180914.1855553-1-ak@linux.intel.com> Subject: Re: [PATCH] x86/aperfmperf: Don't disable scheduler APERF/MPERF on bad samples Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20251204180914.1855553-1-ak@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > However this can happen without any malfunction when there is > a long enough interruption between the two MSR reads, for > example due to an unlucky NMI or SMI or other system event > causing delays. The list of problems is even longer under virt.  The vCPU can lose it's timeslice (-> arbitrary delay), or be scheduled onto a different CPU between the A and M reads (-> calculate the wrong ratio, and not in a way you could exclude it as a bad sample). Despite this, some people insist on having A/MPERF inside VMs. ~Andrew