From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62413C433EF for ; Sat, 2 Apr 2022 13:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355067AbiDBNL4 (ORCPT ); Sat, 2 Apr 2022 09:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349663AbiDBNLw (ORCPT ); Sat, 2 Apr 2022 09:11:52 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8F8135086; Sat, 2 Apr 2022 06:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648904997; x=1680440997; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dvbuIXbkI8htF3qS/EzjnonFbCEyeYOQWdm6UwPCfQ0=; b=UvlLU/ZpnJn08MqURcbv8x+2URRoFzf4ZzZAe70qEjGpdkFwjUHbbxVi b0Fhn3ddq6sJ8+GSCUqrhgOXVQpXvbipS95oE3q0S6bRGb5wqLB5+AAAm ltWuCXZjQI5GBQsOBl51zJ/+/L0xhIAigVVJu1QFb11xQ1PNCkfFwruf6 e+jgURBDrBkGXj6JaIaKTSYd15jCfiE2xYYWU2tUIs+fU9rs1/S3GsRKR PXVHxUf1x1KhROOmWhfdyDNieyZ+EHVaeFsi0CMYibdSmy3NcCQAl0p2U N64ts5uewojjXMscDhazZ3mG9OobaOfsCnprfAZD1uQp6RbN9QC3JXyN1 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10304"; a="257882201" X-IronPort-AV: E=Sophos;i="5.90,230,1643702400"; d="scan'208";a="257882201" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2022 06:09:56 -0700 X-IronPort-AV: E=Sophos;i="5.90,230,1643702400"; d="scan'208";a="548134833" Received: from zengguan-mobl1.ccr.corp.intel.com (HELO [10.254.208.38]) ([10.254.208.38]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2022 06:09:49 -0700 Message-ID: Date: Sat, 2 Apr 2022 21:09:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 4/8] KVM: VMX: dump_vmcs() reports tertiary_exec_control field as well Content-Language: en-US To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , Dave Hansen , "Luck, Tony" , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , "Huang, Kai" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Hu, Robert" , "Gao, Chao" , Robert Hoo References: <20220304080725.18135-1-guang.zeng@intel.com> <20220304080725.18135-5-guang.zeng@intel.com> From: Zeng Guang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/2022 6:46 AM, Sean Christopherson wrote: > Nit, shortlog is funky, it'd read better as > > KVM: VMX: Report tertiary_exec_control field in dump_vmcs() > > On Fri, Mar 04, 2022, Zeng Guang wrote: >> From: Robert Hoo >> >> Add tertiary_exec_control field report in dump_vmcs() > Please call out the shuffling of PinBased and provide a sample dump. It's not > mandatory to put that sort of info in the changelog, but it really does help > reviewers, e.g. I remember discussing the shuffling and seeing the sample output, > but other reviewers coming into this blind won't have that luxury. OK. Will give more details.