From: Jonathan Cameron <jic23@kernel.org>
To: Harinath Nampally <harinath922@gmail.com>, lars@metafoo.de
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions
Date: Sun, 14 May 2017 15:41:24 +0100 [thread overview]
Message-ID: <bcf17863-87f3-2ba8-e7c9-768161a8c94a@kernel.org> (raw)
In-Reply-To: <1494623944-7174-1-git-send-email-harinath922@gmail.com>
On 12/05/17 22:19, Harinath Nampally wrote:
> This patch fixes below kind of warnings:
> WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
>
> Issue found and fixed by checkpatch.pl
>
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Already done by Quentin Swain <dudebrobro179@gmail.com> last month...
For IIO related patches, stuff gets queued up in iio.git on
kernel.org before it gets sent on to Greg. This is relatively
unusual for staging, but does lead to lots of repeats of
patches like this unfortunately.
Jonathan
> ---
> drivers/staging/iio/meter/ade7758_core.c | 50 ++++++++++++++++----------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7758_core.c b/drivers/staging/iio/meter/ade7758_core.c
> index 99c89e6..40498af 100644
> --- a/drivers/staging/iio/meter/ade7758_core.c
> +++ b/drivers/staging/iio/meter/ade7758_core.c
> @@ -301,103 +301,103 @@ static int ade7758_reset(struct device *dev)
> return ret;
> }
>
> -static IIO_DEV_ATTR_VPEAK(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_VPEAK(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_VPEAK);
> -static IIO_DEV_ATTR_IPEAK(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_IPEAK(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_VPEAK);
> -static IIO_DEV_ATTR_APHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APHCAL(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_APHCAL);
> -static IIO_DEV_ATTR_BPHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BPHCAL(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_BPHCAL);
> -static IIO_DEV_ATTR_CPHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CPHCAL(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_CPHCAL);
> -static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_WDIV(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_WDIV);
> -static IIO_DEV_ATTR_VADIV(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_VADIV(0644,
> ade7758_read_8bit,
> ade7758_write_8bit,
> ADE7758_VADIV);
> -static IIO_DEV_ATTR_AIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_AIRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_AIRMS);
> -static IIO_DEV_ATTR_BIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_BIRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_BIRMS);
> -static IIO_DEV_ATTR_CIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_CIRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_CIRMS);
> -static IIO_DEV_ATTR_AVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_AVRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_AVRMS);
> -static IIO_DEV_ATTR_BVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_BVRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_BVRMS);
> -static IIO_DEV_ATTR_CVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_CVRMS(0444,
> ade7758_read_24bit,
> NULL,
> ADE7758_CVRMS);
> -static IIO_DEV_ATTR_AIRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AIRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_AIRMSOS);
> -static IIO_DEV_ATTR_BIRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BIRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_BIRMSOS);
> -static IIO_DEV_ATTR_CIRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CIRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_CIRMSOS);
> -static IIO_DEV_ATTR_AVRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AVRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_AVRMSOS);
> -static IIO_DEV_ATTR_BVRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BVRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_BVRMSOS);
> -static IIO_DEV_ATTR_CVRMSOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CVRMSOS(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_CVRMSOS);
> -static IIO_DEV_ATTR_AIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AIGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_AIGAIN);
> -static IIO_DEV_ATTR_BIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BIGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_BIGAIN);
> -static IIO_DEV_ATTR_CIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CIGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_CIGAIN);
> -static IIO_DEV_ATTR_AVRMSGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AVRMSGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_AVRMSGAIN);
> -static IIO_DEV_ATTR_BVRMSGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BVRMSGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_BVRMSGAIN);
> -static IIO_DEV_ATTR_CVRMSGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CVRMSGAIN(0644,
> ade7758_read_16bit,
> ade7758_write_16bit,
> ADE7758_CVRMSGAIN);
>
next prev parent reply other threads:[~2017-05-14 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 21:19 Harinath Nampally
2017-05-14 14:41 ` Jonathan Cameron [this message]
[not found] ` <CAAGUq_qi8GW4LVmTtU=1uZFTJvtjc-9RMP3AXbZYb9FcZZ2hDg@mail.gmail.com>
2017-05-15 4:27 ` harinath Nampally
2017-05-15 4:38 ` harinath Nampally
2017-05-16 18:24 ` Jonathan Cameron
2017-05-19 2:01 ` harinath Nampally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf17863-87f3-2ba8-e7c9-768161a8c94a@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harinath922@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome