From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156822FC009; Thu, 4 Sep 2025 12:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756990294; cv=none; b=HjS4qxXrcmbOAuRW8m30bAPOxubLltdoBshns1TwlNKDSpvGUBC7maBZeZ3c8ZShRI9ssDdYZoPBf+UB9pQveOYY0zsH2bhsi9s/gav9PoLBTMJMulJgIId1L65heY+EJOAvswfSOfXBNRYpDZnLDe0SFKld1RWrIAkNEovK3eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756990294; c=relaxed/simple; bh=mjmuP3eTd5TQVyMcuIqiR9BfXcdv96nsp1pWUeopX8A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=haswuUlpZUKHYavrPWtasrPmizrC5Ij19zs3WNt2/3vgkxfnhVLFNesSoehyCl5NFCNXzT00agHYtgDpd0a6Aff/Tc7R5/8HBDct7tq/WuN3dPlBiWXFoitQwrmhgj2OOfFkkPtCWU4735Lt3mM4i6mmp1yM3s4oy4Eph+csjnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=vYr2V7Ga; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="vYr2V7Ga" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AkSI/H68/3rO9+rnbUFWKGs+2zxiUh31b/gspJbDwFk=; b=vYr2V7Gato0bSRMSrst4zVigSs QfWDIDzkzN1M4B0Vqh2Ef4jFKVI4fARxoVjrgmJxefFY23HAFxo+U2L0A6mAa71Z8ONnJYgBndXh8 CaGwFQPXfEbwPu4SreDuKvfKgrkSwS9fciVJUr47akLzlsOs1C/jLS3p1nAQ8sGI7Yuo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uu9Qy-007DDO-Qf; Thu, 04 Sep 2025 14:51:24 +0200 Date: Thu, 4 Sep 2025 14:51:24 +0200 From: Andrew Lunn To: Qingfang Deng Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Fietkau Subject: Re: [RFC PATCH net-next] ppp: enable TX scatter-gather Message-ID: References: <20250904021328.24329-1-dqfext@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250904021328.24329-1-dqfext@gmail.com> > diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c > index f9f0f16c41d1..3bf37871a1aa 100644 > --- a/drivers/net/ppp/ppp_generic.c > +++ b/drivers/net/ppp/ppp_generic.c > @@ -1710,6 +1710,12 @@ pad_compress_skb(struct ppp *ppp, struct sk_buff *skb) > ppp->xcomp->comp_extra + ppp->dev->hard_header_len; > int compressor_skb_size = ppp->dev->mtu + > ppp->xcomp->comp_extra + PPP_HDRLEN; > + /* Until we fix the compressor need to make sure data portion is > + * linear. > + */ > + if (skb_linearize(skb)) > + return NULL; The word 'fix' suggest something is broken. I don't think that is true, its just a limitation of the compressor. Please avoid 'fix'. Andrew