From: Pavel Begunkov <asml.silence@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()
Date: Wed, 9 Dec 2020 12:06:55 +0000 [thread overview]
Message-ID: <bcfd61df-23cd-fb56-5d7a-47ee2f025739@gmail.com> (raw)
In-Reply-To: <20201209083341.GA21968@infradead.org>
On 09/12/2020 08:33, Christoph Hellwig wrote:
> On Thu, Dec 03, 2020 at 11:48:56AM +0000, Pavel Begunkov wrote:
>> It's inlined and the on-stack iter is completely optimised out. Frankly,
>> I'd rather not open-code bvec_iter_advance(), at least for this chunk to
>> be findable from bvec.h, e.g. grep bvec_iter and bvec_for_each. Though,
>> I don't like myself that preamble/postamble.
>
> Ok. I still think we at least want a separate helper instead of
> bloating the main iov_iter_advance.
I agree on that, just haven't got back to it yet.
--
Pavel Begunkov
prev parent reply other threads:[~2020-12-09 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 1:45 Pavel Begunkov
2020-12-03 9:14 ` Christoph Hellwig
2020-12-03 11:48 ` Pavel Begunkov
2020-12-09 8:33 ` Christoph Hellwig
2020-12-09 12:06 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcfd61df-23cd-fb56-5d7a-47ee2f025739@gmail.com \
--to=asml.silence@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome