From: Paolo Abeni <pabeni@redhat.com>
To: Yuyang Huang <yuyanghuang@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ipv4: igmp: annotate data-races around in_dev->mc_count
Date: Thu, 4 Jun 2026 11:15:29 +0200 [thread overview]
Message-ID: <bcffe05b-c10c-4a27-b260-e6ae872c795e@redhat.com> (raw)
In-Reply-To: <95adff35-ee56-49d3-8567-382ac17810b3@redhat.com>
On 6/4/26 11:11 AM, Paolo Abeni wrote:
> On 5/31/26 5:07 AM, Yuyang Huang wrote:
>> @@ -1922,7 +1923,7 @@ void ip_mc_destroy_dev(struct in_device *in_dev)
>>
>> while ((i = rtnl_dereference(in_dev->mc_list)) != NULL) {
>> in_dev->mc_list = i->next_rcu;
>> - in_dev->mc_count--;
>> + WRITE_ONCE(in_dev->mc_count, in_dev->mc_count - 1);
>> ip_mc_clear_src(i);
>> ip_ma_put(i);
>
> The patch LGTM,
But it does not apply cleanly to net. Please rebase and report, adding
the target tree (`net`) and a revision number (`v2`) in the subj prefix.
/P
next prev parent reply other threads:[~2026-06-04 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 3:07 [PATCH net-next 0/2] ipv4: igmp: annotate diagnostic procfs data races Yuyang Huang
2026-05-31 3:07 ` [PATCH 1/2] ipv4: igmp: annotate data-races around in_dev->mc_count Yuyang Huang
2026-06-04 9:11 ` Paolo Abeni
2026-06-04 9:15 ` Paolo Abeni [this message]
2026-06-04 10:17 ` Ido Schimmel
2026-06-04 10:19 ` Ido Schimmel
2026-06-04 11:41 ` Yuyang Huang
2026-05-31 3:07 ` [PATCH 2/2] ipv4: igmp: annotate data-races around timer-related fields Yuyang Huang
2026-06-04 10:20 ` Ido Schimmel
2026-06-04 11:35 ` Yuyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcffe05b-c10c-4a27-b260-e6ae872c795e@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®