Re: [PATCH] dt-bindings: power: Add SiFive Domain Management controllers

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/05/2025 05:20, Nick Hu wrote:
> On Fri, May 9, 2025 at 2:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Fri, May 09, 2025 at 10:16:04AM GMT, Nick Hu wrote:
>>> SiFive Domain Management controller includes the following components
>>> - SiFive Tile Management Controller
>>> - SiFive Cluster Management Controller
>>> - SiFive Core Complex Management Controller
>>>
>>> These controllers control the clock and power domain of the
>>> corresponding domain.
>>>
>>> Signed-off-by: Nick Hu <nick.hu@sifive.com>
>>> Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
>>> ---
>>>  .../devicetree/bindings/power/sifive,tmc.yaml | 89 +++++++++++++++++++
>>
>> Where is a patch with the driver (user of the binding)?
>>
> We are hoping the driver can be submitted at a later stage.
> The driver that handles the MMIO is implemented in OpenSBI and depends
> on some prerequisite patches [1], so it will follow afterward.

This patch alone makes little sense and brings little benefit. Post this
with user.

...

>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  sifive,feature-level:
>>> +    description: |
>>> +      Supported power features. This property is absent if the full set of features
>>> +      is supported
>>
>> Compatible defines this. Drop.
>>
> The property depends on how the IP is hooked up to the rest of the SoC.
> Having this property simplifies the SW and allows us to use a single
> fallback compatible string, so we prefer to keep it.

And we prefer you to follow standard DT rules, see writing bindings or
talks on conferences.


Best regards,
Krzysztof