From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CF793803DD for ; Mon, 30 Mar 2026 05:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774849545; cv=none; b=BmH2FvmVTSJORtPVeq93N078YLa7xQ5Wb1zgGR+AbzOweVdm9HI7wk+2kmg5rZwzR6u2iAWihvFkPLLVukuaGFxxOk6PlC0YYChf6eh17tbexVxQIYPwWM/1/6CyvgrDAbLgwDtvAz9hKVKgLcbk3P6UEwkl1XQv0kwbQUxoLa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774849545; c=relaxed/simple; bh=poc9qMgnkwcElIolQsxsct50pUXh2ykMOLBvEytqk/Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TLZczgutgKryW/PR7wOegRQm1MC9DeEtgEhuIUAx7XbY45FEJWQMteCDkxESyEk9O5EYoE0SvZDLpcWNb/8H2s9WMACDExY2kIBxOHtTRL7sKQNXPAGtCj24joedSkwuLr3mxzYinLAedS9R0xY2U0OBlOcI+AnIj1ROv+x8s34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TimNB1Ec; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GZJu2rpm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TimNB1Ec"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GZJu2rpm" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62TILmLq1138244 for ; Mon, 30 Mar 2026 05:45:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M7DVu227WmucQxYjqTod8kwtol9NGmVKJ1oGMwmvziw=; b=TimNB1EcKlmIyDiO M+SCINIuQQlf2gAToKSWbXcaXdgTGnNK4jS/fZ/bfJeIBL9oy+/opKe8XKUQpGLC 9xhYXcahI2Lk18PRg9e4zj11uyQxshM4oyyf9AHXyeSxsFrdyN98HGCyB2d5x9qf 9R0vc2tvV3Kn2/BWeIre1go+jKktxZqPS/6pUk7zmuvEtNC2vCoY08RB9rdst/kq +sC+JKiykd3k+CJHgCxHvnU/DCIhKJE2Ad/SBF2GUH4iMRgaaW/3J+QO35xO8orp DCpBGAwEvVuANtt4GPF2Wkf+Uij3DBKHNZL5gsGred8Q/upQ9f4jxKDyU2M9YN1X g7yO/Q== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d66jwmmy7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 05:45:43 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82c63f85c84so2777139b3a.2 for ; Sun, 29 Mar 2026 22:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774849542; x=1775454342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M7DVu227WmucQxYjqTod8kwtol9NGmVKJ1oGMwmvziw=; b=GZJu2rpmQwE4qqUXA1bxqL7UFhCdfKaYIzxpSgF2S4b3O10XWcX3z8QbBxvLgM0CJ4 99wu1HqZahRjxV/YBwKaXca86lGHfdz6HNhEz6F3DgwmK12RiTQSoMd1jBui7Prpr7gs /GA5NC/+zzpTOnpbQQQGIAMvXdSaaD8y0bC2OmqJd8SyqeXuaNu7wVCbzcjShk4jUx2+ CLz/YZbElAi2ZzPj2SoG2jtS/+7W6K/OeqkN3rIht3XgtsNr0qx9h71kMwH3jpBQxGVY Mfd+VomeuWwCSRW/lZa91OMNqBbHRjzDtLaay+EaUA92qxYqaLwQ86Tadr0TmgZG+Tsi hgBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774849542; x=1775454342; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M7DVu227WmucQxYjqTod8kwtol9NGmVKJ1oGMwmvziw=; b=O7b3hZxqqSlg8vZYKBt/pB1udrJfwMeRkrTmFY7veTR+Q7iB2i8Bex0W/YAFwvMYr4 AV4qO2sjY7UxVkLlI2BIppbN7RQ2f6NQ64SCpZ5KKIySDFEGV4x3TwERQVhNSAjFoOi6 3IzHJJHakNXmEYkxUDOQqwU6jFnvfe5JBXMhekMGSkVOYhKglCXZlu+lEEIUWEaTmhLP 0V+CQnk91fvRdWTrbyn/MQQdwZEOTfGNf6t1VDVdveVqbkD/aMi8Hq70DcBWeuP8owi3 SJ6tKuXG3OsClcGBPr7Tqcz34vnYv0zos/q9uSAA8mQwujA4BVDbD1t/X0uap64JjqWb ShkA== X-Forwarded-Encrypted: i=1; AJvYcCU+fySvKxKF2H8/3QOZ2U2F66z2JSfA8H2kHfDCOw+araEX+VfRmc5YM78foe13R+p36/rPOsgD0ZMqINQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwX8DphfxFuRRchgdUNRgSFD+kq53YKZVwn2ztulxnNfmZfeGxE zZonHOKqjvkQS5xznjb1nGqvzqEtSjrPFHqm87H0Cx8TbapYj8MBQEw5zgqIZFyUbqWZJjH1OiR 1naCqBeGntL7jYVYAyAF4TLTo7yXB4JnandT39+nXS3qD1cL77Zr2qoGy9zncUIJb+eM= X-Gm-Gg: ATEYQzxhEcy50sHUfAV+FrRw7GTXwIWs3KeSKcM7PSRnGWnaIqOhlUIkh/Kx61MmcH1 mS1inh6uca9/JryjI5GTIdMXM6SoLiLnunxBerAWJ+tfBbHUb6FjDBIySFpAaRrw+MlMvnmJJ1S OAG/+BGrwaVjZp9omD2AYaY+6UB2gXLgqr7dxv51iZwQuf3qqmaKp2G+755ZdeTVOvlqGV4pwIf LUNdCFgAxLh/acjSf/im/bs3L7O+tNDHNYh24uOOHyyIfhYYqjVDSTSt2FP1ZZpoOhUJFGgT90G B5EuiT9GosfBLJOzLWGX5QxfbHcGS5g7NlX2/bx1Of8BFbS4kDIMHAnIBWR5dfoEnjvQVWb1gHd s9ainfcF5074fI07VazpLCcLgR6qvzgP8dwgMsEj/t/4+TJAsvA== X-Received: by 2002:a05:6a00:2d9c:b0:82a:5d55:5807 with SMTP id d2e1a72fcca58-82c95c2f178mr10993646b3a.6.1774849542309; Sun, 29 Mar 2026 22:45:42 -0700 (PDT) X-Received: by 2002:a05:6a00:2d9c:b0:82a:5d55:5807 with SMTP id d2e1a72fcca58-82c95c2f178mr10993609b3a.6.1774849541807; Sun, 29 Mar 2026 22:45:41 -0700 (PDT) Received: from [192.168.1.5] ([49.205.249.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca843e1desm6994238b3a.4.2026.03.29.22.45.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 22:45:41 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 11:14:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: iris: add new rate control type MBR for encoder To: Dmitry Baryshkov , Nicolas Dufresne Cc: Konrad Dybcio , Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260213-b4-add_sc7280_mbr-v1-0-e8d95b4e4809@oss.qualcomm.com> <20260213-b4-add_sc7280_mbr-v1-2-e8d95b4e4809@oss.qualcomm.com> <84895cad-9f1a-4e51-8e43-faf30b4bdabb@oss.qualcomm.com> <7f165169-427b-4f5b-9bee-bb227be23d82@oss.qualcomm.com> <69fea3d9214405996d2ecc50419e539e84f22a3a.camel@ndufresne.ca> Content-Language: en-US From: Sachin Kumar Garg In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=I8dohdgg c=1 sm=1 tr=0 ts=69ca0e07 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=YMTtrPfsndxwdlgdRDw1YA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=o5YXNfCz-0zmBcW412sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: hPWCSqESBiVJn6nnRXrVBI0NyKsWAfCe X-Proofpoint-ORIG-GUID: hPWCSqESBiVJn6nnRXrVBI0NyKsWAfCe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA0MiBTYWx0ZWRfX47fR8OROVMmX 795sqwdb1b7B31uw/Xyng9qM0NRh4OwNFQmHfILC9EmlsjZxd8weHOeX2PDHoUDuCinT5NHfVxf algIcVdcE5Zi+59hzRjzsrHhbx6hzNNLUegn595fQv830euOF/pKgCab76WkkZpL493/9aUy1Df iiM6EERykePqV9Pubswm6pYtQS8S/zpz9gOzgPUphHxpO9dSzrxS3KQdDGWfmPnZ6dDE/PnAv+e bLc5jsEfMiliMsE3evS74ntHU17dx9kZa+6OqrrCjhnBgAEDMgk1+25PEGJYkmpu8PRL3d5jE/K gUDQ2NpsarfDWsDSu7UzZEVm2BKLgLIa+/DjTZv/G9VQg2bo4pzMfSvDg4rN+Ptj+UDV+Czca1/ qXFwLFJP0EVgTIZ3gMDsx/JF2db4bwJ79QFGnAeQ9WDXf5wJVJCg4FcaVYoOihLbyv0eX60qVwp aQIzbn7tvECWxvqlGHA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300042 On 3/17/2026 12:17 AM, Dmitry Baryshkov wrote: > On Mon, Mar 16, 2026 at 01:37:21PM -0400, Nicolas Dufresne wrote: >> Le lundi 16 mars 2026 à 11:52 +0530, Sachin Kumar Garg a écrit : >>> >>> >>> On 2/13/2026 3:24 PM, Konrad Dybcio wrote: >>>> On 2/13/26 7:04 AM, Sachin Kumar Garg wrote: >>>>> Introduce V4L2_MPEG_VIDEO_BITRATE_MODE_MBR rate control to Encoder. >>>>> Encoder will choose appropriate quantization parameter and >>>>> do the smart bit allocation to set the frame maximum bitrate >>>>> level as per the Bitrate value configured. >>>>> --- >>>>>   drivers/media/platform/qcom/iris/iris_ctrls.c      |   2 + >>>>>   .../platform/qcom/iris/iris_hfi_gen1_defines.h     |   1 + >>>>>   .../media/platform/qcom/iris/iris_platform_gen1.c  |   9 +- >>>>>   .../platform/qcom/iris/iris_platform_sc7280.h      | 202 >>>>> +++++++++++++++++++++ >>>> >>>> Is this really only available on 7280? >>>> >>>> Konrad >>> >>> Yes Konrad, in this series we enable V4L2_MPEG_VIDEO_BITRATE_MODE_MBR >>> only for SC7280 because currently, we have added the support only for >>> low tier chipset. MBR rate control aims to improve the compression >>> efficiency of encoder for static and low motion scenes for extremely low >>> bitrate use-case. >> >> Without a spec definition, which constrained the implementations toward >> interoperability, this needs to be made vendor specific. That being said, even >> as vendor specific control, I think it deserves more documentation for your >> users. > > What kind of documentation would be a better fit for keeping this in the > generic namespace? Frankly speaking, I think that the current > documentation is too vendor-specific, it describe the particular > algorithm, while the control seems to be more generic. However, I also > feel that defining it as "Maximum Bitrate" might not be specific enough > (nor would it show a difference from the CBR mode). > > Thanks for the suggestion. I understand that this functionality is vendor-specific and should not be exposed via a generic control. Would it be acceptable to convert this into a vendor-specific control (for example, V4L2_MPEG_VIDEO_BITRATE_MODE_QCOM_MBR) and update the documentation accordingly? Please let me know if this aligns with upstream expectations, or can you please suggest if there is any other preferred approach for adding vendor-specific controls in this case. Thanks, Sachin