From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F2143EA959 for ; Fri, 17 Jul 2026 10:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784283106; cv=none; b=cr9LaZ2oFgRl2AGZgf720XhGFYYkxZFwpUqYv3anxLcJ8x6p2sNwJzs9ENRv97dPssX3IqFwh8NiPcCbDRHEK2Fz84HTTy52HnEsJhKUSckaELO7XAcj1iaQfKCi6aZB0S8MJdVD8VWOQhoDB1b93TVxC5QKWdPpLIBTX+oOWqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784283106; c=relaxed/simple; bh=L/O1iAq6+atDhuVBjxvUN1vUvgMn7GUQFHZhyFnCgEs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GGh6iiK4XBgKK9hA0cma/E2XwYbcXGP5W/1Qbp30Hs43VcPcXY3IsOzVEY0/moRHGMShKkeisNp112lLxyxVuZz1eqtcTZi1WKePi9Pt1vWLdOqNUHwRzkueuGFTWjuGKGdPvbklI4rYzxrbh3cll+V8ZXFxaXDS8GaheeAi5rQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZHdtxi27; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hfFQtuNQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZHdtxi27"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hfFQtuNQ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H6cTna851698 for ; Fri, 17 Jul 2026 10:11:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o6NcGdJD2SJbC+6pbz4eT093TTMm6bTq2YROpOJJcrc=; b=ZHdtxi27ytVvjJB5 MJXMJoC9oIP+eK/dNfbiVEWyhsgduyq5QYO00PfHTLRCWR6Rl6sxdghvc9He/XE7 lTuLWUuQvlYUTEo788TEWmG4eV9FHH4PJ1KaKETz2meOeo/9O1HJ4PDjCOQc6Itu 0ZMVAWkspeoqz0JliDadxKDQKmTUAklPLmIg+ABTK+eQpXP7b/wDlbP67lKOXZJi fwQjxS5Lj6JqBSWzJMY+4arjddUDDBzqDyFPyIHVpXaa2mxbd3Us2oShxuQ+qjxF BLPefinXXfZl6o8v0IxVNnAX9IQBIv6kj+tfN6hnc4y9F8RTC5fIj/Azc04FYN0r lgn6Pw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9p8tdu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 10:11:43 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c9d953b71so8803061cf.0 for ; Fri, 17 Jul 2026 03:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784283103; x=1784887903; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o6NcGdJD2SJbC+6pbz4eT093TTMm6bTq2YROpOJJcrc=; b=hfFQtuNQYWsPK+KB94k+60J5jY5Z9/l+a359qJKY3VP0bgV8RgYBu1TcCrc0rrSk+u 9Malm4V+cSAdTDziIYssLKjKWbWkqlWEqFm1g5dXpBXwHjlJoulzw+TbT/VBoWq+d2fM TTYPIvo1ykda3YhT6Yz4Ej8bR/okUDRjpdxenjPSTCBOkGnsiO6Noeo7Wysq3DiyHBve pLZfimOzEsUCImAVsUM8G9A0G0FthIrLy9zTKU5kSueH7nTPdJoCvy9GI2YD+O0T19T4 NXnfIm1/OpI9YVfIg/o7+8FlLF11OT3gKAuNAMYwrWxRVXRLWkncUzThXgR0ykvduOHb 9sfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784283103; x=1784887903; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o6NcGdJD2SJbC+6pbz4eT093TTMm6bTq2YROpOJJcrc=; b=bgnO+Zs3VpAn+KE0nDnowuG7rGXS/NYoX0DC3aFmT272zq3rava2EmTQZC0550+J1w yW2a0XKrCuYxtPhU9/RhGR9EFS1YFy71ioub7mTbMeFLEa9gFEDGconomWzMMe8KgvPF 6J9X+amL+Ay8rGTyxKd9KM9scgubwn7jcxMC74ApYfViXpw6ZaG+U06SpOabkl4JqPO7 Pn8RRVWiHdfL5Nmf2e0Ao6pLKwWng9vhhdVK5qnaMbsBK/d+Puq7bBSY+mGVDe3SKKx/ SM36xWoJkFW3uh5QMyipYIMgjOld792Tr+xSp/cCBh3do5vwX6gBt3a9ieh8e/HgFFDD ORLA== X-Forwarded-Encrypted: i=1; AHgh+RrHV9uieARG6ydX12YDhLVML62W2XoYEAnzv+uBQ20yVr6SpCkUYEC4SlcYMX2a1LzpipHV5oRvR7/OWG4=@vger.kernel.org X-Gm-Message-State: AOJu0YwajGbKSoKBkmUDWK9j8Ws/R8cIkTk31AH4Ps9/PQyQXeIh7sEU YDuUsSJMakVqZXPUHZKAoyUyKUbG+M1ih+E5unSNM3KCWIBm45JpzstHOdCTFjquHLe2KPornax YNZaBgEQITaQSyTNtE7cOCy1eTCnbYaLWYPByNTyPWLuoeC7cLX4+ezL49izlBqQEPwQ= X-Gm-Gg: AfdE7cm0zZqVejP0W3BaPU0LMME6Iyn8Bd8Z2d3/SZJlhE1lP4ZEmBcOmn0USzQx8WU v7FZ+NvJMal28ViIa8Ksp8s78o5ZwT8owstAaKtDmKe+6yauzLxm+4zE90dHO9INhjncZiW0PG+ bJLM1LBzfKx5i5fnaZUg1jYJvkuLzVKce5Mc8Evtls55vY+4lukQXP9WKlQ6HTvLtGajZ5Lgzar SsQA9bVQBZJxO5x/VfhYeu8fJyk08qY0hknsS1RC/m94EeoODuUSg7y/h3ugF83S9hOPOPiRvN3 /CaxGcgZI27NI4FqdvReJhJGoY3FjPEHNPHkR6cyUrMhr7aoi3VF9BO3eCYIYt7baQby2WOj0yA wHaSV+9gY/UQyF1N+cfW6KPP1 X-Received: by 2002:a05:622a:1901:b0:51c:4ffa:9b71 with SMTP id d75a77b69052e-5213e084841mr13148181cf.6.1784283103244; Fri, 17 Jul 2026 03:11:43 -0700 (PDT) X-Received: by 2002:a05:622a:1901:b0:51c:4ffa:9b71 with SMTP id d75a77b69052e-5213e084841mr13147971cf.6.1784283102812; Fri, 17 Jul 2026 03:11:42 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1724f50b72sm51742466b.48.2026.07.17.03.11.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 03:11:41 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 12:11:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vivek Aknurwar Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713-maili_initial_clock-v2-0-79548f0bb58f@oss.qualcomm.com> <20260713-maili_initial_clock-v2-4-79548f0bb58f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260713-maili_initial_clock-v2-4-79548f0bb58f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XtGU_PHIPr1KiQNP-HvslGb-oGCFygbu X-Proofpoint-ORIG-GUID: XtGU_PHIPr1KiQNP-HvslGb-oGCFygbu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDEwMSBTYWx0ZWRfXyGEsiV2vk1ki Ny358c96qdzxV1u6xG5OKdJ/oKICNkU1LHm1Ma2W8sMZ8nzrJgAqh7/dRV7pyLGqxYUTIAGipwO RRlwA2sS1bGcY+6fyUvVGysnKZkcmX7KMEQtjA9pjnzt+nltWqK6OASSr+MIQM6IdAZUkORmtI8 xheMLQpgXTTYK/K08OfzxsJgWsrZKw07wFMJVgGkycnzQ9onga13EX7sqVDty0/viCadYM6BGJ2 s+tPGlmV61bXQsDr6J7zW2ApRqOc+UjzQWPnWSrJS1p++Y+bfGjenq67yvM/gB6iF67beDsdYem 8YQz2vIT7LpwYHWPDK4cqkdJzJcj0qyhXVcTGcwFHnhZUk1VdkAC9dIqQrypMZga78QcGlRyJnG ABrTOzdq3C4KYcfaaw/FVd08W+0p6nW8CpE9FXVl0o62pol2mIRrwTMzgiF9vlEiy7HgOV7yyLW pwZXxJWa5MZzrcaxhWg== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a59ffdf cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=FjjYY-ANMnpf8f3CrbkA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDEwMSBTYWx0ZWRfX1r5/pqHqen8i c09BN/EcSpEDdAbkTxtzL8nc0fcl3FmuIFFGg+bqU4wTNrjILnmLBHu8TZEqOaSFJRtVAm3Q8pn n6YTK4qN3bqHfff6va0UtKAErdddQx8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170101 On 7/13/26 11:04 AM, Taniya Das wrote: > Add support for the global clock controller (GCC) on the Qualcomm Maili > SoC by extending the Hawi global clock controller since Maili is identical > to Hawi and has few additional clocks. > > Signed-off-by: Taniya Das > --- [...] > + /* > + * Maili-only clocks: NULL here to size the array to the highest Maili > + * clock index. > + */ > + [GCC_QUPV3_WRAP_5_S_AHB_CLK] = NULL, This is unnecessary/wrong, as desc->num_clks validates the index in qcom_cc_clk_hw_get(). Without this, we'd get an -EINVAL, with this we get a silent nullptr Konrad