From: Dmitry Skorodumov <skorodumov.dmitry@huawei.com>
To: Eric Dumazet <edumazet@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andrey.bokhanko@huawei.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 06/14] ipvlan: Support GSO for port -> ipvlan
Date: Thu, 6 Nov 2025 18:41:42 +0300 [thread overview]
Message-ID: <bd0da59d-153f-4930-851a-68117dbcc2de@huawei.com> (raw)
In-Reply-To: <dfad18c7-0721-486a-bd6e-75107bb54920@huawei.com>
On 05.11.2025 19:58, Dmitry Skorodumov wrote:
> On 05.11.2025 19:29, Eric Dumazet wrote:
>> On Wed, Nov 5, 2025 at 8:15 AM Dmitry Skorodumov
>> <skorodumov.dmitry@huawei.com> wrote:
>>> If main port interface supports GSO, we need manually segment
>>> the skb before forwarding it to ipvlan interface.
>> Why ?
Hm, really, this patch is not needed at all. tap_handle_frame() already does everything needed. Looks like I had another trouble and this patch was an attempt to fix it.
>> Also I do not see any tests, for the whole series ?
> Ok, If modules like this have some kind of unit-tests, I should study it and provide it. I haven't seen this as a common practice for most of the modules here. So far all testing is made manually (likely this should be described anyway)
I see that currently there is no any tests for this ipvlan module (may be I missed something).. Do you have any ideas about tests? I'm a bit confused at the moment: designing tests from scratch - this might be a bit tricky.
Or it is enough just describe test-cases I checked manually (in some of the patches of the series)?
Dmitry
next prev parent reply other threads:[~2025-11-06 15:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251105161450.1730216-1-skorodumov.dmitry@huawei.com>
2025-11-05 16:14 ` [PATCH net-next 01/14] ipvlan: Preparation to support mac-nat Dmitry Skorodumov
2025-11-05 23:32 ` Bagas Sanjaya
2025-11-06 23:30 ` kernel test robot
2025-11-05 16:14 ` [PATCH net-next 02/14] ipvlan: Send mcasts out directly in ipvlan_xmit_mode_l2() Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 03/14] ipvlan: Handle rx mcast-ip and unicast eth Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 04/14] ipvlan: Added some kind of MAC NAT Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 05/14] ipvlan: Forget all IP when device goes down Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 06/14] ipvlan: Support GSO for port -> ipvlan Dmitry Skorodumov
2025-11-05 16:29 ` Eric Dumazet
2025-11-05 16:58 ` Dmitry Skorodumov
2025-11-06 15:41 ` Dmitry Skorodumov [this message]
2025-11-06 15:56 ` Eric Dumazet
2025-11-07 11:26 ` Dmitry Skorodumov
2025-11-06 16:19 ` Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 07/14] ipvlan: Support IPv6 for learnable l2-bridge Dmitry Skorodumov
2025-11-11 0:33 ` kernel test robot
2025-11-05 16:14 ` [PATCH net-next 08/14] ipvlan: Make the addrs_lock be per port Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 09/14] ipvlan: Take addr_lock in ipvlan_open() Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 10/14] ipvlan: Don't allow children to use IPs of main Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 11/14] ipvlan: const-specifier for functions that use iaddr Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 12/14] ipvlan: Common code from v6/v4 validator_event Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 13/14] ipvlan: common code to handle ipv6/ipv4 address events Dmitry Skorodumov
2025-11-05 16:14 ` [PATCH net-next 14/14] ipvlan: Ignore PACKET_LOOPBACK in handle_mode_l2() Dmitry Skorodumov
2025-11-06 9:03 ` [syzbot ci] Re: ipvlan: support mac-nat mode syzbot ci
[not found] <20251105160713.1727206-1-skorodumov.dmitry@huawei.com>
2025-11-05 16:07 ` [PATCH net-next 06/14] ipvlan: Support GSO for port -> ipvlan Dmitry Skorodumov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd0da59d-153f-4930-851a-68117dbcc2de@huawei.com \
--to=skorodumov.dmitry@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrey.bokhanko@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®