mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@linaro.org>,
	Paul Adam <adamp@posteo.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
Date: Tue, 10 Mar 2026 13:30:48 +0100	[thread overview]
Message-ID: <bd0dc1de-c157-4f18-8010-ecade0a4b40f@oss.qualcomm.com> (raw)
In-Reply-To: <aa9Epb7MQ0qVFWGO@linaro.org>

On 3/9/26 11:07 PM, Stephan Gerhold wrote:
> On Mon, Mar 09, 2026 at 09:48:12PM +0000, Paul Adam wrote:
>> On 26/03/09 10:16, Stephan Gerhold wrote:
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts
>>>> new file mode 100644
>>>> index 000000000000..d927bae2b208
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts
>>>> @@ -0,0 +1,315 @@
>>>> [...]
>>>> +&sound {
>>>> +	audio-routing = "AMIC1", "MIC BIAS Internal1",
>>>> +		"AMIC2", "MIC BIAS Internal2",
>>>> +		"AMIC3", "MIC BIAS Internal1";
>>>
>>> Sorry, just noticed this now:
>>>
>>> This seems a bit suspicious (I would expect "MIC BIAS Internal3"), have
>>> you tested if the secondary microphone works?
>>>
>>> Thanks,
>>> Stephan
>>
>> The secondary microphone does not work yet, neither with Internal1
>> nor Internal3.
>>
>> In the downstream devicetree its Internal1 for AMIC3.
>>
>> Is there a way for me to check which one is correct?
>>
> 
> To be absolutely sure, only with the schematic diagram of the board...
> 
> Another option would be that the secondary microphone simply does not
> exist at all (i.e. there is only one microphone). Any idea if it works
> on Android?
> 
> If in doubt, it would be better to remove the line for AMIC3.

whichever way it goes:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad


  reply	other threads:[~2026-03-10 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 17:23 [PATCH v4 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay
2026-03-07 17:23 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
2026-03-07 17:23 ` [PATCH v4 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay
2026-03-07 17:23 ` [PATCH v4 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay
2026-03-09  9:16   ` Stephan Gerhold
2026-03-09 21:48     ` Paul Adam
2026-03-09 22:07       ` Stephan Gerhold
2026-03-10 12:30         ` Konrad Dybcio [this message]
2026-03-11 18:40         ` Paul Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd0dc1de-c157-4f18-8010-ecade0a4b40f@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=adamp@posteo.de \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®