From: Dan Carpenter <dan.carpenter@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Su Hui <suhui@nfschina.com>,
alexander.usyskin@intel.com, tomas.winkler@intel.com,
arnd@arndb.de, nathan@kernel.org, ndesaulniers@google.com,
trix@redhat.com, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write
Date: Mon, 4 Dec 2023 16:11:31 +0300 [thread overview]
Message-ID: <bd13cda0-6437-40fa-a73a-9770be6f0167@suswa.mountain> (raw)
In-Reply-To: <2023120452-stool-party-bf2b@gregkh>
On Mon, Dec 04, 2023 at 09:00:42AM +0100, Greg KH wrote:
> > diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
> > index 7ea80779a0e2..0489bec4fded 100644
> > --- a/drivers/misc/mei/client.c
> > +++ b/drivers/misc/mei/client.c
> > @@ -2033,7 +2033,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time
> > hbuf_slots = mei_hbuf_empty_slots(dev);
> > if (hbuf_slots < 0) {
> > rets = -EOVERFLOW;
> > - goto out;
> > + goto err;
>
> Please prove that this is correct, as based on the code logic, it seems
> very wrong. I can't take this unless the code is tested properly.
Hi Greg,
When Su Hui sent the v2 patch you sent an auto response about adding
stable to the CC list.
https://lore.kernel.org/all/2023112042-napped-snoring-b766@gregkh/
However, it appears that you still applied the v2 patch. It's in
linux-next as commit ee6236027218 ("misc: mei: client.c: fix problem of
return '-EOVERFLOW' in mei_cl_write").
When I use `git am` to apply this patch, then it doesn't apply. However,
when I use cat email.txt | patch -p1 then it tries to reverse the patch
and apply it to a different function.
So this a kind of confusing thing.
regards,
dan carpenter
next prev parent reply other threads:[~2023-12-04 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 1:45 Su Hui
2023-12-04 8:00 ` Greg KH
2023-12-04 13:11 ` Dan Carpenter [this message]
2023-12-04 13:17 ` Greg KH
2023-12-05 2:30 ` Su Hui
2023-12-05 5:30 ` Usyskin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd13cda0-6437-40fa-a73a-9770be6f0167@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=suhui@nfschina.com \
--cc=tomas.winkler@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®