From: Sagi Grimberg <sagi@grimberg.me>
To: "brookxu.cn" <brookxu.cn@gmail.com>,
kbusch@kernel.org, axboe@kernel.dk, hch@lst.de
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] nvme-tcp: fix hung issues for deleting
Date: Tue, 6 Jun 2023 02:09:08 +0300 [thread overview]
Message-ID: <bd1676d2-4078-4c02-14a9-e2f5ebe2dd29@grimberg.me> (raw)
In-Reply-To: <cover.1685350577.git.chunguang.xu@shopee.com>
> From: Chunguang Xu <chunguang.xu@shopee.com>
>
> We found that nvme_remove_namespaces() may hang in flush_work(&ctrl->scan_work)
> while removing ctrl. The root cause may due to the state of ctrl changed to
> NVME_CTRL_DELETING while removing ctrl , which intterupt nvme_tcp_error_recovery_work()/
> nvme_reset_ctrl_work()/nvme_tcp_reconnect_or_remove(). At this time, ctrl is
> freezed and queue is quiescing . Since scan_work may continue to issue IOs to
> load partition table, make it blocked, and lead to nvme_tcp_error_recovery_work()
> hang in flush_work(&ctrl->scan_work).
>
> After analyzation, we found that there are mainly two case:
> 1. Since ctrl is freeze, scan_work hang in __bio_queue_enter() while it issue
> new IO to load partition table.
> 2. Since queus is quiescing, requeue timeouted IO may hang in hctx->dispatch
> queue, leading scan_work waiting for IO completion.
Hey, can you please look at the discussion with Mings' proposal in
"nvme: add nvme_delete_dead_ctrl for avoiding io deadlock" ?
Looks the same to me.
next prev parent reply other threads:[~2023-06-05 23:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 10:59 brookxu.cn
2023-05-29 10:59 ` [RFC PATCH 1/4] nvme: unfreeze while exit from recovery or resetting brookxu.cn
2023-05-29 10:59 ` [RFC PATCH 2/4] nvme: donot retry request for NVME_CTRL_DELETING_NOIO brookxu.cn
2023-05-29 10:59 ` [RFC PATCH 3/4] nvme: optimize nvme_check_ready() " brookxu.cn
2023-05-29 10:59 ` [RFC PATCH 4/4] nvme-tcp: remove admin_q quiescing from nvme_tcp_teardown_io_queues brookxu.cn
2023-06-05 23:09 ` Sagi Grimberg [this message]
2023-06-06 14:32 ` [RFC PATCH 0/4] nvme-tcp: fix hung issues for deleting 许春光
2023-06-06 14:41 ` 许春光
2023-06-06 15:14 ` Ming Lei
2023-06-07 4:09 ` 许春光
2023-06-08 0:56 ` Ming Lei
2023-06-08 2:48 ` 许春光
2023-06-08 13:51 ` Ming Lei
2023-06-09 3:17 ` 许春光
2023-06-09 3:23 ` 许春光
2023-06-11 8:11 ` Sagi Grimberg
2023-06-12 1:33 ` Ming Lei
2023-06-12 6:36 ` Sagi Grimberg
2023-06-13 1:01 ` Ming Lei
2023-06-12 8:24 ` 许春光
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd1676d2-4078-4c02-14a9-e2f5ebe2dd29@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®