From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A48ECE58C for ; Tue, 15 Oct 2019 06:18:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E64E7217F9 for ; Tue, 15 Oct 2019 06:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbfJOGS1 (ORCPT ); Tue, 15 Oct 2019 02:18:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3756 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726044AbfJOGS1 (ORCPT ); Tue, 15 Oct 2019 02:18:27 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 78EA37BF91BCA7785E15; Tue, 15 Oct 2019 14:18:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 15 Oct 2019 14:18:21 +0800 Subject: Re: Regression in longterm 4.19: f2fs: use generic EFSBADCRC/EFSCORRUPTED To: Andrew Macks CC: Pavel Machek , , Greg KH , kernel list , Jaegeuk Kim References: <20191013214440.GA20196@amd> From: Chao Yu Message-ID: Date: Tue, 15 Oct 2019 14:18:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191013214440.GA20196@amd> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/14 5:44, Pavel Machek wrote: > On Sat 2019-10-12 21:55:24, Andrew Macks wrote: >> Sorry for version typo in the previous message. >> >> In addition to 4.19, the issue was also backported to 4.14 and 5.2. >> >> 4.14, 4.19 and 5.2 are all missing the EINVAL fix from 5.3. > > Ouch. > > Well, when I seen the patch, I thought "looks like the bug is not > serious enough for -stable". I guess I should have spoken up. > > Anyway, I guess we need to either revert 59a5cea41dd0a or backport > 38fb6d0ea34299d97b too.... > > So I guess Greg and lists need to be cc-ed... and > > Thanks for the report and sorry for the trouble.... I'm so sorry to introduce original bug, the fixing patch ("f2fs: use EINVAL for superblock with invalid magic") should be backported to stable kernel as soon as possible. Thanks, > > Pavel > > >> Andrew. >> >> On Sat, 12 Oct 2019 at 21:39, Andrew Macks wrote: >> >>> Hi - there is a nasty regression which was recently introduced into >>> longterm 4.19.76. >>> >>> 59a5cea41dd0ae706ab83f8ecd64199aadefb493 was committed to 4.19, however it >>> introduces a regression that filesystems no longer mount if do_mounts >>> iterates through them after F2FS. This surfaced on one of my servers as >>> F2FS superblock check happens before btrfs mount is attempted. >>> >>> With this code, my server panicked after kernel upgrade as btrfs mount >>> wasn't attempted. >>> >>> This issue has already been fixed in 5.3 with this patch in July, but it >>> was missed from the 4.19 backport. >>> >>> 38fb6d0ea34299d97b031ed64fe994158b6f8eb3 >>> f2fs: use EINVAL for superblock with invalid magic >>> >>> Andypoo. >>> >