From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout07.his.huawei.com (canpmsgout07.his.huawei.com [113.46.200.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4FE917BEBF; Thu, 22 Jan 2026 08:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.222 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769070437; cv=none; b=JIuaCgOin5zYwCBQqTO6LtdIFnq59t7Qs3T/hEJVLJ1IT69AKRAx+j9vuA+cnA5cfItbL/8c/UJupqQvpU19d4djsbsz8Zu00uquNQJ51Yk2gaoHOlym+pkAE5NJZ15SRfRSEusZKIx21gq8pNhMl3EEhLwdK+yfKSxRqCIm42o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769070437; c=relaxed/simple; bh=4oCdp3L5Oc/h2mFCOwl6AVhYMe9ODqCGXT1MIJG4fOE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qeOapHjCpE2DEQvA6WvHcoKHs7NLCrD5JHF5N09uRWDnTO21cRjSs3TOh7AkqgpZsTiiKCVSTLgNZ7dI5k3+3BXvIQV3r/tXh6QY9EZQEfA9B0w3Xi5FPoobhCve1rbz0K7wxfatDJ+UBGuwAtjvdd48NQ5BXtxOttZCvo0Y5uA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=NTGLDLbG; arc=none smtp.client-ip=113.46.200.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="NTGLDLbG" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ycLwncsvVdmKPKvuy/F0Ic9J+vzT0coN7yOMb+BhP/s=; b=NTGLDLbGBDs91hKTlNr7BOJSTW+kA+asoDQUhtlHfpC8gc/6VKkuSoqWoOJug2bPvIF8+FvN3 EXR8ZbmPASVRJO7yiJxvKQe2h6MiKWfNUFzCPgFelwvWWKDc7/Au/SQkj41uKgIG7dES6Ai4Zw6 6q9fFyzbUsEPiQ5qRDS7q7U= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4dxYxH3Cd0zLlZK; Thu, 22 Jan 2026 16:23:47 +0800 (CST) Received: from kwepemf200001.china.huawei.com (unknown [7.202.181.227]) by mail.maildlp.com (Postfix) with ESMTPS id 27A6E40565; Thu, 22 Jan 2026 16:27:11 +0800 (CST) Received: from [10.67.121.90] (10.67.121.90) by kwepemf200001.china.huawei.com (7.202.181.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Jan 2026 16:27:10 +0800 Message-ID: Date: Thu, 22 Jan 2026 16:27:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/9] cpufreq: CPPC: Add generic helpers for sysfs show/store To: Sumit Gupta CC: , , , , , , , , , , , , , , , , , , , , , , , , , References: <20260120145623.2959636-1-sumitg@nvidia.com> <20260120145623.2959636-2-sumitg@nvidia.com> From: "zhenglifeng (A)" In-Reply-To: <20260120145623.2959636-2-sumitg@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemf200001.china.huawei.com (7.202.181.227) On 2026/1/20 22:56, Sumit Gupta wrote: > Add generic helper functions for u64 sysfs attributes that follow the > common pattern of calling CPPC get/set APIs: > - cppc_cpufreq_sysfs_show_u64(): reads value and handles -EOPNOTSUPP > - cppc_cpufreq_sysfs_store_u64(): parses input and calls set function > > Add CPPC_CPUFREQ_ATTR_RW_U64() macro to generate show/store functions > using these helpers, reducing boilerplate for simple attributes. > > Convert auto_act_window and energy_performance_preference_val to use > the new macro. > > No functional changes. > > Signed-off-by: Sumit Gupta > --- > drivers/cpufreq/cppc_cpufreq.c | 69 ++++++++++++---------------------- > 1 file changed, 25 insertions(+), 44 deletions(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 36e8a75a37f1..c95dcd7719c3 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -863,73 +863,54 @@ static ssize_t store_auto_select(struct cpufreq_policy *policy, > return count; > } > > -static ssize_t show_auto_act_window(struct cpufreq_policy *policy, char *buf) > +static ssize_t cppc_cpufreq_sysfs_show_u64(unsigned int cpu, > + int (*get_func)(int, u64 *), > + char *buf) > { > u64 val; > - int ret; > - > - ret = cppc_get_auto_act_window(policy->cpu, &val); > + int ret = get_func((int)cpu, &val); > > - /* show "" when this register is not supported by cpc */ > if (ret == -EOPNOTSUPP) > return sysfs_emit(buf, "\n"); > - I think it is better to keep this blank line. Apart from this Reviewed-by: Lifeng Zheng > if (ret) > return ret; > > return sysfs_emit(buf, "%llu\n", val); > } > > -static ssize_t store_auto_act_window(struct cpufreq_policy *policy, > - const char *buf, size_t count) > +static ssize_t cppc_cpufreq_sysfs_store_u64(unsigned int cpu, > + int (*set_func)(int, u64), > + const char *buf, size_t count) > { > - u64 usec; > + u64 val; > int ret; > > - ret = kstrtou64(buf, 0, &usec); > + ret = kstrtou64(buf, 0, &val); > if (ret) > return ret; > > - ret = cppc_set_auto_act_window(policy->cpu, usec); > - if (ret) > - return ret; > + ret = set_func((int)cpu, val); > > - return count; > + return ret ? ret : count; > } > > -static ssize_t show_energy_performance_preference_val(struct cpufreq_policy *policy, char *buf) > -{ > - u64 val; > - int ret; > - > - ret = cppc_get_epp_perf(policy->cpu, &val); > - > - /* show "" when this register is not supported by cpc */ > - if (ret == -EOPNOTSUPP) > - return sysfs_emit(buf, "\n"); > - > - if (ret) > - return ret; > - > - return sysfs_emit(buf, "%llu\n", val); > +#define CPPC_CPUFREQ_ATTR_RW_U64(_name, _get_func, _set_func) \ > +static ssize_t show_##_name(struct cpufreq_policy *policy, char *buf) \ > +{ \ > + return cppc_cpufreq_sysfs_show_u64(policy->cpu, _get_func, buf);\ > +} \ > +static ssize_t store_##_name(struct cpufreq_policy *policy, \ > + const char *buf, size_t count) \ > +{ \ > + return cppc_cpufreq_sysfs_store_u64(policy->cpu, _set_func, \ > + buf, count); \ > } > > -static ssize_t store_energy_performance_preference_val(struct cpufreq_policy *policy, > - const char *buf, size_t count) > -{ > - u64 val; > - int ret; > +CPPC_CPUFREQ_ATTR_RW_U64(auto_act_window, cppc_get_auto_act_window, > + cppc_set_auto_act_window) > > - ret = kstrtou64(buf, 0, &val); > - if (ret) > - return ret; > - > - ret = cppc_set_epp(policy->cpu, val); > - if (ret) > - return ret; > - > - return count; > -} > +CPPC_CPUFREQ_ATTR_RW_U64(energy_performance_preference_val, > + cppc_get_epp_perf, cppc_set_epp) > > cpufreq_freq_attr_ro(freqdomain_cpus); > cpufreq_freq_attr_rw(auto_select);